Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Filtering Log to show which cosmetic rules were applied (like AG Chrome Extension does) #2551

Closed
adrianh-za opened this issue Apr 2, 2019 · 4 comments
Labels

Comments

@adrianh-za
Copy link

AdGuard for Windows groups all cosmetic filters applied into single log entry. It would be great to be able to see individual cosmetic filters that were applied like AdGuard Chrome Extention displays.

The is the same website using same filter list, first using AG for Windows, and second using AG Chrome Extension. Notice the yellow log entries for AG for Windows that states 9 rules were applied, but the AG Chrome Extension list all 9 yellow log entries.

AGforWin

AGforChrome

Your environment

  • AG Version: Latest AG for Windows nightly as at 2 April 2019
  • Environment name and version: Google Chrome Version 73.0.3683.86 (Official Build) (64-bit)
  • Operating system and version: Windows 10
@adbuker
Copy link

adbuker commented Apr 5, 2019

Unfortunately, this is impossible in AGW due to the fact that all the cosmetic rules, which can be even theoretically related to the request, injected into the HTML page and only then some of them modify DOM. AGW cannot detect what particular rules were applied to the page (i.e. to the HTML's DOM), while AG Chrome extension can (because of another work principle)

@adbuker adbuker added the wontfix label Apr 5, 2019
@adbuker adbuker closed this as completed Apr 5, 2019
@ameshkov
Copy link
Member

ameshkov commented Apr 7, 2019

@adbuker well, this is possible actually, why can't content script detect applied cosmetic rules and then notify the program about them?

@ameshkov
Copy link
Member

ameshkov commented Apr 7, 2019

Also, we already have this feature request in the CoreLibs repo:
AdguardTeam/CoreLibs#180

@adbuker
Copy link

adbuker commented Apr 8, 2019

hm, I meant with the currently available tool, it's my confusion. Indeed, the enhancement in the content-script solve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants