Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signin.costco.com #188137

Closed
adguard-bot opened this issue Sep 6, 2024 · 12 comments
Closed

signin.costco.com #188137

adguard-bot opened this issue Sep 6, 2024 · 12 comments
Assignees

Comments

@adguard-bot
Copy link

Issue URL (Incorrect Blocking)

http://signin.costco.com

Comment

I am unable to log in to costco.ca (which goes through signin.costco.com) with AdGuard enabled. Even when I've disabled every single filtering option in the app, it only works if I actually quit AdGuard.
Username: @deviantintegral

Screenshots

Screenshot 1

Screenshot 1

Screenshot 1 with AdGuard disabled

Screenshot 1

System configuration

Information Value
AdGuard product: AdGuard for Mac v2.15.1.1731 release
System version: macOS 14.6.1
Browser: Safari
License type: paid
Tracking protection: disabled
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base
Browsing Security: disabled
Browsing Security statistics: disabled
Userscripts: disabled
Userstyles: disabled
Other extensions used: 1Password, Kagi for Safari
@deviantintegral
Copy link

I think there was lag between changing my settings and them taking effect. I've narrowed this down to filters - I can replicate with these filters enabled but DNS filtering, stealth mode, phishing protection, and AdGuard Extra disabled. I'll see if I can narrow down the ruleset and rules:

image

@deviantintegral
Copy link

I now wonder if this a bug in the AdGuard proxy and not the rules themselves. I wasn't seeing all of the requests in the filtering log that I saw in Safari. Then I restarted, and I now see a dropped network connection that AdGuard says it let pass. When I quit AdGuard this error doesn't happen and I can log in.

image

@Sergey-Lyapin Sergey-Lyapin added A: In progress Work on the issue is in progress A: Cannot reproduce Filters devs cannot reproduce this issue labels Sep 13, 2024
@Sergey-Lyapin
Copy link
Contributor

Hello @deviantintegral
I was able to log in successfully, is this issue still relevant?

@Sergey-Lyapin Sergey-Lyapin added the A: Waiting for data Waiting for more information from the user label Sep 13, 2024
@deviantintegral
Copy link

Yes, I can still replicate it, and fix it by quitting AdGuard.

Is there any delay in changing the following settings?

  • Advanced tracking protection under Stealth Mode
  • Phishing and malware protection under Security
  • The Extensions checkbox under Extensions

If not, then all I have left enabled is AdGuard Base filter. So, I think the issue is either in one of those rules, or some bug in the filtering process itself.

I also noticed similar behaviour with logging in at aircanada.com with Safari's web inspector showing "The network connection was lost" and not records of the same request in AdGuard's filtering log.

@deviantintegral
Copy link

I turned off the last remaining filter (the base filter) and restarted, and I can replicate this still. The only thing that fixes it is fully quitting AdGuard. I've also since upgraded to macOS 15 / Safari 18.

I also noticed AdguardTeam/AdguardForMac#1466 so I may upgrade to the latest nightly and see if things are improved.

@deviantintegral
Copy link

I've confirmed this is still an issue in version 2.16.0.1814 nightly. At this point, I'll be waiting for suggestions from anyone with AdGuard.

@Alex-302
Copy link
Member

Alex-302 commented Oct 1, 2024

@deviantintegral Hi.
Could you please test both rules?

/.*/$document
/.*/$stealth

They will apply to all requests. Then must be deleted.

@deviantintegral
Copy link

What were you hoping to see with those? Something in the logs? They blocked all access to all pages.

@Alex-302
Copy link
Member

Alex-302 commented Oct 3, 2024

Sorry. Forgot @@
Correct rules (unblocking)

@@/.*/$document
@@/.*/$stealth

These rules must completely disable filtering rules and AdGuard injections (cosmetic rules, scriptlets, AG extensions).

@Sergey-Lyapin
Copy link
Contributor

@deviantintegral

@deviantintegral
Copy link

Unfortunately those rules didn't fix the issue. I saw them immediately working (ads and other things were unblocked), but I was unable to sign in. And still, quitting AdGuard and reloading the page let me log in successfully.

@Sergey-Lyapin
Copy link
Contributor

Hello @deviantintegral
I recreated the issue en CoreLibs repo.

@Sergey-Lyapin Sergey-Lyapin closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
@Sergey-Lyapin Sergey-Lyapin removed A: In progress Work on the issue is in progress A: Waiting for data Waiting for more information from the user labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants