Can't remove AdAway blocklist on Edge

[devipasigner]

Prerequisites

• I have checked the Wiki and Discussions and found no answer

• I have searched other issues and found no duplicates

• I want to report a bug and not ask a question

Operating system type

Linux, Other (please mention the version in the description)

CPU architecture

AMD64

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

v0.108.0-a.508+15bba281

Description

What did you do?

Fresh install AdGuard Home Edge Build, go to blocklist tab, and remove both default blocklists.

Expected result

Both the AdGuard DNS filter and AdAway blocklist are removed.

Actual result

Only AdGuard DNS filter is able to removed. AdAway remains, and cannot be removed no matter what.

Screenshots (if applicable)

Nah.

Additional information

Another question, why is this blocklist even selected by default? Theres no point in adding it if its in a disabled state. If users want to use the AdAway blocklist they can select it through the "Choose from the list" options, just like every other blocklist. What makes AdAway so special?

[ainar-g]

We cannot reproduce this behavior, although it could be caused by #5647. When you say that “AdAway remains”, do you mean that you see it there after a page refresh, or does it not disappear at all?

Another question, why is this blocklist even selected by default? […]

Please direct questions to the Discussions, as we strive to keep the Issues section dedicated to bugs and improvements only.

[devipasigner]

We cannot reproduce this behavior, although it could be caused by #5647. When you say that “AdAway remains”, do you mean that you see it there after a page refresh, or does it not disappear at all?

It does not disappear at all, after pressing the delete button the blocklist remains on the web interface. I can however removed the blocklist after I enable the list first and then remove it, so in a disabled state I cannot remove it. Also this is in a fresh install, not an existing one.

[ainar-g]

I have recently been able to reproduce this. The log:

2023/06/21 15:43:24.754135 [error] deleting filter 2: renaming file "/tmp/AdGuardHome/data/filters/2.txt": rename /tmp/AdGuardHome/data/filters/2.txt /tmp/AdGuardHome/data/filters/2.txt.old: no such file or directory

@Mizzick, seems like an issue in internal/filtering/http.go, with os.ErrNotExist not being properly handled.

[Mizzick]

Please have a look, the requested changes have been implemented.
The new build version=v0.108.0-a.578+66345e85 has been just published to the edge channel.

[ainar-g]

We'll close this issue for now. Please feel free to tell us if the issue isn't fixed for you.