Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Checkmarks/Tick-marks + Dark Login screen for Dark Mode theme #5515

Closed
3 tasks done
ghost opened this issue Feb 19, 2023 · 2 comments
Closed
3 tasks done

Better Checkmarks/Tick-marks + Dark Login screen for Dark Mode theme #5515

ghost opened this issue Feb 19, 2023 · 2 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Feb 19, 2023

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

Description

This is just a cosmetic-related issue. When Dark Mode/Theme is applied, the login screen continues to use Light Mode/Theme and I think it should be darkened.

The checkmarks/tick-marks in boxes are hard to see when Dark Mode/Theme is enabled. They should be made darker (black or dark grey, but not light grey) to make them easier to see. They can also be made blue (like the blue dots marks).

@ainar-g ainar-g added the UI label Feb 20, 2023
@ainar-g ainar-g added this to the v0.107.25 milestone Feb 20, 2023
@ainar-g
Copy link
Contributor

ainar-g commented Feb 22, 2023

@GY8VSdYYzvL8-K6T, the most recent update on the Edge channel fixes a few issues with the dark theme, including checkboxes for most browsers. Can you please check?

When Dark Mode/Theme is applied, the login screen continues to use Light Mode/Theme and I think it should be darkened.

It actually uses automatic theme detection, so if your OS and browser both send a theme preference for dark theme, it should use it as well.

@ainar-g
Copy link
Contributor

ainar-g commented Feb 28, 2023

We'll close this issue for now. Feel free to file new ones if you find anything wrong with the dark theme or anything else.

@ainar-g ainar-g closed this as completed Feb 28, 2023
@ainar-g ainar-g modified the milestones: v0.107.27, v0.107.26 Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants