Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows binaries #375

Closed
AnthonyBe opened this issue Oct 17, 2018 · 21 comments
Closed

Windows binaries #375

AnthonyBe opened this issue Oct 17, 2018 · 21 comments

Comments

@AnthonyBe
Copy link

Given you have MacOS binaries, any chance of Windows binaries as I would like to run this on a Windows server.

@ameshkov
Copy link
Member

It can be compiled for Windows, but it does not work at the moment, we didn't have enough time to figure the exact reason. We will, though:)

@hmage
Copy link
Contributor

hmage commented Oct 17, 2018

Hi.

As of now, we can't support Windows because the DNS server library we're using has an outstanding bug -- coredns/coredns#2002.

I'm not saying it will never happen, and there's a possibility we will switch from coredns to another solution if neccessary.

@ameshkov
Copy link
Member

ameshkov commented Oct 17, 2018

Lol, apparently, Eugene had enough time :)

Actually, there're a lot of people demanding windows build so we might need to figure a workaround and not wait for it to be fixed in coreDNS.

@Daist
Copy link

Daist commented Oct 17, 2018

Hi, have you tried running this software in WSL (Windows Subsystem for Linux)?

@hmage
Copy link
Contributor

hmage commented Oct 17, 2018

@Daist not yet, but it could work there, yes.

@TPS
Copy link
Contributor

TPS commented Oct 17, 2018

If possible, if y'all could test WSL & give us modified instructions via a wiki page, that would answer for techies when in v0.9, while y'all work on a shiny v1.0 native Windows edition.

@hmage
Copy link
Contributor

hmage commented Oct 17, 2018

@TPS Thanks for understanding.

Once I get ahold of windows machine I’ll do test it under WSL.

@TPS
Copy link
Contributor

TPS commented Oct 17, 2018

NP, but my Disqus post on the AGHome announcement asks for a lot more! 😚

@hmage
Copy link
Contributor

hmage commented Oct 17, 2018

It does work under WSL.

🎉

capture

@AnthonyBe
Copy link
Author

One major downside with relying on WSL is that it is only included in Windows 10 and Windows Server Insider Preview Build (aka. Windows 2019) so that heavily restricts where it could be used.

Reference: https://docs.microsoft.com/en-au/windows/wsl/about

It would be much better (obviously) if it could run natively on any currently supported version of Windows client or server OS. I do appreciate the blocker at the moment (if I'm not mistaken) is in the Go dependency which takes control of this problem out of your hands to a large degree.

@TPS
Copy link
Contributor

TPS commented Oct 18, 2018

@AnthonyBe Of course, you're right, but this is just meant to be a quick-&-dirty hack so enthusiasts can try it out on Windows. I'm reasonably sure @AdguardTeam is reserving v1.0 for an official native Windows release.

@hmage Any wiki so we don't have to go through (what looks to be, based on posts' time-difference) ~2 hours of trial-&-error?

@AnthonyBe
Copy link
Author

Agreed! I have a Win10 box on permanently I'd love to try this out on 😁 Given I have over 40 devices on my network I'm very interested to see what AGH can pick up!

@ewrogers
Copy link
Contributor

ewrogers commented Oct 18, 2018

If you want something working today on v0.9, use Docker:

  • Windows 10 x64 Pro/Enterprise/Education users can simply Install Docker for Windows. This can run containers natively using Hyper-V.

  • Legacy Windows users can install Docker Toolbox. This will use the docker-machine VM behind the scenes to run your containers.

  • Alternatively, use VirtualBox with your choice of Linux distro (Ubuntu would be friendly for most).

  • For older Windows XP/7/8 machines, consider Ubuntu Wubi which allows installation side-by-side with Windows (and can be uninstalled easily).

My AdGuard Docker images can be found here:

If running on your own computer (not a dedicated device), you may want to use -p 3000:3000 instead when running the container.

@hmage
Copy link
Contributor

hmage commented Oct 18, 2018

Under WSL it also works today.

@TPS
Copy link
Contributor

TPS commented Oct 19, 2018

@hmage Did you get to post a wiki w/ your steps to install/run AdGuardHome via WSL?

@AnthonyBe
Copy link
Author

@hmage Which Linux distro did you use in WSL?

This was referenced Nov 1, 2018
@ilgrank
Copy link

ilgrank commented Nov 30, 2018

...still hoping for an update :) 👍

@AnthonyBe
Copy link
Author

me too! :)

While I do have it running on my Win10 PC using WSL, I'm finding that the average processing time is consistently >140ms and I'm definitely noticing the impact on general web page opens/loads. Given my PC hardware is Core i7, 16GB RAM, etc. and not under any load, I can only assume there is an overhead in the WSL layer so having native Windows binaries (and ideally x64 binaries) will, I hope, improve performance significantly.

@ameshkov ameshkov added this to the v0.92 milestone Dec 3, 2018
@ameshkov
Copy link
Member

ameshkov commented Dec 3, 2018

It seems that we'll be able to do it in v0.92 btw.

I'm finding that the average processing time is consistently >140ms

It's possible that the upstream is too slow.

@AnthonyBe
Copy link
Author

That's wonderful news!

@ameshkov
Copy link
Member

Resolved in the master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants