Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend rules support for TLD and SLD #1733

Open
Aikatsui opened this issue May 25, 2020 · 10 comments
Open

Extend rules support for TLD and SLD #1733

Aikatsui opened this issue May 25, 2020 · 10 comments
Assignees
Milestone

Comments

@Aikatsui
Copy link
Contributor

No description provided.

@ameshkov
Copy link
Member

What's SLD?

@ameshkov ameshkov self-assigned this May 26, 2020
@ameshkov ameshkov added this to the v0.103 milestone May 26, 2020
@Aikatsui
Copy link
Contributor Author

Aikatsui commented May 26, 2020

Second-level domain. (SLD or 2LD)

@ameshkov
Copy link
Member

Hm, I can't see where one would block example.SLD and not example.TLD

@Aikatsui
Copy link
Contributor Author

I only mentioned about it to avoid forget but you can implement it in your own way 😊

@ameshkov
Copy link
Member

I am inclined to implement just the TLD and do it in the following way:

If a domain name ends with .TLD (in the upper case) then it means that all registered domains matching the rule must be blocked

Example: ||example.TLD^ will block example.com, example.com.br, etc

@Aikatsui
Copy link
Contributor Author

Aikatsui commented May 27, 2020

However only update wiki about this new rule because only suitable to silence large enterprises

@DandelionSprout
Copy link
Member

DandelionSprout commented May 30, 2020

Blocking entire TLDs can already be done very easily with ||tk^ and ||co.uk^

I am however not aware of a currently existing way to block second-level domains in any adblocker tool.

@ameshkov
Copy link
Member

ameshkov commented Jun 1, 2020

Blocking entire TLDs can already be done very easily with ||tk^ and ||co.uk^

I guess we're talking about rules like this:
||example.TLD

@ameshkov ameshkov modified the milestones: v0.103, v0.104 Jun 22, 2020
@Aikatsui
Copy link
Contributor Author

Aikatsui commented Jul 6, 2020

Merge #2046

@ameshkov ameshkov modified the milestones: v0.104, v0.108 Aug 28, 2020
@ameshkov
Copy link
Member

I've tried quickly implementing it, but it appeared to be not as easy as I thought at first.

Implementing it properly so that it didn't hurt performance would take more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants