-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new rule to blacklist rules #214
Comments
FWIW a similar case in EL: |
There are two options here:
|
This will be preferred. My idea is that like |
@Yuki2718 i mean, we can add both) We can specify the config like this ( root: true
extends:
- aglint:recommended
syntax:
- AdGuard
rules:
no-excluded-rules:
# exclude all rules that match at least one pattern from here
exclude-patterns:
- /regex/
# exclude all rules listed here (character correct match)
exclude-rules:
- '||example.com/donotblock.css'
- '/donotblock.js' btw, we can extend this with |
There have been cases a problematic rule was removed and then readded, causing the trouble again. A recent example is AdguardTeam/AdguardFilters@dea5d96 but there were many more. I knew the rule would be readded, hence left a comment but it didn't prevent. While other repos such as EL also suffer this sort of issue, it tends to happen on AG more as the number of people working is the largest with some members not being aware of removel of the problematic rule. Adding a blacklist to check before commit will mitigate the problem, e.g. register
staff-start.com/js/track/
and any rule includingstaff-start.com/js/track/
will be warned.The text was updated successfully, but these errors were encountered: