-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass the tests in both Day and Night mode #358
Comments
You mean adding a |
Also, we can create a rule to pass tests in both modes, day and night, but as an independent rule |
Ammmm I think that by default it should try both if the device offers the dark mode. But it should be easy to disable, in case the developer thinks it's not needed, either because the app code doesn't change between day and night or because it slows the tests too much. |
Done in #359 |
I would not enable it by default because it can break things. For example, if the user depends on Orchestrator to clear the app data between tests. You need to know what you're doing. |
Sometimes, when you develop the Night Mode you put there some
if
clauses.It would be great that Barista passes the tests in both Day and Night mode, magically, just to try all the paths the code has.
The text was updated successfully, but these errors were encountered: