Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertDisplayed with resource and string not check visibility #294

Closed
josinaldobarbosa opened this issue Apr 18, 2019 · 9 comments
Closed

Comments

@josinaldobarbosa
Copy link

Please consider making a Pull Request if you are capable of doing so.

Library Version:

2.10.0

Describe the Bug:

assertDisplayed(@idres viewId: Int, text: String) not verify if the view is visible

@josinaldobarbosa josinaldobarbosa changed the title assertDisplayed resource and string not check visibility assertDisplayed with resource and string not check visibility Apr 18, 2019
@josinaldobarbosa
Copy link
Author

I do not know if it is the same case, but there are others with the same behavior, for example: assertHasBackground

@rocboronat
Copy link
Member

Hello @josinaldobarbosa! I don't understand the issue. What is what you expect that is not happening? Thank you! :·)

@josinaldobarbosa
Copy link
Author

@rocboronat my bad, if the view of the parameter has visibility gone/invisibility, the test should fail

@Sloy Sloy closed this as completed May 17, 2019
@josinaldobarbosa
Copy link
Author

@Sloy Has this been fixed?

@Sloy Sloy reopened this May 17, 2019
@Sloy
Copy link
Member

Sloy commented May 17, 2019

Woops sorry @josinaldobarbosa, I misread you.
Would you be able to submit a test case reproducing the issue? So we're sure we understand what's the error you're describing and fix it.

@josinaldobarbosa
Copy link
Author

Sorry for the delay, but to test it is simply to put the view with invisible that the test will pass.

<TextView
        android:text="Hello World!"
        android:id="@+id/my_textview"
        android:visibility="gone"/>

assertDisplayed(R.id.my_textview, "Hello World!")

@nickmi11er
Copy link
Contributor

@Sloy @rocboronat Is there any plans to fix this issue?

@rocboronat
Copy link
Member

@nickmi11er I've just seen your PR! Thanks for it! Let's move on there 😄

@Sloy
Copy link
Member

Sloy commented Aug 19, 2020

Fixed by #316

Thanks a lot for the report! And sorry for not responding sooner 🙏

@Sloy Sloy closed this as completed Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants