Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tot_tours Hidden in Non-Mandatory Tour Frequency Code #656

Closed
dhensle opened this issue Mar 9, 2023 · 1 comment
Closed

tot_tours Hidden in Non-Mandatory Tour Frequency Code #656

dhensle opened this issue Mar 9, 2023 · 1 comment
Labels
First Contribution These are good first issues for people wanting to dive into the ASIM software. Usability Changes that improve usability

Comments

@dhensle
Copy link
Contributor

dhensle commented Mar 9, 2023

A variable named tot_tours is hard-coded in the non-mandatory tour frequency model: https://github.com/ActivitySim/activitysim/blob/main/activitysim/abm/models/non_mandatory_tour_frequency.py#L159.
This should really be exposed to the user and listed in the alternatives file instead.

@dhensle dhensle added Usability Changes that improve usability First Contribution These are good first issues for people wanting to dive into the ASIM software. labels Mar 9, 2023
@JoeJimFlood
Copy link
Contributor

@dhensle Is what I did in #661 along the lines with what you were thinking? I am wondering if we should add a check that the total tours is actually the total number of nonmandatory tours for each alternative and raise an AssertionError if that's the case.

@dhensle dhensle closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First Contribution These are good first issues for people wanting to dive into the ASIM software. Usability Changes that improve usability
Projects
None yet
Development

No branches or pull requests

2 participants