Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapper for /partidos #7

Closed
kimuraz opened this issue Sep 30, 2020 · 6 comments · Fixed by #45
Closed

Add wrapper for /partidos #7

kimuraz opened this issue Sep 30, 2020 · 6 comments · Fixed by #45
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest 🍺 help wanted Extra attention is needed

Comments

@kimuraz
Copy link
Member

kimuraz commented Sep 30, 2020

🇧🇷 Adicionar wrapper para o endpoint /partidos

Problem / Problema

🇬🇧 The SDK doesn't support /partidos endpoint

🇧🇷 O sdk ainda não possui suporte para o endpoint de partidos /partidos.

Solution / Solução

🇬🇧 Add the methods respecting the patterns, validations and available options for each endpoint:

🇧🇷 Adicione os métodos respeitando os padrões, validações e opções disponíveis para cada endpoint:

  • getPartidos - endpoint: /partidos
  • getPartido - endpoint: /partidos/{id}
  • getPartidoMembros - endpoint /partidos/{id}/membros
@kimuraz kimuraz added good first issue Good for newcomers help wanted Extra attention is needed feature Hacktoberfest 🍺 enhancement New feature or request and removed feature labels Sep 30, 2020
@rguzg
Copy link

rguzg commented Oct 1, 2020

Hey, can I work on this issue?

@kimuraz
Copy link
Member Author

kimuraz commented Oct 1, 2020

@rguzg Sure! Let us know if you need any further info!

@rguzg
Copy link

rguzg commented Oct 1, 2020

Is there a reason why the imports don't have the .js extension? Because I couldn't get sample.js to work unless I added the extension to the imports

@kimuraz
Copy link
Member Author

kimuraz commented Oct 2, 2020

@rguzg Yeah, primarily the .js extension should only be mandatory if you're not in the browser (sample.js runs through parcel on an HTML file. Check:

I need to highlight that the project is still a WIP and that the sample.js and the HTML file running it is not even close to the ideal, it was something I've made just to be sure that the data was being requested.

A next step, to fully support node, would be using a bundler properly configured. Sorry about that, but currently I think you won't be able to run the file directly using node... Maybe we can address your comment on a new issue to move forward and make improvements on these matters.

@rguzg
Copy link

rguzg commented Oct 2, 2020

Yeah, it may be a good idea to also support node. For now, I left the imports as they were before I forked the repository

@kimuraz
Copy link
Member Author

kimuraz commented Oct 2, 2020

Thanks for bring this up, I'll open an issue about it soon.

@kimuraz kimuraz linked a pull request Oct 3, 2020 that will close this issue
@kimuraz kimuraz mentioned this issue Oct 16, 2021
@kimuraz kimuraz closed this as completed Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest 🍺 help wanted Extra attention is needed
Projects
None yet
2 participants