fix!: Rename accesskit_winit::Adapter::on_event
to process_event
#307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #300
The name
on_event
suggests that this function won't have side effects, which is not the case.We received strong push-back from developers who don't want AccessKit to filter events. We previously agreed on keeping the mechanism around even though we didn't use it for keyboard events on Unix. Even though we might need it in the future for other features, this is not currently the case, therefore it is hard to convince people to use it. I propose to remove it for now.