Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review usage of process.env #690

Closed
xlc opened this issue Mar 12, 2024 · 0 comments · Fixed by #715
Closed

review usage of process.env #690

xlc opened this issue Mar 12, 2024 · 0 comments · Fixed by #715

Comments

@xlc
Copy link
Member

xlc commented Mar 12, 2024

We should avoid using process.env in core package, and only use it in the cli. There should be a single file contains all the available envs and we need to document them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant