Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new reanchor compatible change #1762

Closed
zqhxuyuan opened this issue Jan 10, 2022 · 1 comment · Fixed by #1765
Closed

new reanchor compatible change #1762

zqhxuyuan opened this issue Jan 10, 2022 · 1 comment · Fixed by #1765

Comments

@zqhxuyuan
Copy link
Contributor

relates to: paritytech/polkadot#4470

orml: open-web3-stack/open-runtime-module-library#672

@zqhxuyuan
Copy link
Contributor Author

zqhxuyuan commented Jan 29, 2022

change CurrencyIdConvert to support canonical reanchor. we only need adapt to-reserve and non-reserve cases. make karura and bifrost as example.

  • Karura -> [BNC] -> Bifrost. From Bifrost's point of view, the reanchored location change from (1, Parachain(2001), GeneralKey("BNC")) now to (0, GeneralKey("BNC")). so Bifrost make sure compatibility before Karura upgrade.
  • Karura -> [KAR] -> Bifrost. no change, From Bifrost's point of view, the reanchored location keep (1, Parachain(2000), GeneralKey("KAR")).
  • Bifrost -> [BNC] -> Karura. no change, From Karura's point of view, the reanchored location keep (1, Parachain(2001), GeneralKey("BNC")).
  • Bifrost -> [KAR] -> Karura. From Karura's point of view, the reanchored location change from (1, Parachain(2000), GeneralKey("KAR")) now to (0, GeneralKey("KAR")). so Karura make sure compatibility before Bifrost upgrade.
  • Karura <-> [KSM] <-> Bifrost. no change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant