Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Checklist: 1.1.3 #1201

Closed
8 of 33 tasks
xlc opened this issue Jul 13, 2021 · 1 comment
Closed
8 of 33 tasks

Release Checklist: 1.1.3 #1201

xlc opened this issue Jul 13, 2021 · 1 comment
Assignees
@qwer951123 @ntduan @shaunxw @wangjj9219
Labels
a-release

Comments

@xlc
Copy link
Member

xlc commented Jul 13, 2021 •
edited
Loading

New Release Details:

Summary generated with srtool v0.9.15 using the docker image chevdor/srtool:1.53.0:
 Package     : karura-runtime v1.1.3
 GIT commit  : 5c06366dc6413089cacf10cdf9deb9a4601a88be
 GIT tag     : 1.1.2
 GIT branch  : release-karura-1.1.3
 Rustc       : rustc 1.53.0 (53cb7b09b 2021-06-17)
 Time        : 2021-07-14T03:55:52Z

== Compact
 Version     : karura-1004 (karura-0.tx1.au1)
 Metadata    : V13
 Size        : 2.77 MB (2900085 bytes)
 Proposal    : 0xa01b9773813e9bb558756ee66ad45abafa9e17951c2b6e1ba4a1a5d15738c0fb
 IPFS        : QmNyj8zkJoM1d2thDzAj8aWT9heDQmsdPiKe8HAAd5AvBX
 BLAKE2_256  : 0xca7544f3f9f2bfb4858bd8b5a323428a18e879fda9ceb209804228696e906f8b
 Wasm        : runtime/karura/target/srtool/release/wbuild/karura-runtime/karura_runtime.compact.wasm

== Compressed
 Version     : karura-1004 (karura-0.tx1.au1)
 Metadata    : V13
 Size        : 770.81 KB (789307 bytes)
 Compression : 72.79%
 Proposal    : 0xa01b9773813e9bb558756ee66ad45abafa9e17951c2b6e1ba4a1a5d15738c0fb
 IPFS        : QmTrUJragkgGrp3eNyun7n7p5zT8MFLE3s87o3ZJSyj4wf
 BLAKE2_256  : 0xca7544f3f9f2bfb4858bd8b5a323428a18e879fda9ceb209804228696e906f8b
 Wasm        : runtime/karura/target/srtool/release/wbuild/karura-runtime/karura_runtime.compact.compressed.wasm
  • subwasm info
🏋️  Runtime size:	2.766 MB (2,900,085 bytes)
🗜  Compressed:		Yes, 72.78%
✨ Reserved meta:	OK - [6D, 65, 74, 61]
🎁 Metadata version:	V13
🔥 Core version:	karura-1004 (karura-0.tx1.au1)
🗳️  Proposal hash:	0xa01b9773813e9bb558756ee66ad45abafa9e17951c2b6e1ba4a1a5d15738c0fb
#️⃣  Blake2-256 hash:	0xca7544f3f9f2bfb4858bd8b5a323428a18e879fda9ceb209804228696e906f8b
📦 IPFS hash:		QmTrUJragkgGrp3eNyun7n7p5zT8MFLE3s87o3ZJSyj4wf (https://www.ipfs.io/ipfs/QmTrUJragkgGrp3eNyun7n7p5zT8MFLE3s87o3ZJSyj4wf)

Runtime Release

  • Verify spec_version has been incremented since the last release.
    • Current version: 1004
    • Last version: 1003
  • Verify completed migrations are removed from any public networks.
  • Review subwasm diff
    • subwasm diff karura_runtime.compact.compressed.wasm wss://karura-rpc-2.aca-api.network/ws
  • Verify extrinsic ordering has stayed the same. Bump transaction_version if not.
    • ORML
    • Substrate
    • Cumulus
    • Acala
  • Verify new extrinsics have been correctly whitelisted/blacklisted for proxy filters.
  • Verify benchmarks & weights have been updated for any modified runtime logics.
  • Verify we included all the necessary migrations.
    • ORML
    • Substrate
    • Cumulus
    • Acala
  • Verify new migrations complete successfully and the runtime state is correctly updated for any public networks.
    • Verify the execution time to perform runtime upgrade with Karura/Acala onchain data.
  • Ensure WASM is reproducible
    • make srtool-build-wasm-karura

All Releases

  • Check new Github release is created with release logs.

Post Release

  • Notify Discord announcement channel.
  • Ensure our own nodes are updated
  • Update wiki

Compatibility Checklist

SDK & Tools

  • acala.js
  • txwrapper
  • sidecar
  • acala-subql
  • oracle dispatcher

dApps & Wallets

  • polkadot apps
  • Acala dApp
  • Polkawallet

Other

  • Exchanges
  • Gauntlet
  • Faucet (for Mandala)
@xlc xlc added the a-release label Jul 13, 2021
@xlc
Copy link
Member Author

xlc commented Jul 14, 2021 

$ subwasm diff wss://karura-rpc-2.aca-api.network/ws karura-1004.wasm
Running subwasm v0.12.0
  🅰️  Chain(OnchainBlock { endpoint: WebSocket("wss://karura-rpc-2.aca-api.network/ws"), block_ref: None })
  🅱️  File("karura-1004.wasm")
  🅰️  2.754 MB (2,887,359 bytes)
  🅱️  2.766 MB (2,900,085 bytes)
Checking metadata versions:
  ✅ Both metadata versions are identical: V13
Checking core versions:
  ❌ The 2 core versions are different:
  🅰️  karura-1003 (karura-0.tx1.au1)
  🅱️  karura-1004 (karura-0.tx1.au1)
Checking runtime metadata:
  ❌  The metadata are different
Comparing V13 with V13
🛠  modules.0.constants.4.value.                       "186B6172757261186B617275726101000000EB0300000000000034DF6ACB689907609B0300000037E397FC7C91F5E40100000040FE3AD401F8959A05000000D2BC9897EED08F1502000000F78B278BE53F454C02000000DD718D5CC53262D401000000AB3C0572291FEB8B01000000BC9D89904F5B923F0100000037C8BB1350A9A2A8010000006EF953004BA30E5901000000F485C9145D3F0AAD01000000E3DF3F2AA8A5CC5701000000EA93E3F16F3D69620100000001000000" --> "186B6172757261186B617275726101000000EC0300000000000034DF6ACB689907609B0300000037E397FC7C91F5E40100000040FE3AD401F8959A05000000D2BC9897EED08F1502000000F78B278BE53F454C02000000DD718D5CC53262D401000000AB3C0572291FEB8B01000000BC9D89904F5B923F0100000037C8BB1350A9A2A8010000006EF953004BA30E5901000000F485C9145D3F0AAD01000000E3DF3F2AA8A5CC5701000000EA93E3F16F3D69620100000001000000"
🛠  modules.8.event.0.arguments.0.                        "CurrencyIdOf<T>" --> "CurrencyId"
🛠  modules.8.event.0.arguments.1.                           "T::AccountId" --> "AccountId"
🛠  modules.8.event.0.arguments.2.                           "T::AccountId" --> "AccountId"
🛠  modules.8.event.0.arguments.3.                           "BalanceOf<T>" --> "Balance"
🛠  modules.8.event.1.arguments.0.                        "CurrencyIdOf<T>" --> "CurrencyId"
🛠  modules.8.event.1.arguments.1.                           "T::AccountId" --> "AccountId"
🛠  modules.8.event.2.arguments.0.                        "CurrencyIdOf<T>" --> "CurrencyId"
🛠  modules.8.event.2.arguments.1.                           "T::AccountId" --> "AccountId"
🛠  modules.8.event.2.arguments.2.                           "BalanceOf<T>" --> "Balance"
🛠  modules.8.event.3.arguments.0.                        "CurrencyIdOf<T>" --> "CurrencyId"
🛠  modules.8.event.3.arguments.1.                           "T::AccountId" --> "AccountId"
🛠  modules.8.event.3.arguments.2.                           "BalanceOf<T>" --> "Balance"
🛠  modules.17.event.0.arguments.0.                     "Vec<T::AccountId>" --> "Vec<AccountId>"
🛠  modules.43.event.0.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.43.event.1.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.43.event.2.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.43.event.3.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.44.event.2.arguments.3.                          "T::AccountId" --> "AccountId"
🛠  modules.45.event.0.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.45.event.1.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.45.event.2.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.45.event.2.arguments.1.                          "T::AccountId" --> "AccountId"
🛠  modules.46.event.0.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.46.event.0.arguments.1.                          "T::AccountId" --> "AccountId"
🛠  modules.46.event.1.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.46.event.1.arguments.1.                          "T::AccountId" --> "AccountId"
🛠  modules.46.event.2.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.48.event.0.arguments.1.                          "T::AccountId" --> "AccountId"
🛠  modules.48.event.1.arguments.1.                          "T::AccountId" --> "AccountId"
🛠  modules.48.event.2.arguments.1.                          "T::AccountId" --> "AccountId"
🛠  modules.48.event.3.arguments.1.                          "Option<Rate>" --> "OptionRate"
🛠  modules.48.event.4.arguments.1.                         "Option<Ratio>" --> "OptionRatio"
🛠  modules.48.event.5.arguments.1.                          "Option<Rate>" --> "OptionRate"
🛠  modules.48.event.6.arguments.1.                         "Option<Ratio>" --> "OptionRatio"
🛠  modules.49.event.0.arguments.0.                        "T::BlockNumber" --> "BlockNumber"
🛠  modules.49.event.1.arguments.0.                        "T::BlockNumber" --> "BlockNumber"
🛠  modules.49.event.2.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.50.event.0.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.50.event.1.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.50.event.2.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.50.event.2.arguments.1.                    "PoolId<T::RelaychainAccountId>" --> "PoolId"
🛠  modules.50.event.3.arguments.0.                    "PoolId<T::RelaychainAccountId>" --> "PoolId"
🛠  modules.50.event.4.arguments.0.                    "PoolId<T::RelaychainAccountId>" --> "PoolId"
🛠  modules.50.event.5.arguments.0.                    "PoolId<T::RelaychainAccountId>" --> "PoolId"
🛠  modules.51.event.0.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.51.event.0.arguments.1.                          "ClassIdOf<T>" --> "ClassId"
🛠  modules.51.event.1.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.51.event.1.arguments.1.                          "T::AccountId" --> "AccountId"
🛠  modules.51.event.1.arguments.2.                          "ClassIdOf<T>" --> "ClassId"
🛠  modules.51.event.2.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.51.event.2.arguments.1.                          "T::AccountId" --> "AccountId"
🛠  modules.51.event.2.arguments.2.                          "ClassIdOf<T>" --> "ClassId"
🛠  modules.51.event.2.arguments.3.                          "TokenIdOf<T>" --> "TokenId"
🛠  modules.51.event.3.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.51.event.3.arguments.1.                          "ClassIdOf<T>" --> "ClassId"
🛠  modules.51.event.3.arguments.2.                          "TokenIdOf<T>" --> "TokenId"
🛠  modules.51.event.4.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.51.event.4.arguments.1.                          "ClassIdOf<T>" --> "ClassId"
🛠  modules.51.event.4.arguments.2.                          "TokenIdOf<T>" --> "TokenId"
🛠  modules.51.event.4.arguments.3.                               "T::Hash" --> "Hash"
🛠  modules.51.event.5.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.51.event.5.arguments.1.                          "ClassIdOf<T>" --> "ClassId"
🛠  modules.52.event.5.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.52.event.6.arguments.0.                          "T::AccountId" --> "AccountId"
🛠  modules.52.event.13.arguments.0.                         "T::AccountId" --> "AccountId"
🛠  modules.52.event.14.arguments.0.                         "T::AccountId" --> "AccountId"
🛠  modules.54.event.0.arguments.0.                          "T::AccountId" --> "AccountId"
Changes:
- unmodified	= 79.90% (322)
- added		=  0.25% (1)
- modified	= 19.85% (80)
- removed	=  0.00% (0)
Skipped:
- documentation	=    12
- bytes		=     0

@xlc xlc closed this as completed Jul 14, 2021
@xlc xlc mentioned this issue Jul 15, 2021
Closed
19 tasks
@xlc xlc added the a-release label Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qwer951123 qwer951123

@ntduan ntduan

@shaunxw shaunxw

@wangjj9219 wangjj9219

Labels
a-release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@xlc @qwer951123 @ntduan @shaunxw @wangjj9219