Shell type plugin can resolve incorrectly in rez.system on Linux.

[cumulus-vfx]

This line in rez.system.System.shell

rez/src/rez/system.py

Line 91 in a13f7bb

shell = os.path.basename(output.strip().split()[0]).replace('-', '')

Will throw a TypeError always as you cant replace with str char's on a byte string

So this function will always fallback to use $SHELL first to wrangle the shell name

This can be inaccurate in a case where the SHELL env var is wrong for the current running parent shell of the rez process
Where as if getting via ps is more reliable.

Environment

• Centos 7
• Rez version 2.112.0
• Rez python version 3.7

Issue still in latest release 3.1.1

[parikshittiwari740]

Hey @JeanChristopheMorinPerso, I have a PR out for this linked to the ticket 😄

Sorry for tagging but I was not sure how/when the review is done and whether I am expected to do something after posting the PR. Please ignore my message if you guys are busy and I simply have to wait. Thanks!