Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster namespaces permission for ohmyglb #77

Merged
merged 1 commit into from
Apr 4, 2020

Conversation

somaritane
Copy link
Contributor

  • Adds permissions to list namespaces for ohmyglb ClusterRole.
    Lack of permissions prevented CR metrics generation for ohmyglb deployment:
    {"level":"info","ts":1585940196.2318976,"logger":"cmd","msg":"Could not generate and serve custom resource metrics","error":"namespaces is forbidden: User \"system:serviceaccount:ohmyglb:ohmyglb\" cannot list resource \"namespaces\" in API group \"\" at the cluster scope"}
    

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@ytsarev ytsarev merged commit e1847f2 into master Apr 4, 2020
@ytsarev ytsarev deleted the namespace-permissions-fix branch April 4, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants