Split brain handling #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Planned to be used for handling split-brain
* Use TXT as 'heartbeat' for spefic gslb deployment * Use UTC timestamp with second level precision * Switch to automatically generated geo tag based fqdns * Eventually we will detect 'stale' gslb deployments by an outdated timestamp * The timestamp is about to handle situation of split brain between multiple gslb deployments in case of network partition between them but not between gslb and edgeDNS
|
@donovanmuller it's not completed implementation. Before proceeding further I would like to validate the design. |
|
@ytsarev 👍let's discuss and walk through the permutations. |
* Inline typo fix - was harmless before due to standard port fallback
| {Address: "10.0.0.1", Name: "test-gslb-ns-eu.example.com"}, | ||
| {Address: "10.0.0.2", Name: "test-gslb-ns-eu.example.com"}, | ||
| {Address: "10.0.0.3", Name: "test-gslb-ns-eu.example.com"}, | ||
| {Address: "10.1.0.1", Name: "test-gslb-ns-sa.example.com"}, |
There was a problem hiding this comment.
County code for South Africa is za 😀
donovanmuller
approved these changes
Feb 27, 2020
* Test logic injection * Stripped implementation for fakeInfoblox connector from https://github.com/infobloxopen/infoblox-go-client/blob/master/object_manager_test.go * Why we need to implement fakeConnector on our own? - infoblox-go-client package does not export fakeConnector - even if we export it with mass rename to FakeConnector object_manager_test.go will not be installed by `go mod` golang/go#26913 - moving into main ibclient package file does not seem to be good idea as it is purely testing code with dependenies like gingko/omega - also upstream will probably never accept it
* Temporary comment out yet unused fields of the fake Infoblox connector to obey the lint Switch github actions pipeline back to upstream As shoukoo/golang-pipeline#5 was merged
* fakedns can serve TXT with 10m old timestamp withing * associated test suite extensions
|
@donovanmuller commits are squashed to more or less important semantic sets. Btw that's how relevant part of test suite execution looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outdated timestamp
between multiple gslb deployments in case of network partition
between them but not between gslb and edgeDNS