Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with eslint - tsc #222

Closed
hichemBAALI opened this issue Jun 7, 2022 · 4 comments
Closed

Issue with eslint - tsc #222

hichemBAALI opened this issue Jun 7, 2022 · 4 comments

Comments

@hichemBAALI
Copy link

Hi,
There are some errors that you are ignored which appears when someone is using ts in strict mode. Please, could you just take a look on that.

here an example of what I am getting

node_modules/react-native-gifted-charts/src/LineChart/index.tsx:3360:21 - error TS6133: 'item' is declared but its value is never read.

3360           data.map((item: itemType, index: number) => {
                         ~~~~

@Abhinandan-Kushwaha
Copy link
Owner

Hi @hichemBAALI 👋
The issue is fixed in version 1.2.33🎉

@hichemBAALI
Copy link
Author

Hi @hichemBAALI 👋 The issue is fixed in version 1.2.33🎉

Hi again, I forgot to thank you about this library it helped a lot.
Unfortunately, the problem still persisting. If you're using Typescript, please try to run yarn tsc -noEmit to see what is the problem

` The expected type comes from property 'gradientCenterColor' which is declared here on type 'itemType'

node_modules/react-native-gifted-charts/src/PieChart/main.tsx:12:22 - error TS7016: Could not find a declaration file for module './colors'. '/Users/mac/Work/Tulix-Tech/Tulix-App/mobile-app-v2/node_modules/react-native-gifted-charts/src/PieChart/colors.js' implicitly has an 'any' type.

12 import {colors} from './colors';
~~~~~~~~~~

node_modules/react-native-gifted-charts/src/PieChart/main.tsx:84:9 - error TS7034: Variable 'data' implicitly has type 'any[]' in some locations where its type cannot be determined.

84 const data = [];
~~~~

node_modules/react-native-gifted-charts/src/PieChart/main.tsx:254:17 - error TS7005: Variable 'data' implicitly has an 'any[]' type.

254 data[0].onPress
~~~~`

@Abhinandan-Kushwaha
Copy link
Owner

Hi @hichemBAALI
Glad to know that you liked the library.
I will fix the type issues in a few days, running short of time currently.

@kale1d
Copy link

kale1d commented Jul 30, 2022

is there any workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants