From ca5903bcae475f738a49d3ccaa53de3059da431c Mon Sep 17 00:00:00 2001
From: Lucas Trzesniewski <lucas.trzesniewski@gmail.com>
Date: Sun, 17 Nov 2024 18:07:51 +0100
Subject: [PATCH] Use some net9.0 features

---
 src/ZeroLog.Impl.Base/LogManager.cs            |  3 +++
 src/ZeroLog.Impl.Full/BufferSegmentProvider.cs |  6 +++++-
 src/ZeroLog.Impl.Full/Runner.cs                |  6 +++++-
 src/ZeroLog.Impl.Full/UnmanagedCache.cs        | 10 ++++++++--
 src/ZeroLog.Tests/PerformanceTests.cs          |  2 +-
 src/ZeroLog.Tests/Support/AssertExtensions.cs  |  3 +++
 6 files changed, 25 insertions(+), 5 deletions(-)

diff --git a/src/ZeroLog.Impl.Base/LogManager.cs b/src/ZeroLog.Impl.Base/LogManager.cs
index 4f8aa28d..39779227 100644
--- a/src/ZeroLog.Impl.Base/LogManager.cs
+++ b/src/ZeroLog.Impl.Base/LogManager.cs
@@ -20,6 +20,9 @@ public sealed partial class LogManager
     /// </remarks>
     /// <typeparam name="T">The type.</typeparam>
     public static Log GetLogger<T>()
+#if NET9_0_OR_GREATER
+        where T : allows ref struct
+#endif
         => GetLogger(typeof(T));
 
     /// <summary>
diff --git a/src/ZeroLog.Impl.Full/BufferSegmentProvider.cs b/src/ZeroLog.Impl.Full/BufferSegmentProvider.cs
index cb4b000c..ffb19dce 100644
--- a/src/ZeroLog.Impl.Full/BufferSegmentProvider.cs
+++ b/src/ZeroLog.Impl.Full/BufferSegmentProvider.cs
@@ -4,7 +4,11 @@ namespace ZeroLog;
 
 internal unsafe class BufferSegmentProvider
 {
-    private readonly object _lock = new();
+#if NET9_0_OR_GREATER
+    private static readonly System.Threading.Lock _lock = new();
+#else
+    private static readonly object _lock = new();
+#endif
 
     private readonly int _segmentCount;
     private readonly int _segmentSize;
diff --git a/src/ZeroLog.Impl.Full/Runner.cs b/src/ZeroLog.Impl.Full/Runner.cs
index 42d14730..754ae969 100644
--- a/src/ZeroLog.Impl.Full/Runner.cs
+++ b/src/ZeroLog.Impl.Full/Runner.cs
@@ -310,7 +310,11 @@ public override void Flush()
 
 internal sealed class SyncRunner(ZeroLogConfiguration config) : Runner(config)
 {
-    private readonly object _lock = new();
+#if NET9_0_OR_GREATER
+    private static readonly Lock _lock = new();
+#else
+    private static readonly object _lock = new();
+#endif
 
     public override void Submit(LogMessage message)
     {
diff --git a/src/ZeroLog.Impl.Full/UnmanagedCache.cs b/src/ZeroLog.Impl.Full/UnmanagedCache.cs
index a1bfab32..9a73f407 100644
--- a/src/ZeroLog.Impl.Full/UnmanagedCache.cs
+++ b/src/ZeroLog.Impl.Full/UnmanagedCache.cs
@@ -31,6 +31,12 @@ internal delegate bool FormatterDelegate(
         ZeroLogConfiguration config
     );
 
+#if NET9_0_OR_GREATER
+    private static readonly System.Threading.Lock _lock = new();
+#else
+    private static readonly object _lock = new();
+#endif
+
     private static readonly Dictionary<IntPtr, FormatterDelegate> _unmanagedStructs = new();
     private static readonly MethodInfo _registerMethod = typeof(UnmanagedCache).GetMethod(nameof(Register), Type.EmptyTypes)!;
 
@@ -52,7 +58,7 @@ public static void Register<T>(UnmanagedFormatterDelegate<T> formatter)
     {
         ArgumentNullException.ThrowIfNull(formatter);
 
-        lock (_unmanagedStructs)
+        lock (_lock)
         {
             _unmanagedStructs[typeof(T).TypeHandle.Value] = (byte* valuePtr, Span<char> destination, out int charsWritten, ReadOnlySpan<char> format, ZeroLogConfiguration _)
                 => FormatterGeneric(valuePtr, destination, out charsWritten, format, formatter);
@@ -109,7 +115,7 @@ private static bool FormatterGenericNullable<T>(byte* valuePtr,
     public static bool TryGetFormatter(IntPtr typeHandle, out FormatterDelegate formatter)
     {
         // This is accessed from a single thread, there should be no contention
-        lock (_unmanagedStructs)
+        lock (_lock)
         {
             return _unmanagedStructs.TryGetValue(typeHandle, out formatter!);
         }
diff --git a/src/ZeroLog.Tests/PerformanceTests.cs b/src/ZeroLog.Tests/PerformanceTests.cs
index 59ecf01d..9c60de9c 100644
--- a/src/ZeroLog.Tests/PerformanceTests.cs
+++ b/src/ZeroLog.Tests/PerformanceTests.cs
@@ -55,7 +55,7 @@ public void should_run_test()
         var signal = _testAppender.SetMessageCountTarget(totalMessageCount);
         var utcNow = DateTime.UtcNow;
 
-        Parallel.For(0, threadCount, i =>
+        Parallel.For(0, threadCount, _ =>
         {
             for (var k = 0; k < threadMessageCount; k++)
             {
diff --git a/src/ZeroLog.Tests/Support/AssertExtensions.cs b/src/ZeroLog.Tests/Support/AssertExtensions.cs
index 5bffecbb..3e8cee46 100644
--- a/src/ZeroLog.Tests/Support/AssertExtensions.cs
+++ b/src/ZeroLog.Tests/Support/AssertExtensions.cs
@@ -7,6 +7,9 @@ namespace ZeroLog.Tests.Support;
 
 #nullable enable
 
+#if NET6_0_OR_GREATER
+[System.Diagnostics.StackTraceHidden]
+#endif
 internal static class AssertExtensions
 {
     public static void ShouldEqual<T>(this T? actual, T? expected)