From 1b1945cc4a6cedd88faa4debadb4eed10ea73872 Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Thu, 11 Jul 2024 12:03:13 -0400
Subject: [PATCH 01/28] Remove test about `tab_row_group() from tab_style() (it
 is duplicated in test-table_parts

---
 tests/testthat/_snaps/tab_style.md | 10 ----------
 tests/testthat/test-tab_style.R    |  7 -------
 2 files changed, 17 deletions(-)

diff --git a/tests/testthat/_snaps/tab_style.md b/tests/testthat/_snaps/tab_style.md
index af44cde65a..ef5c64e0fe 100644
--- a/tests/testthat/_snaps/tab_style.md
+++ b/tests/testthat/_snaps/tab_style.md
@@ -82,16 +82,6 @@
       Caused by error in `cells_body()`:
       ! Row `Mazda RX7` does not exist in the data.
 
-# tab_row_group warns when others_label is not empty
-
-    Code
-      a_gt <- data %>% tab_row_group(others_label = "Others1")
-    Condition
-      Warning:
-      Since gt v0.3.0 the `others_label` argument has been deprecated.
-      * Use `tab_options(row_group.default_label = <label>)` to set this label.
-      This warning is displayed once every 8 hours.
-
 # Using fonts in `from_column()` works within `cell_*()` fns
 
     Code
diff --git a/tests/testthat/test-tab_style.R b/tests/testthat/test-tab_style.R
index d700fdcf16..901bb991cf 100644
--- a/tests/testthat/test-tab_style.R
+++ b/tests/testthat/test-tab_style.R
@@ -437,13 +437,6 @@ test_that("tab_style() works with a single cell", {
 
 })
 
-test_that("tab_row_group warns when others_label is not empty", {
-  # Check that `tab_row_group(others_label = ...)` still works but
-  # issues a warning
-  expect_snapshot(a_gt <- data %>% tab_row_group(others_label = "Others1"))
-
-})
-
 test_that("Using fonts in `cell_text()` works", {
 
   # Prepare a small gt table for all tests

From 9d439c2d8d1f3715a12d3c177513f55a9f90cda9 Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Thu, 11 Jul 2024 12:03:39 -0400
Subject: [PATCH 02/28] Refactor and simplify `tab_style()` tests.

---
 tests/testthat/_snaps/tab_style.md |   2 +-
 tests/testthat/test-tab_style.R    | 119 +++++++++++++----------------
 2 files changed, 55 insertions(+), 66 deletions(-)

diff --git a/tests/testthat/_snaps/tab_style.md b/tests/testthat/_snaps/tab_style.md
index ef5c64e0fe..1d8ce18316 100644
--- a/tests/testthat/_snaps/tab_style.md
+++ b/tests/testthat/_snaps/tab_style.md
@@ -1,4 +1,4 @@
-# tab_style errors if problems occur
+# tab_style() errors if locations can't be resolved
 
     Code
       data %>% tab_style(style = list(cell_fill(color = "green"), cell_text(color = "white")),
diff --git a/tests/testthat/test-tab_style.R b/tests/testthat/test-tab_style.R
index 901bb991cf..0026a99e0d 100644
--- a/tests/testthat/test-tab_style.R
+++ b/tests/testthat/test-tab_style.R
@@ -43,16 +43,8 @@ data <-
       ~sum(., na.rm = TRUE))
   )
 
-# Function to skip tests if Suggested packages not available on system
-check_suggests <- function() {
-  skip_if_not_installed("rvest")
-}
-
 test_that("A gt table can store the correct style statements", {
 
-  # Check that specific suggested packages are available
-  check_suggests()
-
   # Apply a `lightgray` background color to the columns
   # and stub cells
   tbl_html <-
@@ -64,21 +56,21 @@ test_that("A gt table can store the correct style statements", {
         cells_stub(rows = TRUE))
     )
 
+  styles_tbl <- dt_styles_get(data = tbl_html)
   # Expect that the internal `styles_df` data frame will have
   # its `locname` column entirely populated with `cells_column_labels`
   # and `stub`
-  dt_styles_get(data = tbl_html) %>%
-    dplyr::pull(locname) %>%
-    unique() %>%
-    expect_equal(c("columns_columns", "stub"))
+  expect_setequal(styles_tbl$locname, c("columns_columns", "stub"))
 
   # Expect that the internal `styles_df` data frame will have
   # its `cell_fill:color` property entirely populated with `lightgray`
-  dt_styles_get(data = tbl_html) %>%
-    .$styles %>%
-    vapply(function(x) x[1]$cell_fill$color, character(1L)) %>%
-    unique() %>%
-    expect_equal("#D3D3D3")
+  expect_setequal(
+    vapply(styles_tbl$styles, function(x) x[1]$cell_fill$color, character(1L)),
+    "#D3D3D3"
+  )
+})
+
+test_that("tab_style() works for styling a single cell.", {
 
   # Apply a `steelblue` background color with white text to a
   # single stub cell
@@ -91,27 +83,24 @@ test_that("A gt table can store the correct style statements", {
       ),
       locations = cells_stub(rows = "Merc 240D")
     )
+  styles_tbl <- dt_styles_get(data = tbl_html)
 
   # Expect that the internal `styles_df` data frame will have
   # a single row
-  dt_styles_get(data = tbl_html) %>%
-    nrow() %>%
-    expect_equal(1)
+  expect_1_row(styles_tbl)
 
   # Expect certain values for inside the single `styles` list
-  dt_styles_get(data = tbl_html) %>%
-    .$styles %>%
-    .[[1]] %>%
-    .$cell_fill %>%
-    .$color %>%
-    expect_equal("#4682B4")
+  expect_equal(
+    styles_tbl$styles[[1]]$cell_fill$color,
+    "#4682B4"
+  )
+  expect_equal(
+    styles_tbl$styles[[1]]$cell_text$color,
+    "#FFFFFF"
+  )
+})
 
-  dt_styles_get(data = tbl_html) %>%
-    .$styles %>%
-    .[[1]] %>%
-    .$cell_text %>%
-    .$color %>%
-    expect_equal("#FFFFFF")
+test_that("A table subtitle can be left-aligned", {
 
   # Apply left-alignment to the table title
   tbl_html <-
@@ -121,17 +110,18 @@ test_that("A gt table can store the correct style statements", {
       locations = cells_title(groups = "title")
     )
 
+  styles_tbl <- dt_styles_get(data = tbl_html)
   # Expect that the internal `styles_df` data frame will have
   # a single row
-  dt_styles_get(data = tbl_html) %>%
-    nrow() %>%
-    expect_equal(1)
+  expect_1_row(styles_tbl)
 
   # Expect a specific value inside the single `styles` list
-  result <- dt_styles_get(data = tbl_html)$styles[[1]]
+  result <- styles_tbl$styles[[1]]
   expect_equal(result$cell_text$align, "left")
+})
+
+test_that("A table subtitle can be left-aligned", {
 
-  # Apply left-alignment to the table subtitle
   tbl_html <-
     data %>%
     tab_style(
@@ -139,13 +129,16 @@ test_that("A gt table can store the correct style statements", {
       locations = cells_title(groups = "subtitle")
     )
 
+  styles_tbl <- dt_styles_get(data = tbl_html)
   # Expect certain values for inside the single `styles` list
-  dt_styles_get(data = tbl_html) %>%
-    expect_1_row()
+  expect_1_row(styles_tbl)
 
   # Expect a specific value inside the single `styles` list
-  result <- dt_styles_get(data = tbl_html)$styles[[1]]
+  result <- styles_tbl$styles[[1]]
   expect_equal(result$cell_text$align, "left")
+})
+
+test_that("A gt table can have a background in the summary.", {
 
   # Apply a green background with white text to a single cell in
   # a group summary section
@@ -161,14 +154,14 @@ test_that("A gt table can store the correct style statements", {
         columns = "hp", rows = 2)
     )
 
+  styles_tbl <- dt_styles_get(data = tbl_html)
   # Expect that the internal `styles_df` data frame will have
   # a single row
-  dt_styles_get(data = tbl_html) %>%
-    nrow() %>%
-    expect_equal(1)
+  expect_1_row(styles_tbl)
+  expect_equal(styles_tbl$locname, "summary_cells")
 })
 
-test_that("tab_style errors if problems occur", {
+test_that("tab_style() errors if locations can't be resolved", {
   # Expect an error if columns couldn't be resolved
   expect_snapshot(
     error = TRUE,
@@ -293,8 +286,7 @@ test_that("tab style works with grand_summary", {
   # Expect that the internal `styles_df` data frame will have
   # a single row
   dt_styles_get(data = tbl_html) %>%
-    nrow() %>%
-    expect_equal(1)
+    expect_1_row()
 })
 
 test_that("tab_style() works with column spanners", {
@@ -411,29 +403,26 @@ test_that("tab_style() works with a single cell", {
       locations = cells_body(columns = c(disp, hp), rows = "Mazda RX4")
     )
 
+  styles_tbl <- dt_styles_get(data = tbl_html)
+
   # Expect that the internal `styles_df` data frame will have two rows
-  dt_styles_get(data = tbl_html) %>%
-    nrow() %>%
-    expect_equal(2)
+  expect_equal(
+    nrow(styles_tbl),
+    2
+  )
 
   # Expect certain values for each of the columns in the two rows
   # of the `styles_df` data frame
-  dt_styles_get(data = tbl_html) %>%
-    .[1, ] %>%
-    unlist() %>%
-    unname() %>%
-    expect_equal(c(
-      "data", NA_character_, "disp", "5", "1", NA_character_, "#FFFF00")
-    )
-
-  dt_styles_get(data = tbl_html) %>%
-    .[2, ] %>%
-    unlist() %>%
-    unname() %>%
-    expect_equal(c(
-      "data", NA_character_, "hp", "5", "1", NA_character_, "#FFFF00")
-    )
-
+  expect_equal(
+    unlist(styles_tbl[1, ]),
+    c("data", NA_character_, "disp", "5", "1", NA_character_, "#FFFF00"),
+    ignore_attr = "names"
+  )
+  expect_equal(
+    unlist(styles_tbl[2, ]),
+    c("data", NA_character_, "hp", "5", "1", NA_character_, "#FFFF00"),
+    ignore_attr = "names"
+  )
 
 })
 

From 3eb150093bb24185bf45b66e810e3901ba571154 Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Thu, 11 Jul 2024 12:13:21 -0400
Subject: [PATCH 03/28] Error early if rows don't exist #1535 + use string in
 resolver error message.

---
 R/resolver.R                         | 20 ++++++++++++++++++--
 tests/testthat/_snaps/table_parts.md |  9 +++++++++
 tests/testthat/test-table_parts.R    | 20 ++++++++++++++++++++
 3 files changed, 47 insertions(+), 2 deletions(-)

diff --git a/R/resolver.R b/R/resolver.R
index cb477c191b..07aa17869f 100644
--- a/R/resolver.R
+++ b/R/resolver.R
@@ -644,7 +644,23 @@ normalize_resolved <- function(
 
     unknown_resolved <- setdiff(resolved, item_names)
     if (length(unknown_resolved) != 0) {
-      resolver_stop_on_character(item_label = item_label, unknown_resolved = unknown_resolved, call = call)
+      if (all(is.na(item_names)) && item_label == "row")  {
+        # Send a more informative message when the gt table has no rows
+        # rows need to be initialized with `rownames_to_stub = TRUE` or with `rowname_col = <column>`
+        # Issue #1535 (Override the resolver default error message.)
+
+        cli::cli_abort(c(
+          "Can't find named rows in the table",
+          "i" = "In {.help [gt()](gt::gt)}, use {.code rownames_to_stub = TRUE} or specify {.arg rowname_col} to initialize row names in the table."
+        ), call = call)
+      }
+
+      # Potentially use arg_match() when rlang issue is solved?
+      resolver_stop_on_character(
+        item_label = item_label,
+        unknown_resolved = unknown_resolved,
+        call = call
+      )
     }
     resolved <- item_names %in% resolved
 
@@ -693,7 +709,7 @@ resolver_stop_on_character <- function(
   # Specify cli pluralization
   l <- length(unknown_resolved)
   cli::cli_abort(
-    "{item_label}{cli::qty(l)}{?s} {.code {unknown_resolved}}
+    "{item_label}{cli::qty(l)}{?s} {.str {unknown_resolved}}
     do{?es/} not exist in the data.",
     call = call
   )
diff --git a/tests/testthat/_snaps/table_parts.md b/tests/testthat/_snaps/table_parts.md
index 3b3f53ce4e..db6c747973 100644
--- a/tests/testthat/_snaps/table_parts.md
+++ b/tests/testthat/_snaps/table_parts.md
@@ -26,3 +26,12 @@
     Output
       [1] "<table class=\"gt_table\" data-quarto-disable-processing=\"false\" data-quarto-bootstrap=\"false\">\n  <thead>\n    <tr class=\"gt_heading\">\n      <td colspan=\"11\" class=\"gt_heading gt_title gt_font_normal gt_bottom_border\" style>test title</td>\n    </tr>\n    \n    <tr class=\"gt_col_headings\">\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"mpg\">mpg</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"cyl\">cyl</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"disp\">disp</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"hp\">hp</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"drat\">drat</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"wt\">wt</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"qsec\">qsec</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"vs\">vs</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"am\">am</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"gear\">gear</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"carb\">carb</th>\n    </tr>\n  </thead>\n  <tbody class=\"gt_table_body\">\n    <tr><td headers=\"mpg\" class=\"gt_row gt_right\">21.0</td>\n<td headers=\"cyl\" class=\"gt_row gt_right\">6</td>\n<td headers=\"disp\" class=\"gt_row gt_right\">160</td>\n<td headers=\"hp\" class=\"gt_row gt_right\">110</td>\n<td headers=\"drat\" class=\"gt_row gt_right\">3.90</td>\n<td headers=\"wt\" class=\"gt_row gt_right\">2.620</td>\n<td headers=\"qsec\" class=\"gt_row gt_right\">16.46</td>\n<td headers=\"vs\" class=\"gt_row gt_right\">0</td>\n<td headers=\"am\" class=\"gt_row gt_right\">1</td>\n<td headers=\"gear\" class=\"gt_row gt_right\">4</td>\n<td headers=\"carb\" class=\"gt_row gt_right\">4</td></tr>\n    <tr><td headers=\"mpg\" class=\"gt_row gt_right\">21.0</td>\n<td headers=\"cyl\" class=\"gt_row gt_right\">6</td>\n<td headers=\"disp\" class=\"gt_row gt_right\">160</td>\n<td headers=\"hp\" class=\"gt_row gt_right\">110</td>\n<td headers=\"drat\" class=\"gt_row gt_right\">3.90</td>\n<td headers=\"wt\" class=\"gt_row gt_right\">2.875</td>\n<td headers=\"qsec\" class=\"gt_row gt_right\">17.02</td>\n<td headers=\"vs\" class=\"gt_row gt_right\">0</td>\n<td headers=\"am\" class=\"gt_row gt_right\">1</td>\n<td headers=\"gear\" class=\"gt_row gt_right\">4</td>\n<td headers=\"carb\" class=\"gt_row gt_right\">4</td></tr>\n    <tr><td headers=\"mpg\" class=\"gt_row gt_right\">22.8</td>\n<td headers=\"cyl\" class=\"gt_row gt_right\">4</td>\n<td headers=\"disp\" class=\"gt_row gt_right\">108</td>\n<td headers=\"hp\" class=\"gt_row gt_right\">93</td>\n<td headers=\"drat\" class=\"gt_row gt_right\">3.85</td>\n<td headers=\"wt\" class=\"gt_row gt_right\">2.320</td>\n<td headers=\"qsec\" class=\"gt_row gt_right\">18.61</td>\n<td headers=\"vs\" class=\"gt_row gt_right\">1</td>\n<td headers=\"am\" class=\"gt_row gt_right\">1</td>\n<td headers=\"gear\" class=\"gt_row gt_right\">4</td>\n<td headers=\"carb\" class=\"gt_row gt_right\">1</td></tr>\n    <tr><td headers=\"mpg\" class=\"gt_row gt_right\">21.4</td>\n<td headers=\"cyl\" class=\"gt_row gt_right\">6</td>\n<td headers=\"disp\" class=\"gt_row gt_right\">258</td>\n<td headers=\"hp\" class=\"gt_row gt_right\">110</td>\n<td headers=\"drat\" class=\"gt_row gt_right\">3.08</td>\n<td headers=\"wt\" class=\"gt_row gt_right\">3.215</td>\n<td headers=\"qsec\" class=\"gt_row gt_right\">19.44</td>\n<td headers=\"vs\" class=\"gt_row gt_right\">1</td>\n<td headers=\"am\" class=\"gt_row gt_right\">0</td>\n<td headers=\"gear\" class=\"gt_row gt_right\">3</td>\n<td headers=\"carb\" class=\"gt_row gt_right\">1</td></tr>\n    <tr><td headers=\"mpg\" class=\"gt_row gt_right\">18.7</td>\n<td headers=\"cyl\" class=\"gt_row gt_right\">8</td>\n<td headers=\"disp\" class=\"gt_row gt_right\">360</td>\n<td headers=\"hp\" class=\"gt_row gt_right\">175</td>\n<td headers=\"drat\" class=\"gt_row gt_right\">3.15</td>\n<td headers=\"wt\" class=\"gt_row gt_right\">3.440</td>\n<td headers=\"qsec\" class=\"gt_row gt_right\">17.02</td>\n<td headers=\"vs\" class=\"gt_row gt_right\">0</td>\n<td headers=\"am\" class=\"gt_row gt_right\">0</td>\n<td headers=\"gear\" class=\"gt_row gt_right\">3</td>\n<td headers=\"carb\" class=\"gt_row gt_right\">2</td></tr>\n  </tbody>\n  \n  \n</table>"
 
+# tab_row_group() errors when named rows are supplied (#1535)
+
+    Code
+      gt_tbl %>% tab_row_group("Mazda", c("Mazda RX4", "Mazda RX4 Wag"))
+    Condition
+      Error in `tab_row_group()`:
+      ! Can't find named rows in the table
+      i In gt() (`?gt::gt()`), use `rownames_to_stub = TRUE` or specify `rowname_col` to initialize row names in the table.
+
diff --git a/tests/testthat/test-table_parts.R b/tests/testthat/test-table_parts.R
index 5e1e8feebe..bba2316fd9 100644
--- a/tests/testthat/test-table_parts.R
+++ b/tests/testthat/test-table_parts.R
@@ -400,6 +400,26 @@ test_that("Row groups can be successfully generated with `tab_row_group()", {
   )
 })
 
+test_that("tab_row_group() errors when named rows are supplied (#1535)", {
+
+  # create a gt tbl with no rows
+  gt_tbl <- mtcars_short %>% gt()
+  # create a gt tbl with rows
+  gt_tbl_rows <- mtcars_short %>% gt(rownames_to_stub = TRUE)
+
+  expect_no_error(gt_tbl_rows %>% tab_row_group("Mazda", c("Mazda RX4", "Mazda RX4 Wag")))
+
+  # expect a special error if the gt
+  expect_snapshot(error = TRUE, {
+    gt_tbl %>% tab_row_group("Mazda", c("Mazda RX4", "Mazda RX4 Wag"))
+  })
+  # regular resolver error if wrong row
+  expect_error(
+    gt_tbl_rows %>% tab_row_group("Mazda", c("Mazda RX4", "Mazda not present")),
+    "Mazda not present"
+  )
+})
+
 test_that("A default row group name can be modified with `tab_options()`", {
 
   # Check that specific suggested packages are available

From 121a4f375a933ff39b6ca1cc9157e9240a5a8bae Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Thu, 11 Jul 2024 12:13:57 -0400
Subject: [PATCH 04/28] Refactor tab_row_group() tests + use test helper

---
 tests/testthat/_snaps/table_parts.md | 22 +++++++
 tests/testthat/helper.R              |  9 +++
 tests/testthat/test-table_parts.R    | 85 +++++++++++++---------------
 3 files changed, 69 insertions(+), 47 deletions(-)

diff --git a/tests/testthat/_snaps/table_parts.md b/tests/testthat/_snaps/table_parts.md
index db6c747973..74676ee169 100644
--- a/tests/testthat/_snaps/table_parts.md
+++ b/tests/testthat/_snaps/table_parts.md
@@ -26,6 +26,28 @@
     Output
       [1] "<table class=\"gt_table\" data-quarto-disable-processing=\"false\" data-quarto-bootstrap=\"false\">\n  <thead>\n    <tr class=\"gt_heading\">\n      <td colspan=\"11\" class=\"gt_heading gt_title gt_font_normal gt_bottom_border\" style>test title</td>\n    </tr>\n    \n    <tr class=\"gt_col_headings\">\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"mpg\">mpg</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"cyl\">cyl</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"disp\">disp</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"hp\">hp</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"drat\">drat</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"wt\">wt</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"qsec\">qsec</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"vs\">vs</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"am\">am</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"gear\">gear</th>\n      <th class=\"gt_col_heading gt_columns_bottom_border gt_right\" rowspan=\"1\" colspan=\"1\" scope=\"col\" id=\"carb\">carb</th>\n    </tr>\n  </thead>\n  <tbody class=\"gt_table_body\">\n    <tr><td headers=\"mpg\" class=\"gt_row gt_right\">21.0</td>\n<td headers=\"cyl\" class=\"gt_row gt_right\">6</td>\n<td headers=\"disp\" class=\"gt_row gt_right\">160</td>\n<td headers=\"hp\" class=\"gt_row gt_right\">110</td>\n<td headers=\"drat\" class=\"gt_row gt_right\">3.90</td>\n<td headers=\"wt\" class=\"gt_row gt_right\">2.620</td>\n<td headers=\"qsec\" class=\"gt_row gt_right\">16.46</td>\n<td headers=\"vs\" class=\"gt_row gt_right\">0</td>\n<td headers=\"am\" class=\"gt_row gt_right\">1</td>\n<td headers=\"gear\" class=\"gt_row gt_right\">4</td>\n<td headers=\"carb\" class=\"gt_row gt_right\">4</td></tr>\n    <tr><td headers=\"mpg\" class=\"gt_row gt_right\">21.0</td>\n<td headers=\"cyl\" class=\"gt_row gt_right\">6</td>\n<td headers=\"disp\" class=\"gt_row gt_right\">160</td>\n<td headers=\"hp\" class=\"gt_row gt_right\">110</td>\n<td headers=\"drat\" class=\"gt_row gt_right\">3.90</td>\n<td headers=\"wt\" class=\"gt_row gt_right\">2.875</td>\n<td headers=\"qsec\" class=\"gt_row gt_right\">17.02</td>\n<td headers=\"vs\" class=\"gt_row gt_right\">0</td>\n<td headers=\"am\" class=\"gt_row gt_right\">1</td>\n<td headers=\"gear\" class=\"gt_row gt_right\">4</td>\n<td headers=\"carb\" class=\"gt_row gt_right\">4</td></tr>\n    <tr><td headers=\"mpg\" class=\"gt_row gt_right\">22.8</td>\n<td headers=\"cyl\" class=\"gt_row gt_right\">4</td>\n<td headers=\"disp\" class=\"gt_row gt_right\">108</td>\n<td headers=\"hp\" class=\"gt_row gt_right\">93</td>\n<td headers=\"drat\" class=\"gt_row gt_right\">3.85</td>\n<td headers=\"wt\" class=\"gt_row gt_right\">2.320</td>\n<td headers=\"qsec\" class=\"gt_row gt_right\">18.61</td>\n<td headers=\"vs\" class=\"gt_row gt_right\">1</td>\n<td headers=\"am\" class=\"gt_row gt_right\">1</td>\n<td headers=\"gear\" class=\"gt_row gt_right\">4</td>\n<td headers=\"carb\" class=\"gt_row gt_right\">1</td></tr>\n    <tr><td headers=\"mpg\" class=\"gt_row gt_right\">21.4</td>\n<td headers=\"cyl\" class=\"gt_row gt_right\">6</td>\n<td headers=\"disp\" class=\"gt_row gt_right\">258</td>\n<td headers=\"hp\" class=\"gt_row gt_right\">110</td>\n<td headers=\"drat\" class=\"gt_row gt_right\">3.08</td>\n<td headers=\"wt\" class=\"gt_row gt_right\">3.215</td>\n<td headers=\"qsec\" class=\"gt_row gt_right\">19.44</td>\n<td headers=\"vs\" class=\"gt_row gt_right\">1</td>\n<td headers=\"am\" class=\"gt_row gt_right\">0</td>\n<td headers=\"gear\" class=\"gt_row gt_right\">3</td>\n<td headers=\"carb\" class=\"gt_row gt_right\">1</td></tr>\n    <tr><td headers=\"mpg\" class=\"gt_row gt_right\">18.7</td>\n<td headers=\"cyl\" class=\"gt_row gt_right\">8</td>\n<td headers=\"disp\" class=\"gt_row gt_right\">360</td>\n<td headers=\"hp\" class=\"gt_row gt_right\">175</td>\n<td headers=\"drat\" class=\"gt_row gt_right\">3.15</td>\n<td headers=\"wt\" class=\"gt_row gt_right\">3.440</td>\n<td headers=\"qsec\" class=\"gt_row gt_right\">17.02</td>\n<td headers=\"vs\" class=\"gt_row gt_right\">0</td>\n<td headers=\"am\" class=\"gt_row gt_right\">0</td>\n<td headers=\"gear\" class=\"gt_row gt_right\">3</td>\n<td headers=\"carb\" class=\"gt_row gt_right\">2</td></tr>\n  </tbody>\n  \n  \n</table>"
 
+# tab_row_group() warns for deprecated args, but respects output.
+
+    Code
+      gt_tbl <- gt(exibble, rowname_col = "row") %>% tab_row_group(label = "group_prioritized",
+        group = "group", rows = 1:3)
+    Condition
+      Warning:
+      Since gt v0.3.0 the `group` argument has been deprecated.
+      * Use the `label` argument to specify the group label.
+      This warning is displayed once every 8 hours.
+
+---
+
+    Code
+      gt_tbl <- (gt(exibble, rowname_col = "row") %>% tab_row_group(label = "one",
+        rows = 1:3) %>% tab_row_group(others_label = "foo"))
+    Condition
+      Warning:
+      Since gt v0.3.0 the `others_label` argument has been deprecated.
+      * Use `tab_options(row_group.default_label = <label>)` to set this label.
+      This warning is displayed once every 8 hours.
+
 # tab_row_group() errors when named rows are supplied (#1535)
 
     Code
diff --git a/tests/testthat/helper.R b/tests/testthat/helper.R
index 2026329f05..f3ee7065af 100644
--- a/tests/testthat/helper.R
+++ b/tests/testthat/helper.R
@@ -63,6 +63,15 @@ expect_merge_locale_sep <- function(locale = NULL, global_locale = NULL, sep = N
   expect_equal(actual_merge_sep, expected_sep, label = paste0("locale = ", locale))
 }
 
+# Gets the text from a row group label
+get_row_group_text <- function(tbl_html) {
+  gsub(
+    "\n\\s+",
+    "",
+    selection_text(tbl_html, "[class='gt_group_heading_row']")
+  )
+}
+
 # Create a shortened version of `mtcars`
 mtcars_short <- datasets::mtcars[1:5, ]
 
diff --git a/tests/testthat/test-table_parts.R b/tests/testthat/test-table_parts.R
index bba2316fd9..3e12e6fc7f 100644
--- a/tests/testthat/test-table_parts.R
+++ b/tests/testthat/test-table_parts.R
@@ -3,13 +3,6 @@ check_suggests <- function() {
   skip_if_not_installed("rvest")
 }
 
-# Gets the text from a row group label
-get_row_group_text <- function(tbl_html) {
-  tbl_html %>%
-    selection_text("[class='gt_group_heading_row']") %>%
-    gsub("\n\\s+", "", .)
-}
-
 test_that("A gt table contains the expected heading components", {
 
   # Check that specific suggested packages are available
@@ -160,9 +153,7 @@ test_that("A gt table contains the expected source note", {
     ))
 })
 
-test_that("Row groups can be successfully generated with `tab_row_group()", {
-
-  local_options("rlib_warning_verbosity" = "verbose")
+test_that("tab_row_group() can generate row groups.", {
 
   # Check that specific suggested packages are available
   check_suggests()
@@ -270,7 +261,11 @@ test_that("Row groups can be successfully generated with `tab_row_group()", {
     c("Mazda", "Mercs", "")
   )
 
-  tbl_html <-
+})
+
+test_that("tab_row_group() gives the correct output", {
+
+  tbl_rows <-
     exibble %>%
     gt() %>%
     tab_row_group(
@@ -294,29 +289,28 @@ test_that("Row groups can be successfully generated with `tab_row_group()", {
     tab_footnote(
       footnote = "a footnote",
       locations = cells_row_groups("group_a")
-    ) %>%
-    render_as_html()
+    )
 
   # Expect to see the styled and unstyled variations of the `"void"`
   # row group labels
-  expect_match(
-    tbl_html,
-    regexp = "<span class='gt_from_md'><strong><em>void</em></strong></span><span class=\"gt_footnote_marks\" style=\"white-space:nowrap;font-style:italic;font-weight:normal;line-height: 0;\"><sup>1</sup></span>",
-    fixed = TRUE
-  )
-  expect_match(
-    tbl_html,
-    regexp = "<th colspan=\"9\" class=\"gt_group_heading\" scope=\"colgroup\" id=\"void\">void</th>",
+  expect_match_html(
+    tbl_rows,
+    regexp = c(
+      "<span class='gt_from_md'><strong><em>void</em></strong></span><span class=\"gt_footnote_marks\" style=\"white-space:nowrap;font-style:italic;font-weight:normal;line-height: 0;\"><sup>1</sup></span>",
+      "<th colspan=\"9\" class=\"gt_group_heading\" scope=\"colgroup\" id=\"void\">void</th>"
+    ),
     fixed = TRUE
   )
 
   # Expect that the inner HTML content for the two row groups
   # is in the prescribed order
+  tbl_html_text <- xml2::read_html(render_as_html(tbl_rows))
   expect_equal(
-    get_row_group_text(tbl_html %>% xml2::read_html()),
+    get_row_group_text(tbl_html_text),
     c("void1", "void")
   )
 
+
   # When specifying a row group that captures no rows, expect that
   # the rendered table is essentially unaffected by this function call
   expect_equal(
@@ -326,31 +320,13 @@ test_that("Row groups can be successfully generated with `tab_row_group()", {
     gt(exibble, rowname_col = "row") %>%
       render_as_html()
   )
+})
 
-  # Expect an error if not providing a `label` for `tab_row_group()`
-  # but there is a specification of rows
-  expect_error(
-    exibble %>%
-      gt() %>%
-      tab_row_group(
-        rows = group == "grp_a"
-      )
-  )
-
-  # Expect a warning if using the `others_label` argument
-  expect_warning(
-    gt(exibble, rowname_col = "row") %>%
-      tab_row_group(others_label = "foo")
-  )
-
-  # Expect a warning if using the `group` argument
-  expect_warning(
-    gt(exibble, rowname_col = "row") %>%
-      tab_row_group(group = "group", rows = 1:3)
-  )
+test_that("tab_row_group() warns for deprecated args, but respects output.", {
+  local_options("rlib_warning_verbosity" = "verbose")
 
   # Expect a warning if using both the `label` and `group` argument
-  expect_warning(
+  expect_snapshot(
     gt_tbl <-
       gt(exibble, rowname_col = "row") %>%
       tab_row_group(
@@ -372,13 +348,14 @@ test_that("Row groups can be successfully generated with `tab_row_group()", {
 
   # Expect that `tab_options(row_group.default_label = <label>)`
   # is called internally if using the deprecated `others_label` argument
-  gt_tbl <-
-    suppressWarnings(
+  expect_snapshot(
+    gt_tbl <-
+    (
       gt(exibble, rowname_col = "row") %>%
         tab_row_group(label = "one", rows = 1:3) %>%
         tab_row_group(others_label = "foo")
     )
-
+  )
   expect_equal(
     dt_options_get_value(gt_tbl, "row_group_default_label"),
     "foo"
@@ -400,6 +377,19 @@ test_that("Row groups can be successfully generated with `tab_row_group()", {
   )
 })
 
+test_that("tab_row_group() errors with bad input", {
+  # Expect an error if not providing a `label` for `tab_row_group()`
+  # but there is a specification of rows
+  expect_error(
+    exibble %>%
+      gt() %>%
+      tab_row_group(
+        rows = group == "grp_a"
+      ),
+    "label"
+  )
+})
+
 test_that("tab_row_group() errors when named rows are supplied (#1535)", {
 
   # create a gt tbl with no rows
@@ -421,6 +411,7 @@ test_that("tab_row_group() errors when named rows are supplied (#1535)", {
 })
 
 test_that("A default row group name can be modified with `tab_options()`", {
+  local_options("rlib_warning_verbosity" = "verbose")
 
   # Check that specific suggested packages are available
   check_suggests()

From ee4d05bfd0c19d9767f9206d594abe208eda291a Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Thu, 11 Jul 2024 13:16:16 -0400
Subject: [PATCH 05/28] Refactor tests + accept snapshots

---
 tests/testthat/_snaps/tab_footnote.md |   4 +-
 tests/testthat/_snaps/tab_style.md    |  19 ++---
 tests/testthat/test-fmt_percent.R     |   6 +-
 tests/testthat/test-tab_spanner.R     |   2 +-
 tests/testthat/test-tab_style.R       | 105 +++++++++++---------------
 5 files changed, 56 insertions(+), 80 deletions(-)

diff --git a/tests/testthat/_snaps/tab_footnote.md b/tests/testthat/_snaps/tab_footnote.md
index 45e03ef084..c7468c3b99 100644
--- a/tests/testthat/_snaps/tab_footnote.md
+++ b/tests/testthat/_snaps/tab_footnote.md
@@ -579,7 +579,7 @@
       Error in `tab_footnote()`:
       ! Can't add footnote "First data cell.".
       Caused by error in `cells_column_spanners()`:
-      ! Spanner `valuer` does not exist in the data.
+      ! Spanner "valuer" does not exist in the data.
     Code
       tab_footnote(start_gt, footnote = "First data cell.", locations = cells_column_spanners(
         3))
@@ -595,7 +595,7 @@
       Error in `tab_footnote()`:
       ! Can't add footnote "Footnote error.".
       Caused by error in `cells_body()`:
-      ! Row `Mazda RX7` does not exist in the data.
+      ! Row "Mazda RX7" does not exist in the data.
 
 # tab_footnote() errors well when it can't resolve location
 
diff --git a/tests/testthat/_snaps/tab_style.md b/tests/testthat/_snaps/tab_style.md
index 1d8ce18316..24e73d61ed 100644
--- a/tests/testthat/_snaps/tab_style.md
+++ b/tests/testthat/_snaps/tab_style.md
@@ -1,7 +1,7 @@
 # tab_style() errors if locations can't be resolved
 
     Code
-      data %>% tab_style(style = list(cell_fill(color = "green"), cell_text(color = "white")),
+      tab_style(data, style = list(cell_fill(color = "green"), cell_text(color = "white")),
       locations = cells_summary(groups = "Mercs", columns = starts_with("x"), rows = 2))
     Condition
       Error in `tab_style()`:
@@ -9,11 +9,8 @@
       Caused by error in `cells_summary()`:
       ! The location requested could not be resolved.
       * Review the expression provided as `columns`.
-
----
-
     Code
-      data %>% tab_style(style = list(cell_fill(color = "green"), cell_text(color = "white")),
+      tab_style(data, style = list(cell_fill(color = "green"), cell_text(color = "white")),
       locations = cells_summary(groups = "Mercs", columns = starts_with("m"), rows = starts_with(
         "x")))
     Condition
@@ -22,11 +19,8 @@
       Caused by error in `cells_summary()`:
       ! The location requested could not be resolved.
       * Review the expression provided as `rows`.
-
----
-
     Code
-      data %>% tab_style(style = list(cell_fill(color = "green"), cell_text(color = "white")),
+      tab_style(data, style = list(cell_fill(color = "green"), cell_text(color = "white")),
       locations = cells_column_labels(`non existent`))
     Condition
       Error in `tab_style()`:
@@ -34,11 +28,8 @@
       Caused by error in `cells_column_labels()`:
       ! Can't select columns that don't exist.
       x Column `non existent` doesn't exist.
-
----
-
     Code
-      data %>% tab_style(style = list(cell_fill(color = "green"), cell_text(color = "white")),
+      tab_style(data, style = list(cell_fill(color = "green"), cell_text(color = "white")),
       locations = cells_column_spanners(2))
     Condition
       Error in `tab_style()`:
@@ -80,7 +71,7 @@
       Error in `tab_style()`:
       ! Failed to style the body of the table.
       Caused by error in `cells_body()`:
-      ! Row `Mazda RX7` does not exist in the data.
+      ! Row "Mazda RX7" does not exist in the data.
 
 # Using fonts in `from_column()` works within `cell_*()` fns
 
diff --git a/tests/testthat/test-fmt_percent.R b/tests/testthat/test-fmt_percent.R
index 2b463ec435..4093084c0e 100644
--- a/tests/testthat/test-fmt_percent.R
+++ b/tests/testthat/test-fmt_percent.R
@@ -414,10 +414,10 @@ test_that("fmt_percent() can render in the Indian numbering system", {
 })
 
 test_that("fmt_percent() works correctly with stubs", {
-  tbl <- tibble::tibble(
+  tbl <- dplyr::tibble(
     raw = c("[shiny](https://shiny.posit.co/)", "<a href='https://gt.rstudio.com/'>gt</a>"),
-    markdown = purrr::map(c("[shiny](https://shiny.posit.co/)", "[gt](https://gt.rstudio.com/)"), gt::md),
-    html = purrr::map(c("<a href='https://shiny.posit.co/'>shiny</a>", "<a href='https://gt.rstudio.com/'>gt</a>"), gt::html),
+    markdown = lapply(c("[shiny](https://shiny.posit.co/)", "[gt](https://gt.rstudio.com/)"), md),
+    html = lapply(c("<a href='https://shiny.posit.co/'>shiny</a>", "<a href='https://gt.rstudio.com/'>gt</a>"), html),
     str_col = c("shiny", "gt"),
     pct_col = c(0.75, 0.25)
   )
diff --git a/tests/testthat/test-tab_spanner.R b/tests/testthat/test-tab_spanner.R
index 5655bead3d..a6524b1a0d 100644
--- a/tests/testthat/test-tab_spanner.R
+++ b/tests/testthat/test-tab_spanner.R
@@ -1078,7 +1078,7 @@ cli::test_that_cli("multiple levels of `tab_spanner()` are not compatible with i
   }
 )
 
-test_that("multiple levels of `tab_spanner()` are not compatible with interactive tables and only use 1st level", {
+test_that("tab_spanner() can't render multiple spanners in interactive tables and only use 1st level", {
   check_suggests()
   skip_if_not_installed("jsonlite")
 
diff --git a/tests/testthat/test-tab_style.R b/tests/testthat/test-tab_style.R
index 0026a99e0d..b9d08d177c 100644
--- a/tests/testthat/test-tab_style.R
+++ b/tests/testthat/test-tab_style.R
@@ -160,70 +160,55 @@ test_that("A gt table can have a background in the summary.", {
   expect_1_row(styles_tbl)
   expect_equal(styles_tbl$locname, "summary_cells")
 })
-
 test_that("tab_style() errors if locations can't be resolved", {
-  # Expect an error if columns couldn't be resolved
-  expect_snapshot(
-    error = TRUE,
-    data %>%
-      tab_style(
-        style = list(
-          cell_fill(color = "green"),
-          cell_text(color = "white")
-        ),
-        locations = cells_summary(
-          groups = "Mercs",
-          columns = starts_with("x"),
-          rows = 2
-        )
+  expect_snapshot(error = TRUE, {
+    # Expect an error if columns couldn't be resolved
+    tab_style(
+      data,
+      style = list(
+        cell_fill(color = "green"),
+        cell_text(color = "white")
+      ),
+      locations = cells_summary(
+        groups = "Mercs",
+        columns = starts_with("x"),
+        rows = 2
       )
-  )
-
-  # Expect an error if rows couldn't be resolved
-  expect_snapshot(
-    error = TRUE,
-    data %>%
-      tab_style(
-        style = list(
-          cell_fill(color = "green"),
-          cell_text(color = "white")
-        ),
-        locations = cells_summary(
-          groups = "Mercs",
-          columns = starts_with("m"),
-          rows = starts_with("x")
-        )
+    )
+    # Expect an error if rows couldn't be resolved
+    tab_style(
+      data,
+      style = list(
+        cell_fill(color = "green"),
+        cell_text(color = "white")
+      ),
+      locations = cells_summary(
+        groups = "Mercs",
+        columns = starts_with("m"),
+        rows = starts_with("x")
       )
-  )
+    )
 
-  # Expect an error if column spanner couldn't be resolved
-  expect_snapshot(
-    error = TRUE,
-    data %>%
-      tab_style(
-        style = list(
-          cell_fill(color = "green"),
-          cell_text(color = "white")
-        ),
-        locations = cells_column_labels(
-          `non existent`
-        )
-      )
-  )
-  # Expect an error if column spanner couldn't be resolved
-  expect_snapshot(
-    error = TRUE,
-    data %>%
-      tab_style(
-        style = list(
-          cell_fill(color = "green"),
-          cell_text(color = "white")
-        ),
-        locations = cells_column_spanners(
-          2
-        )
-      )
-  )
+    # Expect an error if column spanner couldn't be resolved
+    tab_style(
+      data,
+      style = list(
+        cell_fill(color = "green"),
+        cell_text(color = "white")
+      ),
+      locations = cells_column_labels(`non existent`)
+    )
+
+    # Expect an error if column spanner couldn't be resolved
+    tab_style(
+      data,
+      style = list(
+        cell_fill(color = "green"),
+        cell_text(color = "white")
+      ),
+      locations = cells_column_spanners(2)
+    )
+  })
 })
 
 test_that("tab style works with grand_summary", {

From f97e8259b7f71b6fec9b46c67fd088a531b9c64b Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Thu, 11 Jul 2024 13:16:47 -0400
Subject: [PATCH 06/28] Add news

---
 NEWS.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/NEWS.md b/NEWS.md
index 497221b44e..6ef2a1c929 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,5 +1,7 @@
 # gt (development version)
 
+* `tab_row_group()` give a more precise error message when `rows` can't be resolved correctly (@olivroy, #1535).
+
 # gt 0.11.0
 
 ## New features

From 97f9e746f05f81ab062fe10616b135c7b72d8a2a Mon Sep 17 00:00:00 2001
From: olivroy <52606734+olivroy@users.noreply.github.com>
Date: Thu, 11 Jul 2024 14:08:48 -0400
Subject: [PATCH 07/28] Update snapshots

---
 tests/testthat/_snaps/tab_remove.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/testthat/_snaps/tab_remove.md b/tests/testthat/_snaps/tab_remove.md
index e85e812727..c28c7e2de9 100644
--- a/tests/testthat/_snaps/tab_remove.md
+++ b/tests/testthat/_snaps/tab_remove.md
@@ -110,12 +110,12 @@
       rm_spanners(t_sp, "span2")
     Condition
       Error in `rm_spanners()`:
-      ! Spanner `span2` does not exist in the data.
+      ! Spanner "span2" does not exist in the data.
     Code
       rm_spanners(t_sp, c("span1", "span2", "span3"))
     Condition
       Error in `rm_spanners()`:
-      ! Spanners `span2` and `span3` do not exist in the data.
+      ! Spanners "span2" and "span3" do not exist in the data.
 
 # Table footnotes can be removed using `rm_footnotes()`
 

From 14e9ddf8a48d6cad78abd08c9835bd28d47d22c2 Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Thu, 11 Jul 2024 17:13:50 -0400
Subject: [PATCH 08/28] Ensure `md("")` will render in Quarto.

Make sure no "" are sent to `charToRaw()`. #1769
---
 NEWS.md                      |  2 ++
 R/utils.R                    |  9 +++++----
 R/utils_render_grid.R        |  1 +
 tests/testthat/test-quarto.R | 17 +++++++++++++++++
 4 files changed, 25 insertions(+), 4 deletions(-)
 create mode 100644 tests/testthat/test-quarto.R

diff --git a/NEWS.md b/NEWS.md
index 497221b44e..0612b05324 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,5 +1,7 @@
 # gt (development version)
 
+* Fixed an issue where `md("")` would fail in Quarto (@olivroy, #1769).
+
 # gt 0.11.0
 
 ## New features
diff --git a/R/utils.R b/R/utils.R
index bbcc58e468..38f79c7335 100644
--- a/R/utils.R
+++ b/R/utils.R
@@ -710,12 +710,12 @@ process_text <- function(text, context = "html") {
       # Markdown text handling for Quarto
       #
       if (in_quarto) {
-
-        non_na_text <- text[!is.na(text)]
+        # exclude "" and NA #1769
+        non_na_text <- text[nzchar(text, keepNA = FALSE)]
 
         non_na_text_processed <-
           vapply(
-            as.character(text[!is.na(text)]),
+            non_na_text,
             FUN.VALUE = character(1L),
             USE.NAMES = FALSE,
             FUN = function(text) {
@@ -732,6 +732,7 @@ process_text <- function(text, context = "html") {
             FUN.VALUE = character(1L),
             USE.NAMES = FALSE,
             FUN = function(text) {
+              # charToRaw("") returns character(0)
               base64enc::base64encode(charToRaw(as.character(text)))
             }
           )
@@ -745,7 +746,7 @@ process_text <- function(text, context = "html") {
             non_na_text_processed, "</div></div>"
           )
 
-        text[!is.na(text)] <- non_na_text
+        text[nzchar(text, keepNA = FALSE)] <- non_na_text
 
         return(text)
       }
diff --git a/R/utils_render_grid.R b/R/utils_render_grid.R
index d90ccd5e1e..c404b0a66d 100644
--- a/R/utils_render_grid.R
+++ b/R/utils_render_grid.R
@@ -994,6 +994,7 @@ render_grid_svg <- function(label, style, margin) {
   raster <- try_fetch(
     {
       svg_string %>%
+        # charToRaw("") return character(0)
         charToRaw() %>%
         rsvg::rsvg_nativeraster(width = w) %>%
         grid::rasterGrob(
diff --git a/tests/testthat/test-quarto.R b/tests/testthat/test-quarto.R
new file mode 100644
index 0000000000..8e4b7d352c
--- /dev/null
+++ b/tests/testthat/test-quarto.R
@@ -0,0 +1,17 @@
+skip_on_cran()
+test_that("Rendering in Quarto doesn't error with empty string (#1769)", {
+  local_mocked_bindings(check_quarto = function() TRUE)
+  tbl <-  mtcars_short %>%
+    dplyr::select(mpg, cyl) %>% gt()
+  # note that these don't produce the same output.
+  # render_as_html(tbl %>% cols_label(mpg = "")),
+  # render_as_html(tbl %>% cols_label(mpg = md("")))
+  expect_no_match_html(
+    tbl %>% cols_label(mpg = gt::md("")),
+    ">mpg</th>", fixed = TRUE
+    )
+  expect_match_html(
+    tbl %>% cols_label(mpg = gt::md("")),
+    ">cyl</th>", fixed = TRUE
+  )
+})

From 45ffcf90e40e15c2d5e9ea88a7ed5a8119d2f7c8 Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Thu, 11 Jul 2024 17:14:07 -0400
Subject: [PATCH 09/28] Add `expect_no_match_html()`

---
 tests/testthat/helper.R | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/tests/testthat/helper.R b/tests/testthat/helper.R
index 2026329f05..3781cb194e 100644
--- a/tests/testthat/helper.R
+++ b/tests/testthat/helper.R
@@ -50,6 +50,31 @@ expect_match_html <- function(object,
   }
 }
 
+
+# shortcut for expect_match(render_as_html(object), regexp)
+expect_no_match_html <- function(object,
+                              regexp,
+                              perl = FALSE,
+                              fixed = FALSE,
+                              ...,
+                              all = TRUE,
+                              info = NULL,
+                              label = NULL) {
+  rendered <- render_as_html(object)
+  for (i in seq_along(regexp)) {
+    testthat::expect_no_match(
+      object = rendered,
+      regexp = regexp[i],
+      perl = perl,
+      fixed = fixed,
+      ...,
+      all = all,
+      info = info,
+      label = label
+    )
+  }
+}
+
 expect_merge_locale_sep <- function(locale = NULL, global_locale = NULL, sep = NULL, expected_sep) {
   tbl <- data.frame(
     col_1 = 1,

From 74b620379a0b0b5673549e63d01d9bf1316e9c34 Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Thu, 11 Jul 2024 17:14:56 -0400
Subject: [PATCH 10/28] Move quarto function to own file.

---
 R/quarto.R             | 27 +++++++++++++++++++++++++++
 R/utils_environments.R |  4 ----
 2 files changed, 27 insertions(+), 4 deletions(-)
 create mode 100644 R/quarto.R

diff --git a/R/quarto.R b/R/quarto.R
new file mode 100644
index 0000000000..31f6731292
--- /dev/null
+++ b/R/quarto.R
@@ -0,0 +1,27 @@
+#------------------------------------------------------------------------------#
+#
+#                /$$
+#               | $$
+#     /$$$$$$  /$$$$$$
+#    /$$__  $$|_  $$_/
+#   | $$  \ $$  | $$
+#   | $$  | $$  | $$ /$$
+#   |  $$$$$$$  |  $$$$/
+#    \____  $$   \___/
+#    /$$  \ $$
+#   |  $$$$$$/
+#    \______/
+#
+#  This file is part of the 'rstudio/gt' project.
+#
+#  Copyright (c) 2018-2024 gt authors
+#
+#  For full copyright and license information, please look at
+#  https://gt.rstudio.com/LICENSE.html
+#
+#------------------------------------------------------------------------------#
+
+
+check_quarto <- function() {
+  Sys.getenv("QUARTO_BIN_PATH") != ""
+}
diff --git a/R/utils_environments.R b/R/utils_environments.R
index 6c281d6a94..5dc9207ae4 100644
--- a/R/utils_environments.R
+++ b/R/utils_environments.R
@@ -22,10 +22,6 @@
 #------------------------------------------------------------------------------#
 
 
-check_quarto <- function() {
-  Sys.getenv("QUARTO_BIN_PATH") != ""
-}
-
 check_dbnb <- function() {
   Sys.getenv("DATABRICKS_RUNTIME_VERSION") != ""
 }

From fc531d4bf3599efd5943486ed913f54f5af86e1e Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Thu, 11 Jul 2024 22:03:12 -0400
Subject: [PATCH 11/28] Remove unused `dt_col_merge_init()`

---
 R/dt_cols_merge.R | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/R/dt_cols_merge.R b/R/dt_cols_merge.R
index 822a02efb8..41a0f526c5 100644
--- a/R/dt_cols_merge.R
+++ b/R/dt_cols_merge.R
@@ -32,10 +32,6 @@ dt_col_merge_set <- function(data, col_merge) {
   dt__set(data, .dt_col_merge_key, col_merge)
 }
 
-dt_col_merge_init <- function(data) {
-  dt_col_merge_set(data = data, col_merge = list())
-}
-
 dt_col_merge_add <- function(data, col_merge) {
   added <- append(dt_col_merge_get(data = data), list(col_merge))
   dt_col_merge_set(data = data, col_merge = added)

From 74a90e5aacbe7ed11297901dc8c80612ed7f553e Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Thu, 11 Jul 2024 22:41:31 -0400
Subject: [PATCH 12/28] Refactor all text transforming functions to use
 `text_transform_impl()` for better stack trace.

---
 R/text_transform.R | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/R/text_transform.R b/R/text_transform.R
index 519c411163..c59a9ac11e 100644
--- a/R/text_transform.R
+++ b/R/text_transform.R
@@ -108,7 +108,7 @@ text_replace <- function(
   # Perform input object validation
   stop_if_not_gt_tbl(data = data)
 
-  text_transform(
+  text_transform_impl(
     data = data,
     locations = locations,
     fn = function(x) {
@@ -217,7 +217,7 @@ text_case_when <- function(
   # TODO: check that the modernized version of the `case_when()`
   # function is available in the user's version of dplyr
 
-  text_transform(
+  text_transform_impl(
     data = .data,
     locations = .locations,
     fn = function(x) {
@@ -383,10 +383,9 @@ text_case_match <- function(
   # TODO: perform some basic checking of `...` and stop function
   # should issues arise
 
-  # TODO: check that the `case_match()` function is available in
-  # the user's version of dplyr
+  # We rely on dplyr 1.1 (where case_match() was introduced)
 
-  text_transform(
+  text_transform_impl(
     data = .data,
     locations = .locations,
     fn = function(x) {
@@ -603,6 +602,17 @@ text_transform <- function(
 
   # Perform input object validation
   stop_if_not_gt_tbl(data = data)
+  rlang::check_required(fn)
+
+  text_transform_impl(
+    data,
+    fn,
+    locations
+  )
+}
+
+# Helper function to create text_*()
+text_transform_impl <- function(data, fn, locations, call = rlang::caller_env()) {
 
   # Resolve into a list of locations
   locations <- as_locations(locations = locations)

From b5e6972b05f226a61a8d3fc2f39af680d025d345 Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Thu, 11 Jul 2024 22:48:14 -0400
Subject: [PATCH 13/28] inherit docs from main function

---
 R/text_transform.R | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/R/text_transform.R b/R/text_transform.R
index c59a9ac11e..dae816dc07 100644
--- a/R/text_transform.R
+++ b/R/text_transform.R
@@ -32,13 +32,6 @@
 #' remaining two values to supply are for the regex pattern (`pattern`) and the
 #' replacement for all matched text (`replacement`).
 #'
-#' @param data *The gt table data object*
-#'
-#'   `obj:<gt_tbl>` // **required**
-#'
-#'   This is the **gt** table object that is commonly created through use of the
-#'   [gt()] function.
-#'
 #' @param pattern *Regex pattern to match with*
 #'
 #'   `scalar<character>` // **required**
@@ -130,13 +123,6 @@ text_replace <- function(
 #' (i.e., either `TRUE` or `FALSE`). To refer to the values undergoing
 #' transformation, you need to use the `x` variable.
 #'
-#' @param .data *The gt table data object*
-#'
-#'   `obj:<gt_tbl>` // **required**
-#'
-#'   This is the **gt** table object that is commonly created through use of the
-#'   [gt()] function.
-#'
 #' @param ... *Matching expressions*
 #'
 #'   `<multiple expressions>` // **required**

From 2167c745b0f99a789b8e869315a7928f6304987c Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Thu, 11 Jul 2024 22:49:54 -0400
Subject: [PATCH 14/28] Improve stack trace + add test for `text_*()` functions
 `locations` error messages.

---
 .Rbuildignore                           |  2 ++
 NEWS.md                                 |  2 ++
 R/location_methods.R                    | 20 ++++++++++++++------
 R/text_transform.R                      |  7 ++++++-
 tests/testthat/_snaps/text_transform.md | 11 +++++++++++
 tests/testthat/test-text_transform.R    | 22 ++++++++++++++++++++++
 6 files changed, 57 insertions(+), 7 deletions(-)
 create mode 100644 tests/testthat/_snaps/text_transform.md

diff --git a/.Rbuildignore b/.Rbuildignore
index ce0c08d108..92cf250ba0 100644
--- a/.Rbuildignore
+++ b/.Rbuildignore
@@ -171,6 +171,8 @@ tests/testthat/test-table_parts.R
 tests/testthat/_snaps/table_parts.md
 
 tests/testthat/test-text_transform.R
+tests/testthat/_snaps/text_transform.md
+
 tests/testthat/test-util_functions.R
 tests/testthat/test-utils_formatters.R
 tests/testthat/test-utils_plots.R
diff --git a/NEWS.md b/NEWS.md
index 497221b44e..35da89e042 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,5 +1,7 @@
 # gt (development version)
 
+* Improved error messages for the `text_transform()` functions if `locations` couldn't be resolved (@olivroy, #1774).
+
 # gt 0.11.0
 
 ## New features
diff --git a/R/location_methods.R b/R/location_methods.R
index ac86ca486a..6ed8a5bc74 100644
--- a/R/location_methods.R
+++ b/R/location_methods.R
@@ -286,16 +286,19 @@ resolve_location.resolved <- function(loc, data) {
 #' @export
 resolve_location.cells_body <- function(loc, data) {
 
+  call <- call("cells_body")
   loc$colnames <-
     resolve_cols_c(
       expr = !!loc[["columns"]],
-      data = data
+      data = data,
+      call = call
     )
 
   loc$rows <-
     resolve_rows_i(
       expr = !!loc[["rows"]],
-      data = data
+      data = data,
+      call = call
     )
 
   class(loc) <- c("resolved", class(loc))
@@ -305,12 +308,14 @@ resolve_location.cells_body <- function(loc, data) {
 #' @export
 resolve_location.cells_column_labels <- function(loc, data) {
 
+  call <- call("cells_column_labels")
   if (!is.null(loc$columns)) {
 
     loc$colnames <-
       resolve_cols_c(
         expr = !!loc[["columns"]],
-        data = data
+        data = data,
+        call = call
       )
   }
 
@@ -326,7 +331,8 @@ resolve_location.cells_column_labels <- function(loc, data) {
 #' @export
 resolve_location.cells_column_spanners <- function(loc, data) {
 
-  resolved <- resolve_cells_column_spanners(data = data, object = loc)
+  call <- call("cells_column_spanners")
+  resolved <- resolve_cells_column_spanners(data = data, object = loc, call = call)
 
   loc$spanners <- resolved$spanners
 
@@ -338,7 +344,8 @@ resolve_location.cells_column_spanners <- function(loc, data) {
 #' @export
 resolve_location.cells_stub <- function(loc, data) {
 
-  resolved <- resolve_cells_stub(data = data, object = loc)
+  call <- call("cells_stub")
+  resolved <- resolve_cells_stub(data = data, object = loc, call = call)
 
   loc$rows <- resolved$rows
 
@@ -350,7 +357,8 @@ resolve_location.cells_stub <- function(loc, data) {
 #' @export
 resolve_location.cells_row_groups <- function(loc, data) {
 
-  resolved <- resolve_cells_row_groups(data = data, object = loc)
+  call <- call("cells_row_groups")
+  resolved <- resolve_cells_row_groups(data = data, object = loc, call = call)
 
   loc$groups <- resolved$groups
 
diff --git a/R/text_transform.R b/R/text_transform.R
index dae816dc07..f4fe91a9ab 100644
--- a/R/text_transform.R
+++ b/R/text_transform.R
@@ -606,7 +606,12 @@ text_transform_impl <- function(data, fn, locations, call = rlang::caller_env())
   # For all of the resolved locations, store the transforms
   # for later execution
   for (loc in locations) {
-    data <- dt_transforms_add(data = data, loc = loc, fn = fn)
+    withCallingHandlers(
+      # Personalize call if text_case_match() or other.
+      data <- dt_transforms_add(data = data, loc = loc, fn = fn),
+      error = function(e) {
+        cli::cli_abort("Failed to resolve location.", parent = e, call = call)
+      })
   }
 
   data
diff --git a/tests/testthat/_snaps/text_transform.md b/tests/testthat/_snaps/text_transform.md
new file mode 100644
index 0000000000..479c6f3bbb
--- /dev/null
+++ b/tests/testthat/_snaps/text_transform.md
@@ -0,0 +1,11 @@
+# text_case_match() works on the tab_spanner()
+
+    Code
+      gt_tbl %>% text_case_match("boring " ~ "awesome ", .replace = "partial",
+      .locations = cells_column_spanners(2))
+    Condition
+      Error in `text_case_match()`:
+      ! Failed to resolve location.
+      Caused by error in `cells_column_spanners()`:
+      ! Spanner 2 does not exist in the data.
+
diff --git a/tests/testthat/test-text_transform.R b/tests/testthat/test-text_transform.R
index f290f7f108..9101142ffe 100644
--- a/tests/testthat/test-text_transform.R
+++ b/tests/testthat/test-text_transform.R
@@ -318,6 +318,28 @@ test_that("text_transform() works on row labels in the stub", {
     )
 })
 
+test_that("text_case_match() works on the tab_spanner()", {
+  gt_tbl <- exibble %>% gt() %>% tab_spanner("the boring spanner", columns = c(num, date))
+  expect_snapshot(error = TRUE, {
+    gt_tbl %>%
+      text_case_match(
+        "boring " ~ "awesome ",
+        .replace = "partial",
+        .locations = cells_column_spanners(2)
+      )
+  })
+  expect_no_error(new_tb <- gt_tbl %>%
+    text_case_match(
+      "boring " ~ "awesome ",
+      .replace = "partial",
+      .locations = cells_column_spanners()
+    ))
+  expect_match_html(
+     new_tb,
+     "awesome spanner"
+  )
+})
+
 test_that("text_transform() works on row group labels", {
 
   # Create a gt table and modify the two different

From 41b6fcef9c174a78ac7529b547af06a88a55e771 Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Thu, 11 Jul 2024 22:50:25 -0400
Subject: [PATCH 15/28] Validate input with `check_string()` in
 `text_replace()` to avoid warnings.

---
 R/text_transform.R | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/R/text_transform.R b/R/text_transform.R
index f4fe91a9ab..16a3276a65 100644
--- a/R/text_transform.R
+++ b/R/text_transform.R
@@ -101,6 +101,10 @@ text_replace <- function(
   # Perform input object validation
   stop_if_not_gt_tbl(data = data)
 
+  # Validate input
+  check_string(pattern, allow_empty = FALSE, allow_na = TRUE)
+  check_string(replacement, allow_empty = TRUE, allow_na = FALSE)
+
   text_transform_impl(
     data = data,
     locations = locations,

From 7298e16471226a36c041aaa085e7beab3cb21da9 Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Thu, 11 Jul 2024 22:50:48 -0400
Subject: [PATCH 16/28] Add more tests to improve coverage.

---
 tests/testthat/test-text_transform.R | 34 ++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/tests/testthat/test-text_transform.R b/tests/testthat/test-text_transform.R
index 9101142ffe..0f2e31a879 100644
--- a/tests/testthat/test-text_transform.R
+++ b/tests/testthat/test-text_transform.R
@@ -436,3 +436,37 @@ test_that("text_transform() works on row group labels", {
     selection_text("[class='gt_group_heading']") %>%
     expect_equal(c("SUPER POWERFUL", "POWERFUL"))
 })
+
+
+# text_*() other functions -----------------------------------------------------
+
+test_that("text_case_when() + text_case_match() work", {
+  expect_no_error(
+    cw <- exibble %>%
+      gt() %>%
+      text_case_when(is.na(x) ~ "---")
+  )
+  # md is not really respected even if we use md("---")
+  expect_no_error(
+    cm <- exibble %>%
+      gt() %>%
+      text_case_match(NA ~ "---")
+  )
+  # they are not changing numeric NA
+  expect_equal(
+    render_as_html(cw),
+    render_as_html(cm)
+  )
+})
+
+test_that("text_replace() works", {
+  expect_no_error(
+    tr <- exibble %>%
+      gt() %>%
+      text_replace("NA", "---")
+  )
+  expect_match_html(
+    tr,
+    "---"
+  )
+})

From 479a18e0b17fabe343624a7c5a30028912a40d26 Mon Sep 17 00:00:00 2001
From: Teun van den Brand <tahvdbrand@gmail.com>
Date: Fri, 12 Jul 2024 09:08:45 +0200
Subject: [PATCH 17/28] deal with pct column widths

---
 R/export.R | 31 +++++++++++++++++++++++--------
 1 file changed, 23 insertions(+), 8 deletions(-)

diff --git a/R/export.R b/R/export.R
index 1ae5c6cdae..4354e7cad6 100644
--- a/R/export.R
+++ b/R/export.R
@@ -1438,13 +1438,20 @@ grid_layout_widths <- function(layout, data) {
 
   # Enlarge columns if fixed column widths have been set
   column_width <- unlist(dt_boxhead_get(data)$column_width)
-  fixed <- integer(0L)
+  fixed    <- integer(0)
+  relative <- rep(NA_real_, length(widths))
 
   if (any(nzchar(column_width)) && length(column_width) == length(widths)) {
-
-    fixed <- which(nzchar(column_width))
-    widths[fixed] <- pmax(parse_px_to_pt(column_width[fixed]), widths[fixed])
+    fixed <- which(endsWith(column_width, "px"))
+    if (length(fixed) > 0) {
+      widths[fixed] <- pmax(parse_px_to_pt(column_width[fixed]), widths[fixed])
+    }
+    pct <- which(endsWith(column_width, "%"))
+    if (length(pct) > 0) {
+      relative[pct] <- as.numeric(gsub("\\%$", "", column_width[pct])) / 100
+    }
   }
+  pct <- which(!is.na(relative))
 
   spanner <- spanner[order(spanner$key$left, spanner$key$right), ]
 
@@ -1475,8 +1482,11 @@ grid_layout_widths <- function(layout, data) {
 
     change <- setdiff(seq_along(widths), fixed)
     widths[change] <- widths[change] + extra_width / (length(widths[change]))
-
-    return(grid::unit(widths, .grid_unit))
+    widths <- grid::unit(widths, .grid_unit)
+    if (length(pct) > 0) {
+      widths[pct] <- grid::unit(relative[pct], "npc")
+    }
+    return(widths)
   }
 
   if (grepl("\\%$", total_width)) {
@@ -1494,10 +1504,15 @@ grid_layout_widths <- function(layout, data) {
 
     # Take pairwise max between minimal size and relative size
     widths <- grid::unit.pmax(grid::unit(widths, .grid_unit), extra_width)
+    if (length(pct) > 0) {
+      widths[pct] <- grid::unit(relative[pct], "npc")
+    }
     return(widths)
   }
-
-  grid::unit(widths, .grid_unit)
+  grid::unit(
+    ifelse(is.na(relative), widths, relative),
+    ifelse(is.na(relative), .grid_unit, "npc")
+  )
 }
 
 #' Extract the table body from a **gt** object

From 139cf2e0b6017ececa8c3d519d1c40a4822302c4 Mon Sep 17 00:00:00 2001
From: Teun van den Brand <tahvdbrand@gmail.com>
Date: Fri, 12 Jul 2024 09:09:02 +0200
Subject: [PATCH 18/28] add test

---
 tests/testthat/test-render_as_gtable.R | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tests/testthat/test-render_as_gtable.R b/tests/testthat/test-render_as_gtable.R
index d8bde7aa01..61a9e45a38 100644
--- a/tests/testthat/test-render_as_gtable.R
+++ b/tests/testthat/test-render_as_gtable.R
@@ -138,4 +138,13 @@ test_that("gtable widths are set appropriately", {
     as.numeric(test$widths)[1] * 3,
     as.numeric(test$widths)[4]
   )
+
+  test <- tbl %>%
+    cols_width(x ~ pct(20), y ~ px(200)) %>%
+    as_gtable(tbl, text_grob = dummy_text)
+
+  expect_equal(
+    as.character(test$widths),
+    c("0.5null", "0.2npc", "150.5625points", "0.5null")
+  )
 })

From 86478956dd17c58f08b127c21ccd8924e6adc988 Mon Sep 17 00:00:00 2001
From: Teun van den Brand <tahvdbrand@gmail.com>
Date: Fri, 12 Jul 2024 09:14:17 +0200
Subject: [PATCH 19/28] add news bullet

---
 NEWS.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/NEWS.md b/NEWS.md
index 8e1ab71697..6825a3d2e8 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -5,6 +5,8 @@
 * `tab_row_group()` gives a more precise error message when `rows` can't be resolved correctly (#1535). (@olivroy, #1770)
 
 * Fixed an issue where `md("")` would fail in Quarto. (@olivroy, #1769)
+
+* Fixed a bug in using `pct()` column widths with `as_gtable()` (@teunbrand, #1771)
  
 # gt 0.11.0
 

From 7caacc3c69730109e9ef2416e23fa6143bb9be21 Mon Sep 17 00:00:00 2001
From: Teun van den Brand <tahvdbrand@gmail.com>
Date: Fri, 12 Jul 2024 09:27:12 +0200
Subject: [PATCH 20/28] remove specious `grid::unit()`

---
 R/export.R | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/R/export.R b/R/export.R
index 4354e7cad6..e9331b525f 100644
--- a/R/export.R
+++ b/R/export.R
@@ -1414,7 +1414,7 @@ grid_align_gtable <- function(gtable, data) {
 
   } else {
 
-    right <- grid::unit(grid::unit(parse_px_to_pt(left), "pt"))
+    right <- grid::unit(parse_px_to_pt(left), "pt")
   }
 
   gtable <- gtable::gtable_add_cols(gtable, left,  pos = 0)

From 709ff07112d09337cb18ee88b37398f01522a690 Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Fri, 12 Jul 2024 08:20:33 -0400
Subject: [PATCH 21/28] Move `fmt()` into own file along with the utils for
 formatting.

---
 R/{utils_formatters.R => fmt.R}               | 249 +++++++++++++++++-
 R/format_data.R                               | 204 --------------
 .../{test-conditional_fmt.R => test-fmt.R}    |   0
 ...{test-l_conditional_fmt.R => test-l_fmt.R} |   0
 4 files changed, 240 insertions(+), 213 deletions(-)
 rename R/{utils_formatters.R => fmt.R} (80%)
 rename tests/testthat/{test-conditional_fmt.R => test-fmt.R} (100%)
 rename tests/testthat/{test-l_conditional_fmt.R => test-l_fmt.R} (100%)

diff --git a/R/utils_formatters.R b/R/fmt.R
similarity index 80%
rename from R/utils_formatters.R
rename to R/fmt.R
index 6fdac2f15e..83a01e2303 100644
--- a/R/utils_formatters.R
+++ b/R/fmt.R
@@ -22,6 +22,192 @@
 #------------------------------------------------------------------------------#
 
 
+#' Set a column format with a formatter function
+#'
+#' @description
+#'
+#' `fmt()` provides a way to execute custom formatting functionality with raw
+#' data values in a way that can consider all output contexts.
+#'
+#' Along with the `columns` and `rows` arguments that provide some precision in
+#' targeting data cells, the `fns` argument allows you to define one or more
+#' functions for manipulating the raw data.
+#'
+#' If providing a single function to `fns`, the recommended format is in the
+#' form: `fns = function(x) ...`. This single function will format the targeted
+#' data cells the same way regardless of the output format (e.g., HTML, LaTeX,
+#' RTF).
+#'
+#' If you require formatting of `x` that depends on the output format, a list of
+#' functions can be provided for the `html`, `latex`, `rtf`, and `default`
+#' contexts. This can be in the form of `fns = list(html = function(x) ...,
+#' latex = function(x) ..., default = function(x) ...)`. In this
+#' multiple-function case, we recommended including the `default` function as a
+#' fallback if all contexts aren't provided.
+#'
+#' @inheritParams fmt_number
+#'
+#' @param compat *Formatting compatibility*
+#'
+#'   `vector<character>` // *default:* `NULL` (`optional`)
+#'
+#'   An optional vector that provides the compatible classes for the formatting.
+#'   By default this is `NULL`.
+#'
+#' @param fns *Formatting functions*
+#'
+#'   `function|list of functions` // **required**
+#'
+#'   Either a single formatting function or a named list of functions.
+#'
+#' @return An object of class `gt_tbl`.
+#'
+#' @section Targeting cells with `columns` and `rows`:
+#'
+#' Targeting of values is done through `columns` and additionally by `rows` (if
+#' nothing is provided for `rows` then entire columns are selected). The
+#' `columns` argument allows us to target a subset of cells contained in the
+#' resolved columns. We say resolved because aside from declaring column names
+#' in `c()` (with bare column names or names in quotes) we can use
+#' **tidyselect**-style expressions. This can be as basic as supplying a select
+#' helper like `starts_with()`, or, providing a more complex incantation like
+#'
+#' `where(~ is.numeric(.x) && max(.x, na.rm = TRUE) > 1E6)`
+#'
+#' which targets numeric columns that have a maximum value greater than
+#' 1,000,000 (excluding any `NA`s from consideration).
+#'
+#' By default all columns and rows are selected (with the `everything()`
+#' defaults). Cell values that are incompatible with a given formatting function
+#' will be skipped over, like `character` values and numeric `fmt_*()`
+#' functions. So it's safe to select all columns with a particular formatting
+#' function (only those values that can be formatted will be formatted), but,
+#' you may not want that. One strategy is to format the bulk of cell values with
+#' one formatting function and then constrain the columns for later passes with
+#' other types of formatting (the last formatting done to a cell is what you get
+#' in the final output).
+#'
+#' Once the columns are targeted, we may also target the `rows` within those
+#' columns. This can be done in a variety of ways. If a stub is present, then we
+#' potentially have row identifiers. Those can be used much like column names in
+#' the `columns`-targeting scenario. We can use simpler **tidyselect**-style
+#' expressions (the select helpers should work well here) and we can use quoted
+#' row identifiers in `c()`. It's also possible to use row indices (e.g.,
+#' `c(3, 5, 6)`) though these index values must correspond to the row numbers of
+#' the input data (the indices won't necessarily match those of rearranged rows
+#' if row groups are present). One more type of expression is possible, an
+#' expression that takes column values (can involve any of the available columns
+#' in the table) and returns a logical vector. This is nice if you want to base
+#' formatting on values in the column or another column, or, you'd like to use a
+#' more complex predicate expression.
+#'
+#' @section Examples:
+#'
+#' Use the [`exibble`] dataset to create a **gt** table. Using the `fmt()`
+#' function, we'll format the numeric values in the `num` column with a function
+#' supplied to the `fns` argument. This supplied function will take values in
+#' the column (`x`), multiply them by 1000, and exclose them in single quotes.
+#'
+#' ```r
+#' exibble |>
+#'   dplyr::select(-row, -group) |>
+#'   gt() |>
+#'   fmt(
+#'     columns = num,
+#'     fns = function(x) {
+#'       paste0("'", x * 1000, "'")
+#'     }
+#'   )
+#' ```
+#'
+#' \if{html}{\out{
+#' `r man_get_image_tag(file = "man_fmt_1.png")`
+#' }}
+#'
+#' @family data formatting functions
+#' @section Function ID:
+#' 3-30
+#'
+#' @section Function Introduced:
+#' `v0.2.0.5` (March 31, 2020)
+#'
+#' @export
+fmt <- function(
+    data,
+    columns = everything(),
+    rows = everything(),
+    compat = NULL,
+    fns
+) {
+
+  # Perform input object validation
+  stop_if_not_gt_tbl(data = data)
+
+  #
+  # Resolution of columns and rows as character vectors
+  #
+
+  resolved_columns <-
+    resolve_cols_c(
+      expr = {{ columns }},
+      data = data,
+      excl_stub = FALSE
+    )
+
+  resolved_rows_idx <-
+    resolve_rows_i(
+      expr = {{ rows }},
+      data = data
+    )
+
+  # If a single function is supplied to `fns` then
+  # repackage that into a list as the `default` function
+  if (is.function(fns)) {
+    fns <- list(default = fns)
+  }
+
+  # Create the `formatter_list`, which is a bundle of
+  # formatting functions for specific columns and rows
+  formatter_list <-
+    list(
+      func = fns,
+      cols = resolved_columns,
+      rows = resolved_rows_idx,
+      compat = compat
+    )
+
+  dt_formats_add(
+    data = data,
+    formats = formatter_list
+  )
+}
+
+# Utils formatters -------------------
+
+#------------------------------------------------------------------------------#
+#
+#                /$$
+#               | $$
+#     /$$$$$$  /$$$$$$
+#    /$$__  $$|_  $$_/
+#   | $$  \ $$  | $$
+#   | $$  | $$  | $$ /$$
+#   |  $$$$$$$  |  $$$$/
+#    \____  $$   \___/
+#    /$$  \ $$
+#   |  $$$$$$/
+#    \______/
+#
+#  This file is part of the 'rstudio/gt' project.
+#
+#  Copyright (c) 2018-2024 gt authors
+#
+#  For full copyright and license information, please look at
+#  https://gt.rstudio.com/LICENSE.html
+#
+#------------------------------------------------------------------------------#
+
+
 #' Filter an internal table to a single row with filtering expressions
 #'
 #' @param table The table to filter down to one row.
@@ -86,8 +272,8 @@ validate_locale <- function(locale, call = rlang::caller_env()) {
     cli::cli_abort(c(
       "The supplied `locale` is not available in the list of supported locales.",
       "i" = "Use {.run [info_locales()](gt::info_locales())} to see which locales can be used."
-      ),
-      call = call
+    ),
+    call = call
     )
   }
 }
@@ -119,8 +305,8 @@ validate_currency <- function(currency, call = rlang::caller_env()) {
       "The supplied `currency` is not available in the list of supported currencies.",
       "i" = "Use {.run [info_currencies()](gt::info_currencies())} to see which currencies can be used.",
       "i" = "See {.help [{.fn fmt_currency}](gt::fmt_currency)} to better understand which input types are valid."
-      ),
-      call = call
+    ),
+    call = call
     )
   }
 }
@@ -576,6 +762,51 @@ format_num_to_str_c <- function(
   )
 }
 
+#' Insert separator marks to an integer to conform to Indian numbering system
+#'
+#' @param integer The integer portion of a numeric value. Should be supplied as
+#'   a length-1 character vector. The element should only contain numeral
+#'   characters.
+#'
+#' @noRd
+insert_seps_ind <- function(integer) {
+
+  # The `fmt_fraction()` formatter can sometimes generate
+  # empty strings; if seen here, just return them unchanged
+  if (integer == "") {
+    return(integer)
+  }
+
+  # Ensure that integer-based strings only contain numbers
+  if (!grepl("^[0-9]+?$", integer)) {
+    cli::cli_abort(
+      "The `integer` string must only contain numbers."
+    )
+  }
+
+  # Return integer unchanged if there are no commas to insert
+  if (nchar(integer) < 4) return(integer)
+
+  # Generate an 'insertion sequence' (where to place the separators)
+  insertion_seq <- cumsum(c(3, rep(2, floor((nchar(integer) - 4) / 2)))) + 1
+  insertion_seq <- (nchar(integer) - insertion_seq) + 2
+
+  split_strings <- split_str_by_index(target = integer, index = insertion_seq)
+
+  paste(split_strings, collapse = ",")
+}
+
+split_str_by_index <- function(target, index) {
+
+  index <- sort(index)
+  substr(
+    rep_len(target, length(index) + 1),
+    start = c(1, index),
+    stop = c(index - 1, nchar(target))
+  )
+}
+
+
 #' Surround formatted values with `$`s for LaTeX
 #'
 #' @param x Numeric values in `character` form.
@@ -907,10 +1138,10 @@ context_symbol_str <- function(context, symbol) {
       latex = {
         if (!inherits(symbol, "AsIs")) {
           #paste_between(
-            markdown_to_latex(
-              get_currency_str(currency = symbol, fallback_to_code = TRUE),
-              md_engine = "commonmark"
-            )#,
+          markdown_to_latex(
+            get_currency_str(currency = symbol, fallback_to_code = TRUE),
+            md_engine = "commonmark"
+          )#,
           #  c("\\text{", "}")
           #)
         } else {
@@ -1258,7 +1489,7 @@ generate_param_tbl <- function(
     data,
     arg_vals,
     resolved_rows_idx
-  ) {
+) {
 
   data_df <- dt_data_get(data = data)
 
diff --git a/R/format_data.R b/R/format_data.R
index 860dfa2787..b394342792 100644
--- a/R/format_data.R
+++ b/R/format_data.R
@@ -13849,207 +13849,3 @@ fmt_auto <- function(
 
   data
 }
-
-#' Set a column format with a formatter function
-#'
-#' @description
-#'
-#' `fmt()` provides a way to execute custom formatting functionality with raw
-#' data values in a way that can consider all output contexts.
-#'
-#' Along with the `columns` and `rows` arguments that provide some precision in
-#' targeting data cells, the `fns` argument allows you to define one or more
-#' functions for manipulating the raw data.
-#'
-#' If providing a single function to `fns`, the recommended format is in the
-#' form: `fns = function(x) ...`. This single function will format the targeted
-#' data cells the same way regardless of the output format (e.g., HTML, LaTeX,
-#' RTF).
-#'
-#' If you require formatting of `x` that depends on the output format, a list of
-#' functions can be provided for the `html`, `latex`, `rtf`, and `default`
-#' contexts. This can be in the form of `fns = list(html = function(x) ...,
-#' latex = function(x) ..., default = function(x) ...)`. In this
-#' multiple-function case, we recommended including the `default` function as a
-#' fallback if all contexts aren't provided.
-#'
-#' @inheritParams fmt_number
-#'
-#' @param compat *Formatting compatibility*
-#'
-#'   `vector<character>` // *default:* `NULL` (`optional`)
-#'
-#'   An optional vector that provides the compatible classes for the formatting.
-#'   By default this is `NULL`.
-#'
-#' @param fns *Formatting functions*
-#'
-#'   `function|list of functions` // **required**
-#'
-#'   Either a single formatting function or a named list of functions.
-#'
-#' @return An object of class `gt_tbl`.
-#'
-#' @section Targeting cells with `columns` and `rows`:
-#'
-#' Targeting of values is done through `columns` and additionally by `rows` (if
-#' nothing is provided for `rows` then entire columns are selected). The
-#' `columns` argument allows us to target a subset of cells contained in the
-#' resolved columns. We say resolved because aside from declaring column names
-#' in `c()` (with bare column names or names in quotes) we can use
-#' **tidyselect**-style expressions. This can be as basic as supplying a select
-#' helper like `starts_with()`, or, providing a more complex incantation like
-#'
-#' `where(~ is.numeric(.x) && max(.x, na.rm = TRUE) > 1E6)`
-#'
-#' which targets numeric columns that have a maximum value greater than
-#' 1,000,000 (excluding any `NA`s from consideration).
-#'
-#' By default all columns and rows are selected (with the `everything()`
-#' defaults). Cell values that are incompatible with a given formatting function
-#' will be skipped over, like `character` values and numeric `fmt_*()`
-#' functions. So it's safe to select all columns with a particular formatting
-#' function (only those values that can be formatted will be formatted), but,
-#' you may not want that. One strategy is to format the bulk of cell values with
-#' one formatting function and then constrain the columns for later passes with
-#' other types of formatting (the last formatting done to a cell is what you get
-#' in the final output).
-#'
-#' Once the columns are targeted, we may also target the `rows` within those
-#' columns. This can be done in a variety of ways. If a stub is present, then we
-#' potentially have row identifiers. Those can be used much like column names in
-#' the `columns`-targeting scenario. We can use simpler **tidyselect**-style
-#' expressions (the select helpers should work well here) and we can use quoted
-#' row identifiers in `c()`. It's also possible to use row indices (e.g.,
-#' `c(3, 5, 6)`) though these index values must correspond to the row numbers of
-#' the input data (the indices won't necessarily match those of rearranged rows
-#' if row groups are present). One more type of expression is possible, an
-#' expression that takes column values (can involve any of the available columns
-#' in the table) and returns a logical vector. This is nice if you want to base
-#' formatting on values in the column or another column, or, you'd like to use a
-#' more complex predicate expression.
-#'
-#' @section Examples:
-#'
-#' Use the [`exibble`] dataset to create a **gt** table. Using the `fmt()`
-#' function, we'll format the numeric values in the `num` column with a function
-#' supplied to the `fns` argument. This supplied function will take values in
-#' the column (`x`), multiply them by 1000, and exclose them in single quotes.
-#'
-#' ```r
-#' exibble |>
-#'   dplyr::select(-row, -group) |>
-#'   gt() |>
-#'   fmt(
-#'     columns = num,
-#'     fns = function(x) {
-#'       paste0("'", x * 1000, "'")
-#'     }
-#'   )
-#' ```
-#'
-#' \if{html}{\out{
-#' `r man_get_image_tag(file = "man_fmt_1.png")`
-#' }}
-#'
-#' @family data formatting functions
-#' @section Function ID:
-#' 3-30
-#'
-#' @section Function Introduced:
-#' `v0.2.0.5` (March 31, 2020)
-#'
-#' @export
-fmt <- function(
-    data,
-    columns = everything(),
-    rows = everything(),
-    compat = NULL,
-    fns
-) {
-
-  # Perform input object validation
-  stop_if_not_gt_tbl(data = data)
-
-  #
-  # Resolution of columns and rows as character vectors
-  #
-
-  resolved_columns <-
-    resolve_cols_c(
-      expr = {{ columns }},
-      data = data,
-      excl_stub = FALSE
-    )
-
-  resolved_rows_idx <-
-    resolve_rows_i(
-      expr = {{ rows }},
-      data = data
-    )
-
-  # If a single function is supplied to `fns` then
-  # repackage that into a list as the `default` function
-  if (is.function(fns)) {
-    fns <- list(default = fns)
-  }
-
-  # Create the `formatter_list`, which is a bundle of
-  # formatting functions for specific columns and rows
-  formatter_list <-
-    list(
-      func = fns,
-      cols = resolved_columns,
-      rows = resolved_rows_idx,
-      compat = compat
-    )
-
-  dt_formats_add(
-    data = data,
-    formats = formatter_list
-  )
-}
-
-#' Insert separator marks to an integer to conform to Indian numbering system
-#'
-#' @param integer The integer portion of a numeric value. Should be supplied as
-#'   a length-1 character vector. The element should only contain numeral
-#'   characters.
-#'
-#' @noRd
-insert_seps_ind <- function(integer) {
-
-  # The `fmt_fraction()` formatter can sometimes generate
-  # empty strings; if seen here, just return them unchanged
-  if (integer == "") {
-    return(integer)
-  }
-
-  # Ensure that integer-based strings only contain numbers
-  if (!grepl("^[0-9]+?$", integer)) {
-    cli::cli_abort(
-      "The `integer` string must only contain numbers."
-    )
-  }
-
-  # Return integer unchanged if there are no commas to insert
-  if (nchar(integer) < 4) return(integer)
-
-  # Generate an 'insertion sequence' (where to place the separators)
-  insertion_seq <- cumsum(c(3, rep(2, floor((nchar(integer) - 4) / 2)))) + 1
-  insertion_seq <- (nchar(integer) - insertion_seq) + 2
-
-  split_strings <- split_str_by_index(target = integer, index = insertion_seq)
-
-  paste(split_strings, collapse = ",")
-}
-
-split_str_by_index <- function(target, index) {
-
-  index <- sort(index)
-  substr(
-    rep_len(target, length(index) + 1),
-    start = c(1, index),
-    stop = c(index - 1, nchar(target))
-  )
-}
diff --git a/tests/testthat/test-conditional_fmt.R b/tests/testthat/test-fmt.R
similarity index 100%
rename from tests/testthat/test-conditional_fmt.R
rename to tests/testthat/test-fmt.R
diff --git a/tests/testthat/test-l_conditional_fmt.R b/tests/testthat/test-l_fmt.R
similarity index 100%
rename from tests/testthat/test-l_conditional_fmt.R
rename to tests/testthat/test-l_fmt.R

From 99da74e2f40b000bbbceb8a6bc337feed41f3b62 Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Fri, 12 Jul 2024 08:48:14 -0400
Subject: [PATCH 22/28] Align test name with R file.

---
 tests/testthat/{test-vec_fmt.R => test-format_vec.R} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename tests/testthat/{test-vec_fmt.R => test-format_vec.R} (100%)

diff --git a/tests/testthat/test-vec_fmt.R b/tests/testthat/test-format_vec.R
similarity index 100%
rename from tests/testthat/test-vec_fmt.R
rename to tests/testthat/test-format_vec.R

From 89302def732210777d582ac8dbc1ac495ab8369b Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Fri, 12 Jul 2024 08:57:31 -0400
Subject: [PATCH 23/28] Rename test files for consitency.

---
 .../testthat/_snaps/{summary_rows_latex.md => l_summary_rows.md}  | 0
 tests/testthat/_snaps/{cols_width_rtf.md => rtf_cols_width.md}    | 0
 .../testthat/_snaps/{summary_rows_rtf.md => rtf_summary_rows.md}  | 0
 .../testthat/{test-summary_rows_latex.R => test-l_summary_rows.R} | 0
 tests/testthat/{test-cols_width_rtf.R => test-rtf_cols_width.R}   | 0
 .../testthat/{test-summary_rows_rtf.R => test-rtf_summary_rows.R} | 0
 tests/testthat/{test-r_table_parts.R => test-rtf_table_parts.R}   | 0
 7 files changed, 0 insertions(+), 0 deletions(-)
 rename tests/testthat/_snaps/{summary_rows_latex.md => l_summary_rows.md} (100%)
 rename tests/testthat/_snaps/{cols_width_rtf.md => rtf_cols_width.md} (100%)
 rename tests/testthat/_snaps/{summary_rows_rtf.md => rtf_summary_rows.md} (100%)
 rename tests/testthat/{test-summary_rows_latex.R => test-l_summary_rows.R} (100%)
 rename tests/testthat/{test-cols_width_rtf.R => test-rtf_cols_width.R} (100%)
 rename tests/testthat/{test-summary_rows_rtf.R => test-rtf_summary_rows.R} (100%)
 rename tests/testthat/{test-r_table_parts.R => test-rtf_table_parts.R} (100%)

diff --git a/tests/testthat/_snaps/summary_rows_latex.md b/tests/testthat/_snaps/l_summary_rows.md
similarity index 100%
rename from tests/testthat/_snaps/summary_rows_latex.md
rename to tests/testthat/_snaps/l_summary_rows.md
diff --git a/tests/testthat/_snaps/cols_width_rtf.md b/tests/testthat/_snaps/rtf_cols_width.md
similarity index 100%
rename from tests/testthat/_snaps/cols_width_rtf.md
rename to tests/testthat/_snaps/rtf_cols_width.md
diff --git a/tests/testthat/_snaps/summary_rows_rtf.md b/tests/testthat/_snaps/rtf_summary_rows.md
similarity index 100%
rename from tests/testthat/_snaps/summary_rows_rtf.md
rename to tests/testthat/_snaps/rtf_summary_rows.md
diff --git a/tests/testthat/test-summary_rows_latex.R b/tests/testthat/test-l_summary_rows.R
similarity index 100%
rename from tests/testthat/test-summary_rows_latex.R
rename to tests/testthat/test-l_summary_rows.R
diff --git a/tests/testthat/test-cols_width_rtf.R b/tests/testthat/test-rtf_cols_width.R
similarity index 100%
rename from tests/testthat/test-cols_width_rtf.R
rename to tests/testthat/test-rtf_cols_width.R
diff --git a/tests/testthat/test-summary_rows_rtf.R b/tests/testthat/test-rtf_summary_rows.R
similarity index 100%
rename from tests/testthat/test-summary_rows_rtf.R
rename to tests/testthat/test-rtf_summary_rows.R
diff --git a/tests/testthat/test-r_table_parts.R b/tests/testthat/test-rtf_table_parts.R
similarity index 100%
rename from tests/testthat/test-r_table_parts.R
rename to tests/testthat/test-rtf_table_parts.R

From 8670517162ec7e742883b3f01959a1b8c83f84e9 Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Fri, 12 Jul 2024 08:59:42 -0400
Subject: [PATCH 24/28] Merge test-rtf_column_widths.R into
 test-rtf_cols_width.R + update Rbuilignore

---
 .Rbuildignore                           |  18 +-
 tests/testthat/test-rtf_cols_width.R    | 294 ++++++++++++++++++++++++
 tests/testthat/test-rtf_column_widths.R | 293 -----------------------
 3 files changed, 302 insertions(+), 303 deletions(-)
 delete mode 100644 tests/testthat/test-rtf_column_widths.R

diff --git a/.Rbuildignore b/.Rbuildignore
index 92cf250ba0..5e2703cea2 100644
--- a/.Rbuildignore
+++ b/.Rbuildignore
@@ -32,9 +32,6 @@ tests/testthat/test-cols_label_with.R
 tests/testthat/test-cols_merge.R
 tests/testthat/_snaps/cols_merge.md
 
-tests/testthat/test-cols_width_rtf.R
-tests/testthat/_snaps/cols_width_rtf.md
-
 tests/testthat/test-cols_width.R
 tests/testthat/_snaps/cols_width.md
 
@@ -110,6 +107,9 @@ tests/testthat/_snaps/image.md
 tests/testthat/test-info_tables.R
 tests/testthat/test-input_data_validation.R
 
+tests/testthat/test-l_summary_rows.R
+tests/testthat/_snaps/l_summary_rows.md
+
 tests/testthat/test-l_table_parts.R
 tests/testthat/_snaps/l_table_parts.md
 
@@ -124,20 +124,18 @@ tests/testthat/_snaps/removal_functions.md
 tests/testthat/test-rows_add.R
 tests/testthat/_snaps/rows_add.md
 
-tests/testthat/test-rtf_column_widths.R
+tests/testthat/test-rtf_cols_width.R
+tests/testthat/_snaps/rtf_cols_width.md
 
 tests/testthat/test-rtf_page_options.R
 tests/testthat/_snaps/rtf_page_options.md
 
+tests/testthat/test-rtf_summary_rows.R
+tests/testthat/_snaps/rtf_summary_rows.md
+
 tests/testthat/test-stub.R
 tests/testthat/test-substitution.R
 
-tests/testthat/test-summary_rows_latex.R
-tests/testthat/_snaps/summary_rows_latex.md
-
-tests/testthat/test-summary_rows_rtf.R
-tests/testthat/_snaps/summary_rows_rtf.md
-
 tests/testthat/test-summary_rows.R
 tests/testthat/_snaps/summary_rows.md
 
diff --git a/tests/testthat/test-rtf_cols_width.R b/tests/testthat/test-rtf_cols_width.R
index c5dba12a08..6bffb2ba14 100644
--- a/tests/testthat/test-rtf_cols_width.R
+++ b/tests/testthat/test-rtf_cols_width.R
@@ -372,3 +372,297 @@ test_that("cols_width() works in making RTF tables", {
     as_rtf() %>%
     expect_snapshot()
 })
+
+test_that("col_width_resolver_rtf() works correctly", {
+
+  tw <- function(x) {
+    paste0(x, "tw")
+  }
+
+  page_body_width_portrait <- 12240L - 1440L - 1440L
+
+  expect_error(
+    col_width_resolver_rtf(
+      page_body_width = page_body_width_portrait,
+      table_width = "-1tw",
+      col_widths = "1tw",
+      n_cols = 1
+    )
+  )
+
+  expect_error(
+    col_width_resolver_rtf(
+      page_body_width = page_body_width_portrait,
+      table_width = "1tw",
+      col_widths = "-1tw",
+      n_cols = 1
+    )
+  )
+
+  expect_identical(
+    col_width_resolver_rtf(
+      page_body_width = page_body_width_portrait,
+      table_width = "auto",
+      col_widths = NULL,
+      n_cols = 3
+    ),
+    c(3120, 3120, 3120)
+  )
+
+  expect_identical(
+    col_width_resolver_rtf(
+      page_body_width = page_body_width_portrait,
+      table_width = "1000tw",
+      col_widths = NULL,
+      n_cols = 3
+    ),
+    c(333, 333, 333)
+  )
+
+  expect_identical(
+    col_width_resolver_rtf(
+      page_body_width = page_body_width_portrait,
+      table_width = tw(900),
+      col_widths = tw(c(200, 200, 200)),
+      n_cols = 3
+    ),
+    c(200, 200, 200)
+  )
+
+  expect_identical(
+    col_width_resolver_rtf(
+      page_body_width = page_body_width_portrait,
+      table_width = tw(1200),
+      col_widths = pct(c(100, 200, 300)),
+      n_cols = 3
+    ),
+    c(200, 400, 600)
+  )
+
+  expect_identical(
+    col_width_resolver_rtf(
+      page_body_width = page_body_width_portrait,
+      table_width = tw(1200),
+      col_widths = c(pct(c(100, 200, 300)), "", ""),
+      n_cols = 5
+    ),
+    c(200, 400, 600, 0, 0)
+  )
+
+  expect_identical(
+    col_width_resolver_rtf(
+      page_body_width = page_body_width_portrait,
+      table_width = tw(1200),
+      col_widths = c(pct(c(10, 20, 30)), "", ""),
+      n_cols = 5
+    ),
+    c(120, 240, 360, 240, 240)
+  )
+
+  expect_identical(
+    col_width_resolver_rtf(
+      page_body_width = page_body_width_portrait,
+      table_width = tw(1000),
+      col_widths = c("500tw", "50%", "50%"),
+      n_cols = 3
+    ),
+    c(500, 250, 250)
+  )
+
+  expect_identical(
+    col_width_resolver_rtf(
+      page_body_width = page_body_width_portrait,
+      table_width = tw(1000),
+      col_widths = c("500tw", "10%", "10%"),
+      n_cols = 3
+    ),
+    c(500, 250, 250)
+  )
+
+  expect_identical(
+    col_width_resolver_rtf(
+      page_body_width = page_body_width_portrait,
+      table_width = tw(1000),
+      col_widths = c("500tw", "10%", "10%", "", ""),
+      n_cols = 5
+    ),
+    c(500, 100, 100, 150, 150)
+  )
+
+  expect_identical(
+    col_width_resolver_rtf(
+      page_body_width = page_body_width_portrait,
+      table_width = tw(1000),
+      col_widths = c("500tw", "25%", "25%", "", ""),
+      n_cols = 5
+    ),
+    c(500, 250, 250, 0, 0)
+  )
+
+  expect_identical(
+    col_width_resolver_rtf(
+      page_body_width = page_body_width_portrait,
+      table_width = tw(100),
+      col_widths = rep_len("50tw", 3),
+      n_cols = 3
+    ),
+    c(50, 50, 50)
+  )
+
+  expect_identical(
+    col_width_resolver_rtf(
+      page_body_width = page_body_width_portrait,
+      table_width = tw(100),
+      col_widths = rep_len("0%", 3),
+      n_cols = 3
+    ),
+    c(0, 0, 0)
+  )
+})
+
+test_that("parse_length_str() works correctly", {
+
+  lengths_vec_list <-
+    list(
+      c("20px", "20px", "20px", "20px"),
+      c("20px", "20px", "", ""),
+      c("20%", "20%", "30%", "40%"),
+      c("", "", "", ""),
+      c("20px", "20%", "20px", "20%"),
+      c("20%", "20px", "", "30px"),
+      c("1.2in", "230pt", "3.03cm", "502.1mm"),
+      c("400tw", "", "20%", "301mm")
+    )
+
+  value_vec_list <-
+    list(
+      c(20, 20, 20, 20),
+      c(20, 20, NA, NA),
+      c(20, 20, 30, 40),
+      rep(NA_real_, 4),
+      c(20, 20, 20, 20),
+      c(20, 20, NA, 30),
+      c(1.2, 230, 3.03, 502.1),
+      c(400, NA, 20, 301)
+    )
+
+  unit_vec_list <-
+    list(
+      c("px", "px", "px", "px"),
+      c("px", "px", NA, NA),
+      c("%", "%", "%", "%"),
+      rep(NA_character_, 4),
+      c("px", "%", "px", "%"),
+      c("%", "px", NA, "px"),
+      c("in", "pt", "cm", "mm"),
+      c("tw", NA, "%", "mm")
+    )
+
+  for (i in seq_along(lengths_vec_list)) {
+
+    lengths_tbl <-
+      parse_length_str(
+        lengths_vec = lengths_vec_list[[i]],
+        allow_negative = FALSE
+      )
+
+    expect_type(lengths_tbl, "list")
+    expect_s3_class(lengths_tbl, "data.frame")
+    expect_equal(lengths_tbl[["value"]], value_vec_list[[i]])
+    expect_equal(lengths_tbl[["unit"]], unit_vec_list[[i]])
+  }
+
+  expect_error(
+    parse_length_str(
+      lengths_vec = "-6px",
+      allow_negative = FALSE
+    )
+  )
+
+  parse_length_str(
+    lengths_vec = "-6px",
+    allow_negative = TRUE
+  ) %>%
+    {
+      expect_equal(.[["value"]], -6)
+      expect_equal(.[["unit"]], "px")
+    }
+
+  parse_length_str(
+    lengths_vec = character(0L),
+    allow_negative = TRUE
+  ) %>%
+    {
+      expect_type(., "list")
+      expect_s3_class(., "data.frame")
+      expect_equal(nrow(.), 0)
+    }
+
+  # `parse_length_str()` doesn't check for valid units
+  # so anything that fits the `(%|[a-z]+)` will work
+  parse_length_str(
+    lengths_vec = "6.234points"
+  ) %>%
+    {
+      expect_equal(.[["value"]], 6.234)
+      expect_equal(.[["unit"]], "points")
+    }
+
+  # NA values cannot be used
+  expect_error(
+    parse_length_str(
+      lengths_vec = NA_character_,
+      allow_negative = TRUE
+    )
+  )
+})
+
+test_that("abs_len_to_twips() works correctly", {
+
+  lengths_vec_list <-
+    list(
+      c("20px", "20px", "20px", "20px"),
+      c("20px", "20px", "", ""),
+      c("20%", "20%", "30%", "40%"),
+      c("", "", "", ""),
+      c("20px", "20%", "20px", "20%"),
+      c("20%", "20px", "", "30px"),
+      c("1.2in", "230pt", "3.03cm", "502.1mm"),
+      c("400tw", "", "20%", "301mm")
+    )
+
+  value_vec_list <-
+    list(
+      rep(300, 4),
+      c(300, 300, NA, NA),
+      c(20, 20, 30, 40),
+      rep(NA_real_, 4),
+      c(300, 20, 300, 20),
+      c(20, 300, NA, 450),
+      c(1728, 4600, 1717.795, 28465.51),
+      c(400, NA, 20, 17064.57)
+    )
+
+  unit_vec_list <-
+    list(
+      rep("tw", 4),
+      c("tw", "tw", NA, NA),
+      rep("%", 4),
+      rep(NA_character_, 4),
+      c("tw", "%", "tw", "%"),
+      c("%", "tw", NA, "tw"),
+      rep("tw", 4),
+      c("tw", NA, "%", "tw")
+    )
+
+  for (i in seq_along(lengths_vec_list)) {
+
+    lengths_tbl <-
+      abs_len_to_twips(parse_length_str(lengths_vec_list[[i]]))
+
+    expect_type(lengths_tbl, "list")
+    expect_s3_class(lengths_tbl, "data.frame")
+    expect_equal(lengths_tbl[["value"]], value_vec_list[[i]], tolerance = 0.1)
+    expect_equal(lengths_tbl[["unit"]], unit_vec_list[[i]])
+  }
+})
diff --git a/tests/testthat/test-rtf_column_widths.R b/tests/testthat/test-rtf_column_widths.R
deleted file mode 100644
index b759fe96ec..0000000000
--- a/tests/testthat/test-rtf_column_widths.R
+++ /dev/null
@@ -1,293 +0,0 @@
-test_that("col_width_resolver_rtf() works correctly", {
-
-  tw <- function(x) {
-    paste0(x, "tw")
-  }
-
-  page_body_width_portrait <- 12240L - 1440L - 1440L
-
-  expect_error(
-    col_width_resolver_rtf(
-      page_body_width = page_body_width_portrait,
-      table_width = "-1tw",
-      col_widths = "1tw",
-      n_cols = 1
-    )
-  )
-
-  expect_error(
-    col_width_resolver_rtf(
-      page_body_width = page_body_width_portrait,
-      table_width = "1tw",
-      col_widths = "-1tw",
-      n_cols = 1
-    )
-  )
-
-  expect_identical(
-    col_width_resolver_rtf(
-      page_body_width = page_body_width_portrait,
-      table_width = "auto",
-      col_widths = NULL,
-      n_cols = 3
-    ),
-    c(3120, 3120, 3120)
-  )
-
-  expect_identical(
-    col_width_resolver_rtf(
-      page_body_width = page_body_width_portrait,
-      table_width = "1000tw",
-      col_widths = NULL,
-      n_cols = 3
-    ),
-    c(333, 333, 333)
-  )
-
-  expect_identical(
-    col_width_resolver_rtf(
-      page_body_width = page_body_width_portrait,
-      table_width = tw(900),
-      col_widths = tw(c(200, 200, 200)),
-      n_cols = 3
-    ),
-    c(200, 200, 200)
-  )
-
-  expect_identical(
-    col_width_resolver_rtf(
-      page_body_width = page_body_width_portrait,
-      table_width = tw(1200),
-      col_widths = pct(c(100, 200, 300)),
-      n_cols = 3
-    ),
-    c(200, 400, 600)
-  )
-
-  expect_identical(
-    col_width_resolver_rtf(
-      page_body_width = page_body_width_portrait,
-      table_width = tw(1200),
-      col_widths = c(pct(c(100, 200, 300)), "", ""),
-      n_cols = 5
-    ),
-    c(200, 400, 600, 0, 0)
-  )
-
-  expect_identical(
-    col_width_resolver_rtf(
-      page_body_width = page_body_width_portrait,
-      table_width = tw(1200),
-      col_widths = c(pct(c(10, 20, 30)), "", ""),
-      n_cols = 5
-    ),
-    c(120, 240, 360, 240, 240)
-  )
-
-  expect_identical(
-    col_width_resolver_rtf(
-      page_body_width = page_body_width_portrait,
-      table_width = tw(1000),
-      col_widths = c("500tw", "50%", "50%"),
-      n_cols = 3
-    ),
-    c(500, 250, 250)
-  )
-
-  expect_identical(
-    col_width_resolver_rtf(
-      page_body_width = page_body_width_portrait,
-      table_width = tw(1000),
-      col_widths = c("500tw", "10%", "10%"),
-      n_cols = 3
-    ),
-    c(500, 250, 250)
-  )
-
-  expect_identical(
-    col_width_resolver_rtf(
-      page_body_width = page_body_width_portrait,
-      table_width = tw(1000),
-      col_widths = c("500tw", "10%", "10%", "", ""),
-      n_cols = 5
-    ),
-    c(500, 100, 100, 150, 150)
-  )
-
-  expect_identical(
-    col_width_resolver_rtf(
-      page_body_width = page_body_width_portrait,
-      table_width = tw(1000),
-      col_widths = c("500tw", "25%", "25%", "", ""),
-      n_cols = 5
-    ),
-    c(500, 250, 250, 0, 0)
-  )
-
-  expect_identical(
-    col_width_resolver_rtf(
-      page_body_width = page_body_width_portrait,
-      table_width = tw(100),
-      col_widths = rep_len("50tw", 3),
-      n_cols = 3
-    ),
-    c(50, 50, 50)
-  )
-
-  expect_identical(
-    col_width_resolver_rtf(
-      page_body_width = page_body_width_portrait,
-      table_width = tw(100),
-      col_widths = rep_len("0%", 3),
-      n_cols = 3
-    ),
-    c(0, 0, 0)
-  )
-})
-
-test_that("parse_length_str() works correctly", {
-
-  lengths_vec_list <-
-    list(
-      c("20px", "20px", "20px", "20px"),
-      c("20px", "20px", "", ""),
-      c("20%", "20%", "30%", "40%"),
-      c("", "", "", ""),
-      c("20px", "20%", "20px", "20%"),
-      c("20%", "20px", "", "30px"),
-      c("1.2in", "230pt", "3.03cm", "502.1mm"),
-      c("400tw", "", "20%", "301mm")
-    )
-
-  value_vec_list <-
-    list(
-      c(20, 20, 20, 20),
-      c(20, 20, NA, NA),
-      c(20, 20, 30, 40),
-      rep(NA_real_, 4),
-      c(20, 20, 20, 20),
-      c(20, 20, NA, 30),
-      c(1.2, 230, 3.03, 502.1),
-      c(400, NA, 20, 301)
-    )
-
-  unit_vec_list <-
-    list(
-      c("px", "px", "px", "px"),
-      c("px", "px", NA, NA),
-      c("%", "%", "%", "%"),
-      rep(NA_character_, 4),
-      c("px", "%", "px", "%"),
-      c("%", "px", NA, "px"),
-      c("in", "pt", "cm", "mm"),
-      c("tw", NA, "%", "mm")
-    )
-
-  for (i in seq_along(lengths_vec_list)) {
-
-    lengths_tbl <-
-      parse_length_str(
-        lengths_vec = lengths_vec_list[[i]],
-        allow_negative = FALSE
-      )
-
-    expect_type(lengths_tbl, "list")
-    expect_s3_class(lengths_tbl, "data.frame")
-    expect_equal(lengths_tbl[["value"]], value_vec_list[[i]])
-    expect_equal(lengths_tbl[["unit"]], unit_vec_list[[i]])
-  }
-
-  expect_error(
-    parse_length_str(
-      lengths_vec = "-6px",
-      allow_negative = FALSE
-    )
-  )
-
-  parse_length_str(
-    lengths_vec = "-6px",
-    allow_negative = TRUE
-  ) %>%
-    {
-      expect_equal(.[["value"]], -6)
-      expect_equal(.[["unit"]], "px")
-    }
-
-  parse_length_str(
-    lengths_vec = character(0L),
-    allow_negative = TRUE
-  ) %>%
-    {
-      expect_type(., "list")
-      expect_s3_class(., "data.frame")
-      expect_equal(nrow(.), 0)
-    }
-
-  # `parse_length_str()` doesn't check for valid units
-  # so anything that fits the `(%|[a-z]+)` will work
-  parse_length_str(
-    lengths_vec = "6.234points"
-  ) %>%
-    {
-      expect_equal(.[["value"]], 6.234)
-      expect_equal(.[["unit"]], "points")
-    }
-
-  # NA values cannot be used
-  expect_error(
-    parse_length_str(
-      lengths_vec = NA_character_,
-      allow_negative = TRUE
-    )
-  )
-})
-
-test_that("abs_len_to_twips() works correctly", {
-
-  lengths_vec_list <-
-    list(
-      c("20px", "20px", "20px", "20px"),
-      c("20px", "20px", "", ""),
-      c("20%", "20%", "30%", "40%"),
-      c("", "", "", ""),
-      c("20px", "20%", "20px", "20%"),
-      c("20%", "20px", "", "30px"),
-      c("1.2in", "230pt", "3.03cm", "502.1mm"),
-      c("400tw", "", "20%", "301mm")
-    )
-
-  value_vec_list <-
-    list(
-      rep(300, 4),
-      c(300, 300, NA, NA),
-      c(20, 20, 30, 40),
-      rep(NA_real_, 4),
-      c(300, 20, 300, 20),
-      c(20, 300, NA, 450),
-      c(1728, 4600, 1717.795, 28465.51),
-      c(400, NA, 20, 17064.57)
-    )
-
-  unit_vec_list <-
-    list(
-      rep("tw", 4),
-      c("tw", "tw", NA, NA),
-      rep("%", 4),
-      rep(NA_character_, 4),
-      c("tw", "%", "tw", "%"),
-      c("%", "tw", NA, "tw"),
-      rep("tw", 4),
-      c("tw", NA, "%", "tw")
-    )
-
-  for (i in seq_along(lengths_vec_list)) {
-
-    lengths_tbl <-
-      abs_len_to_twips(parse_length_str(lengths_vec_list[[i]]))
-
-    expect_type(lengths_tbl, "list")
-    expect_s3_class(lengths_tbl, "data.frame")
-    expect_equal(lengths_tbl[["value"]], value_vec_list[[i]], tolerance = 0.1)
-    expect_equal(lengths_tbl[["unit"]], unit_vec_list[[i]])
-  }
-})

From f0bb9f9c81dff4cddd32bf65f8a6f6dd5b33b0e5 Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Fri, 12 Jul 2024 09:01:21 -0400
Subject: [PATCH 25/28] Move `fmt_number()` and `fmt_integer()` into own file.

---
 R/fmt_number.R  | 976 ++++++++++++++++++++++++++++++++++++++++++++++++
 R/format_data.R | 953 ----------------------------------------------
 2 files changed, 976 insertions(+), 953 deletions(-)
 create mode 100644 R/fmt_number.R

diff --git a/R/fmt_number.R b/R/fmt_number.R
new file mode 100644
index 0000000000..74ea20c41f
--- /dev/null
+++ b/R/fmt_number.R
@@ -0,0 +1,976 @@
+#------------------------------------------------------------------------------#
+#
+#                /$$
+#               | $$
+#     /$$$$$$  /$$$$$$
+#    /$$__  $$|_  $$_/
+#   | $$  \ $$  | $$
+#   | $$  | $$  | $$ /$$
+#   |  $$$$$$$  |  $$$$/
+#    \____  $$   \___/
+#    /$$  \ $$
+#   |  $$$$$$/
+#    \______/
+#
+#  This file is part of the 'rstudio/gt' project.
+#
+#  Copyright (c) 2018-2024 gt authors
+#
+#  For full copyright and license information, please look at
+#  https://gt.rstudio.com/LICENSE.html
+#
+#------------------------------------------------------------------------------#
+
+
+#' Format numeric values
+#'
+#' @description
+#'
+#' With numeric values in a **gt** table, we can perform number-based
+#' formatting so that the targeted values are rendered with a higher
+#' consideration for tabular presentation. Furthermore, there is finer control
+#' over numeric formatting with the following options:
+#'
+#' - decimals: choice of the number of decimal places, option to drop
+#' trailing zeros, and a choice of the decimal symbol
+#' - digit grouping separators: options to enable/disable digit separators
+#' and provide a choice of separator symbol
+#' - scaling: we can choose to scale targeted values by a multiplier value
+#' - large-number suffixing: larger figures (thousands, millions, etc.) can
+#' be autoscaled and decorated with the appropriate suffixes
+#' - pattern: option to use a text pattern for decoration of the formatted
+#' values
+#' - locale-based formatting: providing a locale ID will result in number
+#' formatting specific to the chosen locale
+#'
+#' @param data *The gt table data object*
+#'
+#'   `obj:<gt_tbl>` // **required**
+#'
+#'   This is the **gt** table object that is commonly created through use of the
+#'   [gt()] function.
+#'
+#' @param columns *Columns to target*
+#'
+#'   `<column-targeting expression>` // *default:* `everything()`
+#'
+#'   Can either be a series of column names provided in `c()`, a vector of
+#'   column indices, or a select helper function (e.g. [starts_with()],
+#'   [ends_with()], [contains()], [matches()], [num_range()] and [everything()]).
+#'
+#' @param rows *Rows to target*
+#'
+#'   `<row-targeting expression>` // *default:* `everything()`
+#'
+#'   In conjunction with `columns`, we can specify which of their rows should
+#'   undergo formatting. The default [everything()] results in all rows in
+#'   `columns` being formatted. Alternatively, we can supply a vector of row
+#'   captions within `c()`, a vector of row indices, or a select helper
+#'   function (e.g. [starts_with()], [ends_with()], [contains()], [matches()],
+#'   [num_range()], and [everything()]). We can also use expressions to filter
+#'   down to the rows we need (e.g., `[colname_1] > 100 & [colname_2] < 50`).
+#'
+#' @param decimals *Number of decimal places*
+#'
+#'   `scalar<numeric|integer>(val>=0)` // *default:* `2`
+#'
+#'   This corresponds to the exact number of decimal places to use. A value
+#'   such as `2.34` can, for example, be formatted with `0` decimal places and
+#'   it would result in `"2"`. With `4` decimal places, the formatted value
+#'   becomes `"2.3400"`.
+#'
+#' @param n_sigfig *Number of significant figures*
+#'
+#'   `scalar<numeric|integer>(val>=1)` // *default:* `NULL` (`optional`)
+#'
+#'   A option to format numbers to *n* significant figures. By default, this is
+#'   `NULL` and thus number values will be formatted according to the number of
+#'   decimal places set via `decimals`. If opting to format according to the
+#'   rules of significant figures, `n_sigfig` must be a number greater than or
+#'   equal to `1`. Any values passed to the `decimals` and `drop_trailing_zeros`
+#'   arguments will be ignored.
+#'
+#' @param drop_trailing_zeros *Drop any trailing zeros*
+#'
+#'   `scalar<logical>` // *default:* `FALSE`
+#'
+#'   A logical value that allows for removal of trailing zeros (those redundant
+#'   zeros after the decimal mark).
+#'
+#' @param drop_trailing_dec_mark *Drop the trailing decimal mark*
+#'
+#'   `scalar<logical>` // *default:* `TRUE`
+#'
+#'   A logical value that determines whether decimal marks should always appear
+#'   even if there are no decimal digits to display after formatting (e.g., `23`
+#'   becomes `23.` if `FALSE`). By default trailing decimal marks are not shown.
+#'
+#' @param use_seps *Use digit group separators*
+#'
+#'   `scalar<logical>` // *default:* `TRUE`
+#'
+#'   An option to use digit group separators. The type of digit group separator
+#'   is set by `sep_mark` and overridden if a locale ID is provided to `locale`.
+#'   This setting is `TRUE` by default.
+#'
+#' @param accounting *Use accounting style*
+#'
+#'   `scalar<logical>` // *default:* `FALSE`
+#'
+#'   An option to use accounting style for values. Normally, negative values
+#'   will be shown with a minus sign but using accounting style will instead put
+#'   any negative values in parentheses.
+#'
+#' @param scale_by *Scale values by a fixed multiplier*
+#'
+#'   `scalar<numeric|integer>` // *default:* `1`
+#'
+#'   All numeric values will be multiplied by the `scale_by` value before
+#'   undergoing formatting. Since the `default` value is `1`, no values will be
+#'   changed unless a different multiplier value is supplied. This value will be
+#'   ignored if using any of the `suffixing` options (i.e., where `suffixing` is
+#'   not set to `FALSE`).
+#'
+#' @param suffixing *Specification for large-number suffixing*
+#'
+#'   `scalar<logical>|vector<character>` // *default:* `FALSE`
+#'
+#'   The `suffixing` option allows us to scale and apply suffixes to larger
+#'   numbers (e.g., `1924000` can be transformed to `1.92M`). This option can
+#'   accept a logical value, where `FALSE` (the default) will not perform this
+#'   transformation and `TRUE` will apply thousands (`"K"`), millions (`"M"`),
+#'   billions (`"B"`), and trillions (`"T"`) suffixes after automatic value
+#'   scaling.
+#'
+#'   We can alternatively provide a character vector that serves as a
+#'   specification for which symbols are to used for each of the value ranges.
+#'   These preferred symbols will replace the defaults (e.g.,
+#'   `c("k", "Ml", "Bn", "Tr")` replaces `"K"`, `"M"`, `"B"`, and `"T"`).
+#'
+#'   Including `NA` values in the vector will ensure that the particular range
+#'   will either not be included in the transformation (e.g.,
+#'   `c(NA, "M", "B", "T")` won't modify numbers at all in the thousands range)
+#'   or the range will inherit a previous suffix (e.g., with
+#'   `c("K", "M", NA, "T")`, all numbers in the range of millions and billions
+#'   will be in terms of millions).
+#'
+#'   Any use of `suffixing` (where it is not set expressly as `FALSE`) means
+#'   that any value provided to `scale_by` will be ignored.
+#'
+#'   If using `system = "ind"` then the default suffix set provided by
+#'   `suffixing = TRUE` will be the equivalent of `c(NA, "L", "Cr")`. This
+#'   doesn't apply suffixes to the thousands range, but does express values in
+#'   *lakhs* and *crores*.
+#'
+#' @param pattern *Specification of the formatting pattern*
+#'
+#'   `scalar<character>` // *default:* `"{x}"`
+#'
+#'   A formatting pattern that allows for decoration of the formatted value. The
+#'   formatted value is represented by the `{x}` (which can be used multiple
+#'   times, if needed) and all other characters will be interpreted as string
+#'   literals.
+#'
+#' @param sep_mark *Separator mark for digit grouping*
+#'
+#'   `scalar<character>` // *default:* `","`
+#'
+#'   The string to use as a separator between groups of digits. For example,
+#'   using `sep_mark = ","` with a value of `1000` would result in a formatted
+#'   value of `"1,000"`. This argument is ignored if a `locale` is supplied
+#'   (i.e., is not `NULL`).
+#'
+#' @param dec_mark *Decimal mark*
+#'
+#'   `scalar<character>` // *default:* `"."`
+#'
+#'   The string to be used as the decimal mark. For example, using
+#'   `dec_mark = ","` with the value `0.152` would result in a formatted value
+#'   of `"0,152"`). This argument is ignored if a `locale` is supplied (i.e., is
+#'   not `NULL`).
+#'
+#' @param force_sign *Forcing the display of a positive sign*
+#'
+#'   `scalar<logical>` // *default:* `FALSE`
+#'
+#'   Should the positive sign be shown for positive values (effectively showing
+#'   a sign for all values except zero)? If so, use `TRUE` for this option. The
+#'   default is `FALSE`, where only negative numbers will display a minus sign.
+#'   This option is disregarded when using accounting notation with
+#'   `accounting = TRUE`.
+#'
+#' @param system *Numbering system for grouping separators*
+#'
+#'   `singl-kw:[intl|ind]` // *default:* `"intl"`
+#'
+#'   The international numbering system (keyword: `"intl"`) is widely used and
+#'   its grouping separators (i.e., `sep_mark`) are always separated by three
+#'   digits. The alternative system, the Indian numbering system (keyword:
+#'   `"ind"`), uses grouping separators that correspond to thousand, lakh,
+#'   crore, and higher quantities.
+#'
+#' @param locale *Locale identifier*
+#'
+#'   `scalar<character>` // *default:* `NULL` (`optional`)
+#'
+#'   An optional locale identifier that can be used for formatting values
+#'   according the locale's rules. Examples include `"en"` for English (United
+#'   States) and `"fr"` for French (France). We can call [info_locales()] for a
+#'   useful reference for all of the locales that are supported. A locale ID can
+#'   be also set in the initial [gt()] function call (where it would be used
+#'   automatically by any function with a `locale` argument) but a `locale`
+#'   value provided here will override that global locale.
+#'
+#' @return An object of class `gt_tbl`.
+#'
+#' @section Compatibility of formatting function with data values:
+#'
+#' `fmt_number()` is compatible with body cells that are of the `"numeric"` or
+#' `"integer"` types. Any other types of body cells are ignored during
+#' formatting. This is to say that cells of incompatible data types may be
+#' targeted, but there will be no attempt to format them.
+#'
+#' @section Targeting cells with `columns` and `rows`:
+#'
+#' Targeting of values is done through `columns` and additionally by `rows` (if
+#' nothing is provided for `rows` then entire columns are selected). The
+#' `columns` argument allows us to target a subset of cells contained in the
+#' resolved columns. We say resolved because aside from declaring column names
+#' in `c()` (with bare column names or names in quotes) we can use
+#' **tidyselect**-style expressions. This can be as basic as supplying a select
+#' helper like `starts_with()`, or, providing a more complex incantation like
+#'
+#' `where(~ is.numeric(.x) && max(.x, na.rm = TRUE) > 1E6)`
+#'
+#' which targets numeric columns that have a maximum value greater than
+#' 1,000,000 (excluding any `NA`s from consideration).
+#'
+#' By default all columns and rows are selected (with the `everything()`
+#' defaults). Cell values that are incompatible with a given formatting function
+#' will be skipped over, like `character` values and numeric `fmt_*()`
+#' functions. So it's safe to select all columns with a particular formatting
+#' function (only those values that can be formatted will be formatted), but,
+#' you may not want that. One strategy is to format the bulk of cell values with
+#' one formatting function and then constrain the columns for later passes with
+#' other types of formatting (the last formatting done to a cell is what you get
+#' in the final output).
+#'
+#' Once the columns are targeted, we may also target the `rows` within those
+#' columns. This can be done in a variety of ways. If a stub is present, then we
+#' potentially have row identifiers. Those can be used much like column names in
+#' the `columns`-targeting scenario. We can use simpler **tidyselect**-style
+#' expressions (the select helpers should work well here) and we can use quoted
+#' row identifiers in `c()`. It's also possible to use row indices (e.g.,
+#' `c(3, 5, 6)`) though these index values must correspond to the row numbers of
+#' the input data (the indices won't necessarily match those of rearranged rows
+#' if row groups are present). One more type of expression is possible, an
+#' expression that takes column values (can involve any of the available columns
+#' in the table) and returns a logical vector. This is nice if you want to base
+#' formatting on values in the column or another column, or, you'd like to use a
+#' more complex predicate expression.
+#'
+#' @section Compatibility of arguments with the `from_column()` helper function:
+#'
+#' [from_column()] can be used with certain arguments of `fmt_number()` to
+#' obtain varying parameter values from a specified column within the table.
+#' This means that each row could be formatted a little bit differently. These
+#' arguments provide support for [from_column()]:
+#'
+#' - `decimals`
+#' - `n_sigfig`
+#' - `drop_trailing_zeros`
+#' - `drop_trailing_dec_mark`
+#' - `use_seps`
+#' - `accounting`
+#' - `scale_by`
+#' - `suffixing`
+#' - `pattern`
+#' - `sep_mark`
+#' - `dec_mark`
+#' - `force_sign`
+#' - `system`
+#' - `locale`
+#'
+#' Please note that for all of the aforementioned arguments, a [from_column()]
+#' call needs to reference a column that has data of the correct type (this is
+#' different for each argument). Additional columns for parameter values can be
+#' generated with [cols_add()] (if not already present). Columns that contain
+#' parameter data can also be hidden from final display with [cols_hide()].
+#' Finally, there is no limitation to how many arguments the [from_column()]
+#' helper is applied so long as the arguments belong to this closed set.
+#'
+#' @section Adapting output to a specific `locale`:
+#'
+#' This formatting function can adapt outputs according to a provided `locale`
+#' value. Examples include `"en"` for English (United States) and `"fr"` for
+#' French (France). The use of a valid locale ID here means separator and
+#' decimal marks will be correct for the given locale. Should any values be
+#' provided in `sep_mark` or `dec_mark`, they will be overridden by the locale's
+#' preferred values.
+#'
+#' Note that a `locale` value provided here will override any global locale
+#' setting performed in [gt()]'s own `locale` argument (it is settable there as
+#' a value received by all other functions that have a `locale` argument). As a
+#' useful reference on which locales are supported, we can call [info_locales()]
+#' to view an info table.
+#'
+#' @section Examples:
+#'
+#' Let's use the [`exibble`] dataset to create a **gt** table. With
+#' `fmt_number()`, we'll format the `num` column to have three decimal
+#' places (with `decimals = 3`) and omit the use of digit separators (with
+#' `use_seps = FALSE`).
+#'
+#' ```r
+#' exibble |>
+#'   gt() |>
+#'   fmt_number(
+#'     columns = num,
+#'     decimals = 3,
+#'     use_seps = FALSE
+#'   )
+#' ```
+#'
+#' \if{html}{\out{
+#' `r man_get_image_tag(file = "man_fmt_number_1.png")`
+#' }}
+#'
+#' Use a modified version of the [`countrypops`] dataset to create a **gt**
+#' table with row labels. Format all columns to use large-number suffixing
+#' (e.g., where `"10,000,000"` becomes `"10M"`) with the `suffixing = TRUE`
+#' option.
+#'
+#' ```r
+#' countrypops |>
+#'   dplyr::select(country_code_3, year, population) |>
+#'   dplyr::filter(country_code_3 %in% c("CHN", "IND", "USA", "PAK", "IDN")) |>
+#'   dplyr::filter(year > 1975 & year %% 5 == 0) |>
+#'   tidyr::spread(year, population) |>
+#'   dplyr::arrange(desc(`2015`)) |>
+#'   gt(rowname_col = "country_code_3") |>
+#'   fmt_number(suffixing = TRUE)
+#' ```
+#'
+#' \if{html}{\out{
+#' `r man_get_image_tag(file = "man_fmt_number_2.png")`
+#' }}
+#'
+#' In a variation of the previous table, we can combine large-number suffixing
+#' with a declaration of the number of significant digits to use. With things
+#' like population figures, `n_sigfig = 3` is a very good option.
+#'
+#' ```r
+#' countrypops |>
+#'   dplyr::select(country_code_3, year, population) |>
+#'   dplyr::filter(country_code_3 %in% c("CHN", "IND", "USA", "PAK", "IDN")) |>
+#'   dplyr::filter(year > 1975 & year %% 5 == 0) |>
+#'   tidyr::spread(year, population) |>
+#'   dplyr::arrange(desc(`2015`)) |>
+#'   gt(rowname_col = "country_code_3") |>
+#'   fmt_number(suffixing = TRUE, n_sigfig = 3)
+#' ```
+#'
+#' \if{html}{\out{
+#' `r man_get_image_tag(file = "man_fmt_number_3.png")`
+#' }}
+#'
+#' There can be cases where you want to show numbers to a large number of
+#' decimal places but also drop the unnecessary trailing zeros for low-precision
+#' values. Let's take a portion of the [`towny`] dataset and format the
+#' `latitude` and `longitude` columns with `fmt_number()`. We'll have up to 5
+#' digits displayed as decimal values, but we'll also unconditionally drop any
+#' runs of trailing zeros in the decimal part with `drop_trailing_zeros = TRUE`.
+#'
+#' ```r
+#' towny |>
+#'   dplyr::select(name, latitude, longitude) |>
+#'   dplyr::slice_head(n = 10) |>
+#'   gt() |>
+#'   fmt_number(decimals = 5, drop_trailing_zeros = TRUE) |>
+#'   cols_merge(columns = -name, pattern = "{1}, {2}") |>
+#'   cols_label(
+#'     name ~ "Municipality",
+#'     latitude = "Location"
+#'   )
+#' ```
+#'
+#' \if{html}{\out{
+#' `r man_get_image_tag(file = "man_fmt_number_4.png")`
+#' }}
+#'
+#' Another strategy for dealing with precision of decimals is to have a separate
+#' column of values that specify how many decimal digits to retain. Such a
+#' column can be added via [cols_add()] or it can be part of the input table for
+#' [gt()]. With that column available, it can be referenced in the `decimals`
+#' argument with [from_column()]. This approach yields a display of coordinate
+#' values that reflects the measurement precision of each value.
+#'
+#' ```r
+#' towny |>
+#'   dplyr::select(name, latitude, longitude) |>
+#'   dplyr::slice_head(n = 10) |>
+#'   gt() |>
+#'   cols_add(dec_digits = c(1, 2, 2, 5, 5, 2, 3, 2, 3, 3)) |>
+#'   fmt_number(decimals = from_column(column = "dec_digits")) |>
+#'   cols_merge(columns = -name, pattern = "{1}, {2}") |>
+#'   cols_label(
+#'     name ~ "Municipality",
+#'     latitude = "Location"
+#'   )
+#' ```
+#'
+#' \if{html}{\out{
+#' `r man_get_image_tag(file = "man_fmt_number_5.png")`
+#' }}
+#'
+#' @family data formatting functions
+#' @section Function ID:
+#' 3-1
+#'
+#' @section Function Introduced:
+#' `v0.2.0.5` (March 31, 2020)
+#'
+#' @seealso
+#' The integer-formatting function (format rounded values (i.e., no decimals shown and
+#'input values are rounded as necessary): [fmt_integer()].
+#'
+#' The vector-formatting version of this function: [vec_fmt_number()]
+#'
+#' @export
+fmt_number <- function(
+    data,
+    columns = everything(),
+    rows = everything(),
+    decimals = 2,
+    n_sigfig = NULL,
+    drop_trailing_zeros = FALSE,
+    drop_trailing_dec_mark = TRUE,
+    use_seps = TRUE,
+    accounting = FALSE,
+    scale_by = 1.0,
+    suffixing = FALSE,
+    pattern = "{x}",
+    sep_mark = ",",
+    dec_mark = ".",
+    force_sign = FALSE,
+    system = c("intl", "ind"),
+    locale = NULL
+) {
+
+  # Perform input object validation
+  stop_if_not_gt_tbl(data = data)
+
+  #
+  # Begin support for `from_column()` objects passed to compatible arguments
+  #
+
+  # Supports parameters:
+  #
+  # - decimals
+  # - n_sigfig
+  # - drop_trailing_zeros
+  # - drop_trailing_dec_mark
+  # - use_seps
+  # - accounting
+  # - scale_by
+  # - suffixing
+  # - pattern
+  # - sep_mark
+  # - dec_mark
+  # - force_sign
+  # - system
+  # - locale
+
+  arg_vals <-
+    mget(
+      get_arg_names(
+        function_name = "fmt_number",
+        all_args_except = c("data", "columns", "rows")
+      )
+    )
+  # Assume that if decimals = 0, function = fmt_integer, fmt_number otherwise
+  if (identical(decimals, 0)) {
+    fn_call <- call("fmt_integer")
+  } else {
+    fn_call <- call("fmt_number")
+  }
+
+  if (args_have_gt_column_obj(arg_vals = arg_vals)) {
+
+    # Resolve the row numbers using `resolve_vars()`
+    resolved_rows_idx <-
+      resolve_rows_i(
+        expr = {{ rows }},
+        data = data,
+        call = fn_call
+      )
+
+    param_tbl <-
+      generate_param_tbl(
+        data = data,
+        arg_vals = arg_vals,
+        resolved_rows_idx = resolved_rows_idx
+      )
+
+    for (i in seq_len(nrow(param_tbl))) {
+
+      p_i <- as.list(param_tbl[i, ])
+
+      data <-
+        fmt_number(
+          data = data,
+          columns = {{ columns }},
+          rows = resolved_rows_idx[i],
+          decimals = p_i$decimals %||% decimals,
+          n_sigfig = p_i$n_sigfig %||% n_sigfig,
+          drop_trailing_zeros = p_i$drop_trailing_zeros %||% drop_trailing_zeros,
+          drop_trailing_dec_mark = p_i$drop_trailing_dec_mark %||% drop_trailing_dec_mark,
+          use_seps = p_i$use_seps %||% use_seps,
+          accounting = p_i$accounting %||% accounting,
+          scale_by = p_i$scale_by %||% scale_by,
+          suffixing = p_i$suffixing %||% suffixing,
+          pattern = p_i$pattern %||% pattern,
+          sep_mark = p_i$sep_mark %||% sep_mark,
+          dec_mark = p_i$dec_mark %||% dec_mark,
+          force_sign = p_i$force_sign %||% force_sign,
+          system = p_i$system %||% system,
+          locale = p_i$locale %||% locale
+        )
+    }
+
+    return(data)
+  }
+
+  #
+  # End support for `from_column()` objects passed to compatible arguments
+  #
+
+  # Ensure that arguments are matched
+  system <- rlang::arg_match(system)
+
+  # Stop function if `locale` does not have a valid value; normalize locale
+  # and resolve one that might be set globally
+  validate_locale(locale = locale)
+  locale <- normalize_locale(locale = locale)
+  locale <- resolve_locale(data = data, locale = locale)
+
+  # Use locale-based marks if a locale ID is provided
+  sep_mark <- get_locale_sep_mark(locale, sep_mark, use_seps)
+  dec_mark <- get_locale_dec_mark(locale, dec_mark)
+
+  # Normalize the `suffixing` input to either return a character vector
+  # of suffix labels, or NULL (the case where `suffixing` is FALSE)
+  suffix_labels <- normalize_suffixing_inputs(suffixing, scale_by, system)
+
+  valid_class <- c("numeric", "integer")
+  check_columns_valid_if_strict(data, {{ columns }}, valid_class, call = fn_call)
+
+  # Set the `formatC_format` option according to whether number
+  # formatting with significant figures is to be performed
+  if (!is.null(n_sigfig) && !is.na(n_sigfig[1])) {
+
+    # Stop function if `n_sigfig` does not have a valid value
+    validate_n_sigfig(n_sigfig = n_sigfig)
+
+    formatC_format <- "fg"
+  } else {
+    formatC_format <- "f"
+  }
+
+  # Pass `data`, `columns`, `rows`, and the formatting
+  # functions as a function list to `fmt()`
+  fmt(
+    data = data,
+    columns = {{ columns }},
+    rows = {{ rows }},
+    compat = valid_class,
+    fns = num_fmt_factory_multi(
+      pattern = pattern,
+      format_fn = function(x, context) {
+
+        # Create the `suffix_df` object
+        suffix_df <-
+          create_suffix_df(
+            x,
+            decimals = decimals,
+            suffix_labels = suffix_labels,
+            scale_by = scale_by,
+            system = system
+          )
+
+        # Determine whether `scale_by` is supplied as a function; if it isn't
+        # the only other pathway involves getting the vector of values produced
+        # by the `create_suffix_df()` function
+        if (rlang::is_function(scale_by)) {
+          to_scale_by <- scale_by
+        } else {
+          to_scale_by <- suffix_df$scale_by
+        }
+
+        # Scale the `x` values using `to_scale_by` (either a function or
+        # a numeric vector)
+        x <- scale_x_values(x, scale_by = to_scale_by)
+
+        # Format numeric values to character-based numbers
+        x_str <-
+          format_num_to_str(
+            x,
+            context = context,
+            decimals = decimals,
+            n_sigfig = n_sigfig,
+            sep_mark = sep_mark,
+            dec_mark = dec_mark,
+            drop_trailing_zeros = drop_trailing_zeros,
+            drop_trailing_dec_mark = drop_trailing_dec_mark,
+            format = formatC_format,
+            system = system
+          )
+
+        # Paste the vector of suffixes to the right of the values
+        x_str <- paste_right(x_str, x_right = suffix_df$suffix)
+
+        # Format values in accounting notation (if `accounting = TRUE`)
+        x_str <-
+          format_as_accounting(
+            x_str,
+            x = x,
+            context = context,
+            accounting = accounting
+          )
+
+        # Force a positive sign on certain values if the option is taken
+        if (!accounting && force_sign) {
+
+          positive_x <- !is.na(x) & x > 0
+          x_str[positive_x] <- paste_left(x_str[positive_x], x_left = "+")
+        }
+
+        x_str
+      }
+    )
+  )
+}
+
+#' Format values as integers
+#'
+#' @description
+#'
+#' With numeric values in a **gt** table, we can perform number-based
+#' formatting so that the targeted values are always rendered as integer values.
+#' We can have fine control over integer formatting with the following options:
+#'
+#' - digit grouping separators: options to enable/disable digit separators
+#' and provide a choice of separator symbol
+#' - scaling: we can choose to scale targeted values by a multiplier value
+#' - large-number suffixing: larger figures (thousands, millions, etc.) can
+#' be autoscaled and decorated with the appropriate suffixes
+#' - pattern: option to use a text pattern for decoration of the formatted
+#' values
+#' - locale-based formatting: providing a locale ID will result in number
+#' formatting specific to the chosen locale
+#'
+#' @inheritParams fmt_number
+#'
+#' @param suffixing *Specification for large-number suffixing*
+#'
+#'   `scalar<logical>|vector<character>` // *default:* `FALSE`
+#'
+#'   The `suffixing` option allows us to scale and apply suffixes to larger
+#'   numbers (e.g., `1924000` can be transformed to `2M`). This option can
+#'   accept a logical value, where `FALSE` (the default) will not perform this
+#'   transformation and `TRUE` will apply thousands (`K`), millions (`M`),
+#'   billions (`B`), and trillions (`T`) suffixes after automatic value scaling.
+#'
+#'   We can alternatively provide a character vector that serves as a
+#'   specification for which symbols are to used for each of the value ranges.
+#'   These preferred symbols will replace the defaults (e.g.,
+#'   `c("k", "Ml", "Bn", "Tr")` replaces `"K"`, `"M"`, `"B"`, and `"T"`).
+#'
+#'   Including `NA` values in the vector will ensure that the particular range
+#'   will either not be included in the transformation (e.g.,
+#'   `c(NA, "M", "B", "T")` won't modify numbers at all in the thousands range)
+#'   or the range will inherit a previous suffix (e.g., with
+#'   `c("K", "M", NA, "T")`, all numbers in the range of millions and billions
+#'   will be in terms of millions).
+#'
+#'   Any use of `suffixing` (where it is not set expressly as `FALSE`) means
+#'   that any value provided to `scale_by` will be ignored.
+#'
+#'   If using `system = "ind"` then the default suffix set provided by
+#'   `suffixing = TRUE` will be the equivalent of `c(NA, "L", "Cr")`. This
+#'   doesn't apply suffixes to the thousands range, but does express values in
+#'   *lakhs* and *crores*.
+#'
+#' @return An object of class `gt_tbl`.
+#'
+#' @section Compatibility of formatting function with data values:
+#'
+#' `fmt_integer()` is compatible with body cells that are of the `"numeric"` or
+#' `"integer"` types. Any other types of body cells are ignored during
+#' formatting. This is to say that cells of incompatible data types may be
+#' targeted, but there will be no attempt to format them.
+#'
+#' @section Targeting cells with `columns` and `rows`:
+#'
+#' Targeting of values is done through `columns` and additionally by `rows` (if
+#' nothing is provided for `rows` then entire columns are selected). The
+#' `columns` argument allows us to target a subset of cells contained in the
+#' resolved columns. We say resolved because aside from declaring column names
+#' in `c()` (with bare column names or names in quotes) we can use
+#' **tidyselect**-style expressions. This can be as basic as supplying a select
+#' helper like `starts_with()`, or, providing a more complex incantation like
+#'
+#' `where(~ is.numeric(.x) && max(.x, na.rm = TRUE) > 1E6)`
+#'
+#' which targets numeric columns that have a maximum value greater than
+#' 1,000,000 (excluding any `NA`s from consideration).
+#'
+#' By default all columns and rows are selected (with the `everything()`
+#' defaults). Cell values that are incompatible with a given formatting function
+#' will be skipped over, like `character` values and numeric `fmt_*()`
+#' functions. So it's safe to select all columns with a particular formatting
+#' function (only those values that can be formatted will be formatted), but,
+#' you may not want that. One strategy is to format the bulk of cell values with
+#' one formatting function and then constrain the columns for later passes with
+#' other types of formatting (the last formatting done to a cell is what you get
+#' in the final output).
+#'
+#' Once the columns are targeted, we may also target the `rows` within those
+#' columns. This can be done in a variety of ways. If a stub is present, then we
+#' potentially have row identifiers. Those can be used much like column names in
+#' the `columns`-targeting scenario. We can use simpler **tidyselect**-style
+#' expressions (the select helpers should work well here) and we can use quoted
+#' row identifiers in `c()`. It's also possible to use row indices (e.g.,
+#' `c(3, 5, 6)`) though these index values must correspond to the row numbers of
+#' the input data (the indices won't necessarily match those of rearranged rows
+#' if row groups are present). One more type of expression is possible, an
+#' expression that takes column values (can involve any of the available columns
+#' in the table) and returns a logical vector. This is nice if you want to base
+#' formatting on values in the column or another column, or, you'd like to use a
+#' more complex predicate expression.
+#'
+#' @section Compatibility of arguments with the `from_column()` helper function:
+#'
+#' [from_column()] can be used with certain arguments of  `fmt_integer()` to
+#' obtain varying parameter values from a specified column within the table.
+#' This means that each row could be formatted a little bit differently. These
+#' arguments provide support for [from_column()]:
+#'
+#' - `use_seps`
+#' - `accounting`
+#' - `scale_by`
+#' - `suffixing`
+#' - `pattern`
+#' - `sep_mark`
+#' - `force_sign`
+#' - `system`
+#' - `locale`
+#'
+#' Please note that for all of the aforementioned arguments, a [from_column()]
+#' call needs to reference a column that has data of the correct type (this is
+#' different for each argument). Additional columns for parameter values can be
+#' generated with [cols_add()] (if not already present). Columns that contain
+#' parameter data can also be hidden from final display with [cols_hide()].
+#' Finally, there is no limitation to how many arguments the [from_column()]
+#' helper is applied so long as the arguments belong to this closed set.
+#'
+#' @section Adapting output to a specific `locale`:
+#'
+#' This formatting function can adapt outputs according to a provided `locale`
+#' value. Examples include `"en"` for English (United States) and `"fr"` for
+#' French (France). The use of a valid locale ID here means separator marks will
+#' be correct for the given locale. Should any value be provided in `sep_mark`,
+#' it will be overridden by the locale's preferred value.
+#'
+#' Note that a `locale` value provided here will override any global locale
+#' setting performed in [gt()]'s own `locale` argument (it is settable there as
+#' a value received by all other functions that have a `locale` argument). As a
+#' useful reference on which locales are supported, we can call [info_locales()]
+#' to view an info table.
+#'
+#' @section Examples:
+#'
+#' For this example, we'll use two columns from the [`exibble`] dataset and
+#' create a simple **gt** table. With `fmt_integer()`, we'll format the `num`
+#' column as integer values having no digit separators (with the
+#' `use_seps = FALSE` option).
+#'
+#' ```r
+#' exibble |>
+#'   dplyr::select(num, char) |>
+#'   gt() |>
+#'   fmt_integer(use_seps = FALSE)
+#' ```
+#'
+#' \if{html}{\out{
+#' `r man_get_image_tag(file = "man_fmt_integer_1.png")`
+#' }}
+#'
+#' Let's use a modified version of the [`countrypops`] dataset to create a
+#' **gt** table with row labels. We will format all numeric columns with
+#' `fmt_integer()` and scale all values by `1 / 1E6`, giving us integer values
+#' representing millions of people. We can make clear what the values represent
+#' with an informative spanner label via [tab_spanner()].
+#'
+#' ```r
+#' countrypops |>
+#'   dplyr::select(country_code_3, year, population) |>
+#'   dplyr::filter(country_code_3 %in% c("CHN", "IND", "USA", "PAK", "IDN")) |>
+#'   dplyr::filter(year > 1975 & year %% 5 == 0) |>
+#'   tidyr::spread(year, population) |>
+#'   dplyr::arrange(desc(`2015`)) |>
+#'   gt(rowname_col = "country_code_3") |>
+#'   fmt_integer(scale_by = 1 / 1E6) |>
+#'   tab_spanner(label = "Millions of People", columns = everything())
+#' ```
+#'
+#' \if{html}{\out{
+#' `r man_get_image_tag(file = "man_fmt_integer_2.png")`
+#' }}
+#'
+#' Using a subset of the [`towny`] dataset, we can do interesting things with
+#' integer values. Through [cols_add()] we'll add the `difference` column (which
+#' calculates the difference between 2021 and 2001 populations). All numeric
+#' values will be formatted with a first pass of `fmt_integer()`; a second pass
+#' of `fmt_integer()` focuses on the `difference` column and here we use the
+#' `force_sign = TRUE` option to draw attention to positive and negative
+#' difference values.
+#'
+#' ```r
+#' towny |>
+#'   dplyr::select(name, population_2001, population_2021) |>
+#'   dplyr::slice_tail(n = 10) |>
+#'   gt() |>
+#'   cols_add(difference = population_2021 - population_2001) |>
+#'   fmt_integer() |>
+#'   fmt_integer(columns = difference, force_sign = TRUE) |>
+#'   cols_label_with(fn = function(x) gsub("population_", "", x)) |>
+#'   tab_style(
+#'     style = cell_fill(color = "gray90"),
+#'     locations = cells_body(columns = difference)
+#'   )
+#' ```
+#'
+#' \if{html}{\out{
+#' `r man_get_image_tag(file = "man_fmt_integer_3.png")`
+#' }}
+#'
+#' @family data formatting functions
+#' @section Function ID:
+#' 3-2
+#'
+#' @section Function Introduced:
+#' `v0.3.1` (August 9, 2021)
+#'
+#' @seealso
+#' Format number with decimal values: [fmt_number()]
+#'
+#' The vector-formatting version of this function: [vec_fmt_integer()]
+#'
+#' @export
+fmt_integer <- function(
+    data,
+    columns = everything(),
+    rows = everything(),
+    use_seps = TRUE,
+    accounting = FALSE,
+    scale_by = 1.0,
+    suffixing = FALSE,
+    pattern = "{x}",
+    sep_mark = ",",
+    force_sign = FALSE,
+    system = c("intl", "ind"),
+    locale = NULL
+) {
+
+  # Perform input object validation
+  stop_if_not_gt_tbl(data = data)
+
+  #
+  # Begin support for `from_column()` objects passed to compatible arguments
+  #
+
+  # Supports parameters:
+  #
+  # - use_seps
+  # - accounting
+  # - scale_by
+  # - suffixing
+  # - pattern
+  # - sep_mark
+  # - force_sign
+  # - system
+  # - locale
+
+  arg_vals <-
+    mget(
+      get_arg_names(
+        function_name = "fmt_integer",
+        all_args_except = c("data", "columns", "rows")
+      )
+    )
+
+  if (args_have_gt_column_obj(arg_vals = arg_vals)) {
+
+    # Resolve the row numbers using `resolve_vars()`
+    resolved_rows_idx <-
+      resolve_rows_i(
+        expr = {{ rows }},
+        data = data
+      )
+
+    param_tbl <-
+      generate_param_tbl(
+        data = data,
+        arg_vals = arg_vals,
+        resolved_rows_idx = resolved_rows_idx
+      )
+
+    for (i in seq_len(nrow(param_tbl))) {
+
+      p_i <- as.list(param_tbl[i, ])
+
+      data <-
+        fmt_integer(
+          data = data,
+          columns = {{ columns }},
+          rows = resolved_rows_idx[i],
+          use_seps = p_i$use_seps %||% use_seps,
+          accounting = p_i$accounting %||% accounting,
+          scale_by = p_i$scale_by %||% scale_by,
+          suffixing = p_i$suffixing %||% suffixing,
+          pattern = p_i$pattern %||% pattern,
+          sep_mark = p_i$sep_mark %||% sep_mark,
+          force_sign = p_i$force_sign %||% force_sign,
+          system = p_i$system %||% system,
+          locale = p_i$locale %||% locale
+        )
+    }
+
+    return(data)
+  }
+
+  #
+  # End support for `from_column()` objects passed to compatible arguments
+  #
+
+  fmt_number(
+    data = data,
+    columns = {{ columns }},
+    rows = {{ rows }},
+    decimals = 0,
+    n_sigfig = NULL,
+    drop_trailing_zeros = FALSE,
+    drop_trailing_dec_mark = TRUE,
+    use_seps = use_seps,
+    accounting = accounting,
+    scale_by = scale_by,
+    suffixing = suffixing,
+    pattern = pattern,
+    sep_mark = sep_mark,
+    dec_mark = "not used",
+    force_sign = force_sign,
+    system = system,
+    locale = locale
+  )
+}
diff --git a/R/format_data.R b/R/format_data.R
index b394342792..deefa0da91 100644
--- a/R/format_data.R
+++ b/R/format_data.R
@@ -22,959 +22,6 @@
 #------------------------------------------------------------------------------#
 
 
-#' Format numeric values
-#'
-#' @description
-#'
-#' With numeric values in a **gt** table, we can perform number-based
-#' formatting so that the targeted values are rendered with a higher
-#' consideration for tabular presentation. Furthermore, there is finer control
-#' over numeric formatting with the following options:
-#'
-#' - decimals: choice of the number of decimal places, option to drop
-#' trailing zeros, and a choice of the decimal symbol
-#' - digit grouping separators: options to enable/disable digit separators
-#' and provide a choice of separator symbol
-#' - scaling: we can choose to scale targeted values by a multiplier value
-#' - large-number suffixing: larger figures (thousands, millions, etc.) can
-#' be autoscaled and decorated with the appropriate suffixes
-#' - pattern: option to use a text pattern for decoration of the formatted
-#' values
-#' - locale-based formatting: providing a locale ID will result in number
-#' formatting specific to the chosen locale
-#'
-#' @param data *The gt table data object*
-#'
-#'   `obj:<gt_tbl>` // **required**
-#'
-#'   This is the **gt** table object that is commonly created through use of the
-#'   [gt()] function.
-#'
-#' @param columns *Columns to target*
-#'
-#'   `<column-targeting expression>` // *default:* `everything()`
-#'
-#'   Can either be a series of column names provided in `c()`, a vector of
-#'   column indices, or a select helper function (e.g. [starts_with()],
-#'   [ends_with()], [contains()], [matches()], [num_range()] and [everything()]).
-#'
-#' @param rows *Rows to target*
-#'
-#'   `<row-targeting expression>` // *default:* `everything()`
-#'
-#'   In conjunction with `columns`, we can specify which of their rows should
-#'   undergo formatting. The default [everything()] results in all rows in
-#'   `columns` being formatted. Alternatively, we can supply a vector of row
-#'   captions within `c()`, a vector of row indices, or a select helper
-#'   function (e.g. [starts_with()], [ends_with()], [contains()], [matches()],
-#'   [num_range()], and [everything()]). We can also use expressions to filter
-#'   down to the rows we need (e.g., `[colname_1] > 100 & [colname_2] < 50`).
-#'
-#' @param decimals *Number of decimal places*
-#'
-#'   `scalar<numeric|integer>(val>=0)` // *default:* `2`
-#'
-#'   This corresponds to the exact number of decimal places to use. A value
-#'   such as `2.34` can, for example, be formatted with `0` decimal places and
-#'   it would result in `"2"`. With `4` decimal places, the formatted value
-#'   becomes `"2.3400"`.
-#'
-#' @param n_sigfig *Number of significant figures*
-#'
-#'   `scalar<numeric|integer>(val>=1)` // *default:* `NULL` (`optional`)
-#'
-#'   A option to format numbers to *n* significant figures. By default, this is
-#'   `NULL` and thus number values will be formatted according to the number of
-#'   decimal places set via `decimals`. If opting to format according to the
-#'   rules of significant figures, `n_sigfig` must be a number greater than or
-#'   equal to `1`. Any values passed to the `decimals` and `drop_trailing_zeros`
-#'   arguments will be ignored.
-#'
-#' @param drop_trailing_zeros *Drop any trailing zeros*
-#'
-#'   `scalar<logical>` // *default:* `FALSE`
-#'
-#'   A logical value that allows for removal of trailing zeros (those redundant
-#'   zeros after the decimal mark).
-#'
-#' @param drop_trailing_dec_mark *Drop the trailing decimal mark*
-#'
-#'   `scalar<logical>` // *default:* `TRUE`
-#'
-#'   A logical value that determines whether decimal marks should always appear
-#'   even if there are no decimal digits to display after formatting (e.g., `23`
-#'   becomes `23.` if `FALSE`). By default trailing decimal marks are not shown.
-#'
-#' @param use_seps *Use digit group separators*
-#'
-#'   `scalar<logical>` // *default:* `TRUE`
-#'
-#'   An option to use digit group separators. The type of digit group separator
-#'   is set by `sep_mark` and overridden if a locale ID is provided to `locale`.
-#'   This setting is `TRUE` by default.
-#'
-#' @param accounting *Use accounting style*
-#'
-#'   `scalar<logical>` // *default:* `FALSE`
-#'
-#'   An option to use accounting style for values. Normally, negative values
-#'   will be shown with a minus sign but using accounting style will instead put
-#'   any negative values in parentheses.
-#'
-#' @param scale_by *Scale values by a fixed multiplier*
-#'
-#'   `scalar<numeric|integer>` // *default:* `1`
-#'
-#'   All numeric values will be multiplied by the `scale_by` value before
-#'   undergoing formatting. Since the `default` value is `1`, no values will be
-#'   changed unless a different multiplier value is supplied. This value will be
-#'   ignored if using any of the `suffixing` options (i.e., where `suffixing` is
-#'   not set to `FALSE`).
-#'
-#' @param suffixing *Specification for large-number suffixing*
-#'
-#'   `scalar<logical>|vector<character>` // *default:* `FALSE`
-#'
-#'   The `suffixing` option allows us to scale and apply suffixes to larger
-#'   numbers (e.g., `1924000` can be transformed to `1.92M`). This option can
-#'   accept a logical value, where `FALSE` (the default) will not perform this
-#'   transformation and `TRUE` will apply thousands (`"K"`), millions (`"M"`),
-#'   billions (`"B"`), and trillions (`"T"`) suffixes after automatic value
-#'   scaling.
-#'
-#'   We can alternatively provide a character vector that serves as a
-#'   specification for which symbols are to used for each of the value ranges.
-#'   These preferred symbols will replace the defaults (e.g.,
-#'   `c("k", "Ml", "Bn", "Tr")` replaces `"K"`, `"M"`, `"B"`, and `"T"`).
-#'
-#'   Including `NA` values in the vector will ensure that the particular range
-#'   will either not be included in the transformation (e.g.,
-#'   `c(NA, "M", "B", "T")` won't modify numbers at all in the thousands range)
-#'   or the range will inherit a previous suffix (e.g., with
-#'   `c("K", "M", NA, "T")`, all numbers in the range of millions and billions
-#'   will be in terms of millions).
-#'
-#'   Any use of `suffixing` (where it is not set expressly as `FALSE`) means
-#'   that any value provided to `scale_by` will be ignored.
-#'
-#'   If using `system = "ind"` then the default suffix set provided by
-#'   `suffixing = TRUE` will be the equivalent of `c(NA, "L", "Cr")`. This
-#'   doesn't apply suffixes to the thousands range, but does express values in
-#'   *lakhs* and *crores*.
-#'
-#' @param pattern *Specification of the formatting pattern*
-#'
-#'   `scalar<character>` // *default:* `"{x}"`
-#'
-#'   A formatting pattern that allows for decoration of the formatted value. The
-#'   formatted value is represented by the `{x}` (which can be used multiple
-#'   times, if needed) and all other characters will be interpreted as string
-#'   literals.
-#'
-#' @param sep_mark *Separator mark for digit grouping*
-#'
-#'   `scalar<character>` // *default:* `","`
-#'
-#'   The string to use as a separator between groups of digits. For example,
-#'   using `sep_mark = ","` with a value of `1000` would result in a formatted
-#'   value of `"1,000"`. This argument is ignored if a `locale` is supplied
-#'   (i.e., is not `NULL`).
-#'
-#' @param dec_mark *Decimal mark*
-#'
-#'   `scalar<character>` // *default:* `"."`
-#'
-#'   The string to be used as the decimal mark. For example, using
-#'   `dec_mark = ","` with the value `0.152` would result in a formatted value
-#'   of `"0,152"`). This argument is ignored if a `locale` is supplied (i.e., is
-#'   not `NULL`).
-#'
-#' @param force_sign *Forcing the display of a positive sign*
-#'
-#'   `scalar<logical>` // *default:* `FALSE`
-#'
-#'   Should the positive sign be shown for positive values (effectively showing
-#'   a sign for all values except zero)? If so, use `TRUE` for this option. The
-#'   default is `FALSE`, where only negative numbers will display a minus sign.
-#'   This option is disregarded when using accounting notation with
-#'   `accounting = TRUE`.
-#'
-#' @param system *Numbering system for grouping separators*
-#'
-#'   `singl-kw:[intl|ind]` // *default:* `"intl"`
-#'
-#'   The international numbering system (keyword: `"intl"`) is widely used and
-#'   its grouping separators (i.e., `sep_mark`) are always separated by three
-#'   digits. The alternative system, the Indian numbering system (keyword:
-#'   `"ind"`), uses grouping separators that correspond to thousand, lakh,
-#'   crore, and higher quantities.
-#'
-#' @param locale *Locale identifier*
-#'
-#'   `scalar<character>` // *default:* `NULL` (`optional`)
-#'
-#'   An optional locale identifier that can be used for formatting values
-#'   according the locale's rules. Examples include `"en"` for English (United
-#'   States) and `"fr"` for French (France). We can call [info_locales()] for a
-#'   useful reference for all of the locales that are supported. A locale ID can
-#'   be also set in the initial [gt()] function call (where it would be used
-#'   automatically by any function with a `locale` argument) but a `locale`
-#'   value provided here will override that global locale.
-#'
-#' @return An object of class `gt_tbl`.
-#'
-#' @section Compatibility of formatting function with data values:
-#'
-#' `fmt_number()` is compatible with body cells that are of the `"numeric"` or
-#' `"integer"` types. Any other types of body cells are ignored during
-#' formatting. This is to say that cells of incompatible data types may be
-#' targeted, but there will be no attempt to format them.
-#'
-#' @section Targeting cells with `columns` and `rows`:
-#'
-#' Targeting of values is done through `columns` and additionally by `rows` (if
-#' nothing is provided for `rows` then entire columns are selected). The
-#' `columns` argument allows us to target a subset of cells contained in the
-#' resolved columns. We say resolved because aside from declaring column names
-#' in `c()` (with bare column names or names in quotes) we can use
-#' **tidyselect**-style expressions. This can be as basic as supplying a select
-#' helper like `starts_with()`, or, providing a more complex incantation like
-#'
-#' `where(~ is.numeric(.x) && max(.x, na.rm = TRUE) > 1E6)`
-#'
-#' which targets numeric columns that have a maximum value greater than
-#' 1,000,000 (excluding any `NA`s from consideration).
-#'
-#' By default all columns and rows are selected (with the `everything()`
-#' defaults). Cell values that are incompatible with a given formatting function
-#' will be skipped over, like `character` values and numeric `fmt_*()`
-#' functions. So it's safe to select all columns with a particular formatting
-#' function (only those values that can be formatted will be formatted), but,
-#' you may not want that. One strategy is to format the bulk of cell values with
-#' one formatting function and then constrain the columns for later passes with
-#' other types of formatting (the last formatting done to a cell is what you get
-#' in the final output).
-#'
-#' Once the columns are targeted, we may also target the `rows` within those
-#' columns. This can be done in a variety of ways. If a stub is present, then we
-#' potentially have row identifiers. Those can be used much like column names in
-#' the `columns`-targeting scenario. We can use simpler **tidyselect**-style
-#' expressions (the select helpers should work well here) and we can use quoted
-#' row identifiers in `c()`. It's also possible to use row indices (e.g.,
-#' `c(3, 5, 6)`) though these index values must correspond to the row numbers of
-#' the input data (the indices won't necessarily match those of rearranged rows
-#' if row groups are present). One more type of expression is possible, an
-#' expression that takes column values (can involve any of the available columns
-#' in the table) and returns a logical vector. This is nice if you want to base
-#' formatting on values in the column or another column, or, you'd like to use a
-#' more complex predicate expression.
-#'
-#' @section Compatibility of arguments with the `from_column()` helper function:
-#'
-#' [from_column()] can be used with certain arguments of `fmt_number()` to
-#' obtain varying parameter values from a specified column within the table.
-#' This means that each row could be formatted a little bit differently. These
-#' arguments provide support for [from_column()]:
-#'
-#' - `decimals`
-#' - `n_sigfig`
-#' - `drop_trailing_zeros`
-#' - `drop_trailing_dec_mark`
-#' - `use_seps`
-#' - `accounting`
-#' - `scale_by`
-#' - `suffixing`
-#' - `pattern`
-#' - `sep_mark`
-#' - `dec_mark`
-#' - `force_sign`
-#' - `system`
-#' - `locale`
-#'
-#' Please note that for all of the aforementioned arguments, a [from_column()]
-#' call needs to reference a column that has data of the correct type (this is
-#' different for each argument). Additional columns for parameter values can be
-#' generated with [cols_add()] (if not already present). Columns that contain
-#' parameter data can also be hidden from final display with [cols_hide()].
-#' Finally, there is no limitation to how many arguments the [from_column()]
-#' helper is applied so long as the arguments belong to this closed set.
-#'
-#' @section Adapting output to a specific `locale`:
-#'
-#' This formatting function can adapt outputs according to a provided `locale`
-#' value. Examples include `"en"` for English (United States) and `"fr"` for
-#' French (France). The use of a valid locale ID here means separator and
-#' decimal marks will be correct for the given locale. Should any values be
-#' provided in `sep_mark` or `dec_mark`, they will be overridden by the locale's
-#' preferred values.
-#'
-#' Note that a `locale` value provided here will override any global locale
-#' setting performed in [gt()]'s own `locale` argument (it is settable there as
-#' a value received by all other functions that have a `locale` argument). As a
-#' useful reference on which locales are supported, we can call [info_locales()]
-#' to view an info table.
-#'
-#' @section Examples:
-#'
-#' Let's use the [`exibble`] dataset to create a **gt** table. With
-#' `fmt_number()`, we'll format the `num` column to have three decimal
-#' places (with `decimals = 3`) and omit the use of digit separators (with
-#' `use_seps = FALSE`).
-#'
-#' ```r
-#' exibble |>
-#'   gt() |>
-#'   fmt_number(
-#'     columns = num,
-#'     decimals = 3,
-#'     use_seps = FALSE
-#'   )
-#' ```
-#'
-#' \if{html}{\out{
-#' `r man_get_image_tag(file = "man_fmt_number_1.png")`
-#' }}
-#'
-#' Use a modified version of the [`countrypops`] dataset to create a **gt**
-#' table with row labels. Format all columns to use large-number suffixing
-#' (e.g., where `"10,000,000"` becomes `"10M"`) with the `suffixing = TRUE`
-#' option.
-#'
-#' ```r
-#' countrypops |>
-#'   dplyr::select(country_code_3, year, population) |>
-#'   dplyr::filter(country_code_3 %in% c("CHN", "IND", "USA", "PAK", "IDN")) |>
-#'   dplyr::filter(year > 1975 & year %% 5 == 0) |>
-#'   tidyr::spread(year, population) |>
-#'   dplyr::arrange(desc(`2015`)) |>
-#'   gt(rowname_col = "country_code_3") |>
-#'   fmt_number(suffixing = TRUE)
-#' ```
-#'
-#' \if{html}{\out{
-#' `r man_get_image_tag(file = "man_fmt_number_2.png")`
-#' }}
-#'
-#' In a variation of the previous table, we can combine large-number suffixing
-#' with a declaration of the number of significant digits to use. With things
-#' like population figures, `n_sigfig = 3` is a very good option.
-#'
-#' ```r
-#' countrypops |>
-#'   dplyr::select(country_code_3, year, population) |>
-#'   dplyr::filter(country_code_3 %in% c("CHN", "IND", "USA", "PAK", "IDN")) |>
-#'   dplyr::filter(year > 1975 & year %% 5 == 0) |>
-#'   tidyr::spread(year, population) |>
-#'   dplyr::arrange(desc(`2015`)) |>
-#'   gt(rowname_col = "country_code_3") |>
-#'   fmt_number(suffixing = TRUE, n_sigfig = 3)
-#' ```
-#'
-#' \if{html}{\out{
-#' `r man_get_image_tag(file = "man_fmt_number_3.png")`
-#' }}
-#'
-#' There can be cases where you want to show numbers to a large number of
-#' decimal places but also drop the unnecessary trailing zeros for low-precision
-#' values. Let's take a portion of the [`towny`] dataset and format the
-#' `latitude` and `longitude` columns with `fmt_number()`. We'll have up to 5
-#' digits displayed as decimal values, but we'll also unconditionally drop any
-#' runs of trailing zeros in the decimal part with `drop_trailing_zeros = TRUE`.
-#'
-#' ```r
-#' towny |>
-#'   dplyr::select(name, latitude, longitude) |>
-#'   dplyr::slice_head(n = 10) |>
-#'   gt() |>
-#'   fmt_number(decimals = 5, drop_trailing_zeros = TRUE) |>
-#'   cols_merge(columns = -name, pattern = "{1}, {2}") |>
-#'   cols_label(
-#'     name ~ "Municipality",
-#'     latitude = "Location"
-#'   )
-#' ```
-#'
-#' \if{html}{\out{
-#' `r man_get_image_tag(file = "man_fmt_number_4.png")`
-#' }}
-#'
-#' Another strategy for dealing with precision of decimals is to have a separate
-#' column of values that specify how many decimal digits to retain. Such a
-#' column can be added via [cols_add()] or it can be part of the input table for
-#' [gt()]. With that column available, it can be referenced in the `decimals`
-#' argument with [from_column()]. This approach yields a display of coordinate
-#' values that reflects the measurement precision of each value.
-#'
-#' ```r
-#' towny |>
-#'   dplyr::select(name, latitude, longitude) |>
-#'   dplyr::slice_head(n = 10) |>
-#'   gt() |>
-#'   cols_add(dec_digits = c(1, 2, 2, 5, 5, 2, 3, 2, 3, 3)) |>
-#'   fmt_number(decimals = from_column(column = "dec_digits")) |>
-#'   cols_merge(columns = -name, pattern = "{1}, {2}") |>
-#'   cols_label(
-#'     name ~ "Municipality",
-#'     latitude = "Location"
-#'   )
-#' ```
-#'
-#' \if{html}{\out{
-#' `r man_get_image_tag(file = "man_fmt_number_5.png")`
-#' }}
-#'
-#' @family data formatting functions
-#' @section Function ID:
-#' 3-1
-#'
-#' @section Function Introduced:
-#' `v0.2.0.5` (March 31, 2020)
-#'
-#' @seealso
-#' The integer-formatting function (format rounded values (i.e., no decimals shown and
-#'input values are rounded as necessary): [fmt_integer()].
-#'
-#' The vector-formatting version of this function: [vec_fmt_number()]
-#'
-#' @export
-fmt_number <- function(
-    data,
-    columns = everything(),
-    rows = everything(),
-    decimals = 2,
-    n_sigfig = NULL,
-    drop_trailing_zeros = FALSE,
-    drop_trailing_dec_mark = TRUE,
-    use_seps = TRUE,
-    accounting = FALSE,
-    scale_by = 1.0,
-    suffixing = FALSE,
-    pattern = "{x}",
-    sep_mark = ",",
-    dec_mark = ".",
-    force_sign = FALSE,
-    system = c("intl", "ind"),
-    locale = NULL
-) {
-
-  # Perform input object validation
-  stop_if_not_gt_tbl(data = data)
-
-  #
-  # Begin support for `from_column()` objects passed to compatible arguments
-  #
-
-  # Supports parameters:
-  #
-  # - decimals
-  # - n_sigfig
-  # - drop_trailing_zeros
-  # - drop_trailing_dec_mark
-  # - use_seps
-  # - accounting
-  # - scale_by
-  # - suffixing
-  # - pattern
-  # - sep_mark
-  # - dec_mark
-  # - force_sign
-  # - system
-  # - locale
-
-  arg_vals <-
-    mget(
-      get_arg_names(
-        function_name = "fmt_number",
-        all_args_except = c("data", "columns", "rows")
-      )
-    )
-  # Assume that if decimals = 0, function = fmt_integer, fmt_number otherwise
-  if (identical(decimals, 0)) {
-    fn_call <- call("fmt_integer")
-  } else {
-    fn_call <- call("fmt_number")
-  }
-
-  if (args_have_gt_column_obj(arg_vals = arg_vals)) {
-
-    # Resolve the row numbers using `resolve_vars()`
-    resolved_rows_idx <-
-      resolve_rows_i(
-        expr = {{ rows }},
-        data = data,
-        call = fn_call
-      )
-
-    param_tbl <-
-      generate_param_tbl(
-        data = data,
-        arg_vals = arg_vals,
-        resolved_rows_idx = resolved_rows_idx
-      )
-
-    for (i in seq_len(nrow(param_tbl))) {
-
-      p_i <- as.list(param_tbl[i, ])
-
-      data <-
-        fmt_number(
-          data = data,
-          columns = {{ columns }},
-          rows = resolved_rows_idx[i],
-          decimals = p_i$decimals %||% decimals,
-          n_sigfig = p_i$n_sigfig %||% n_sigfig,
-          drop_trailing_zeros = p_i$drop_trailing_zeros %||% drop_trailing_zeros,
-          drop_trailing_dec_mark = p_i$drop_trailing_dec_mark %||% drop_trailing_dec_mark,
-          use_seps = p_i$use_seps %||% use_seps,
-          accounting = p_i$accounting %||% accounting,
-          scale_by = p_i$scale_by %||% scale_by,
-          suffixing = p_i$suffixing %||% suffixing,
-          pattern = p_i$pattern %||% pattern,
-          sep_mark = p_i$sep_mark %||% sep_mark,
-          dec_mark = p_i$dec_mark %||% dec_mark,
-          force_sign = p_i$force_sign %||% force_sign,
-          system = p_i$system %||% system,
-          locale = p_i$locale %||% locale
-        )
-    }
-
-    return(data)
-  }
-
-  #
-  # End support for `from_column()` objects passed to compatible arguments
-  #
-
-  # Ensure that arguments are matched
-  system <- rlang::arg_match(system)
-
-  # Stop function if `locale` does not have a valid value; normalize locale
-  # and resolve one that might be set globally
-  validate_locale(locale = locale)
-  locale <- normalize_locale(locale = locale)
-  locale <- resolve_locale(data = data, locale = locale)
-
-  # Use locale-based marks if a locale ID is provided
-  sep_mark <- get_locale_sep_mark(locale, sep_mark, use_seps)
-  dec_mark <- get_locale_dec_mark(locale, dec_mark)
-
-  # Normalize the `suffixing` input to either return a character vector
-  # of suffix labels, or NULL (the case where `suffixing` is FALSE)
-  suffix_labels <- normalize_suffixing_inputs(suffixing, scale_by, system)
-
-  valid_class <- c("numeric", "integer")
-  check_columns_valid_if_strict(data, {{ columns }}, valid_class, call = fn_call)
-
-  # Set the `formatC_format` option according to whether number
-  # formatting with significant figures is to be performed
-  if (!is.null(n_sigfig) && !is.na(n_sigfig[1])) {
-
-    # Stop function if `n_sigfig` does not have a valid value
-    validate_n_sigfig(n_sigfig = n_sigfig)
-
-    formatC_format <- "fg"
-  } else {
-    formatC_format <- "f"
-  }
-
-  # Pass `data`, `columns`, `rows`, and the formatting
-  # functions as a function list to `fmt()`
-  fmt(
-    data = data,
-    columns = {{ columns }},
-    rows = {{ rows }},
-    compat = valid_class,
-    fns = num_fmt_factory_multi(
-      pattern = pattern,
-      format_fn = function(x, context) {
-
-        # Create the `suffix_df` object
-        suffix_df <-
-          create_suffix_df(
-            x,
-            decimals = decimals,
-            suffix_labels = suffix_labels,
-            scale_by = scale_by,
-            system = system
-          )
-
-        # Determine whether `scale_by` is supplied as a function; if it isn't
-        # the only other pathway involves getting the vector of values produced
-        # by the `create_suffix_df()` function
-        if (rlang::is_function(scale_by)) {
-          to_scale_by <- scale_by
-        } else {
-          to_scale_by <- suffix_df$scale_by
-        }
-
-        # Scale the `x` values using `to_scale_by` (either a function or
-        # a numeric vector)
-        x <- scale_x_values(x, scale_by = to_scale_by)
-
-        # Format numeric values to character-based numbers
-        x_str <-
-          format_num_to_str(
-            x,
-            context = context,
-            decimals = decimals,
-            n_sigfig = n_sigfig,
-            sep_mark = sep_mark,
-            dec_mark = dec_mark,
-            drop_trailing_zeros = drop_trailing_zeros,
-            drop_trailing_dec_mark = drop_trailing_dec_mark,
-            format = formatC_format,
-            system = system
-          )
-
-        # Paste the vector of suffixes to the right of the values
-        x_str <- paste_right(x_str, x_right = suffix_df$suffix)
-
-        # Format values in accounting notation (if `accounting = TRUE`)
-        x_str <-
-          format_as_accounting(
-            x_str,
-            x = x,
-            context = context,
-            accounting = accounting
-          )
-
-        # Force a positive sign on certain values if the option is taken
-        if (!accounting && force_sign) {
-
-          positive_x <- !is.na(x) & x > 0
-          x_str[positive_x] <- paste_left(x_str[positive_x], x_left = "+")
-        }
-
-        x_str
-      }
-    )
-  )
-}
-
-#' Format values as integers
-#'
-#' @description
-#'
-#' With numeric values in a **gt** table, we can perform number-based
-#' formatting so that the targeted values are always rendered as integer values.
-#' We can have fine control over integer formatting with the following options:
-#'
-#' - digit grouping separators: options to enable/disable digit separators
-#' and provide a choice of separator symbol
-#' - scaling: we can choose to scale targeted values by a multiplier value
-#' - large-number suffixing: larger figures (thousands, millions, etc.) can
-#' be autoscaled and decorated with the appropriate suffixes
-#' - pattern: option to use a text pattern for decoration of the formatted
-#' values
-#' - locale-based formatting: providing a locale ID will result in number
-#' formatting specific to the chosen locale
-#'
-#' @inheritParams fmt_number
-#'
-#' @param suffixing *Specification for large-number suffixing*
-#'
-#'   `scalar<logical>|vector<character>` // *default:* `FALSE`
-#'
-#'   The `suffixing` option allows us to scale and apply suffixes to larger
-#'   numbers (e.g., `1924000` can be transformed to `2M`). This option can
-#'   accept a logical value, where `FALSE` (the default) will not perform this
-#'   transformation and `TRUE` will apply thousands (`K`), millions (`M`),
-#'   billions (`B`), and trillions (`T`) suffixes after automatic value scaling.
-#'
-#'   We can alternatively provide a character vector that serves as a
-#'   specification for which symbols are to used for each of the value ranges.
-#'   These preferred symbols will replace the defaults (e.g.,
-#'   `c("k", "Ml", "Bn", "Tr")` replaces `"K"`, `"M"`, `"B"`, and `"T"`).
-#'
-#'   Including `NA` values in the vector will ensure that the particular range
-#'   will either not be included in the transformation (e.g.,
-#'   `c(NA, "M", "B", "T")` won't modify numbers at all in the thousands range)
-#'   or the range will inherit a previous suffix (e.g., with
-#'   `c("K", "M", NA, "T")`, all numbers in the range of millions and billions
-#'   will be in terms of millions).
-#'
-#'   Any use of `suffixing` (where it is not set expressly as `FALSE`) means
-#'   that any value provided to `scale_by` will be ignored.
-#'
-#'   If using `system = "ind"` then the default suffix set provided by
-#'   `suffixing = TRUE` will be the equivalent of `c(NA, "L", "Cr")`. This
-#'   doesn't apply suffixes to the thousands range, but does express values in
-#'   *lakhs* and *crores*.
-#'
-#' @return An object of class `gt_tbl`.
-#'
-#' @section Compatibility of formatting function with data values:
-#'
-#' `fmt_integer()` is compatible with body cells that are of the `"numeric"` or
-#' `"integer"` types. Any other types of body cells are ignored during
-#' formatting. This is to say that cells of incompatible data types may be
-#' targeted, but there will be no attempt to format them.
-#'
-#' @section Targeting cells with `columns` and `rows`:
-#'
-#' Targeting of values is done through `columns` and additionally by `rows` (if
-#' nothing is provided for `rows` then entire columns are selected). The
-#' `columns` argument allows us to target a subset of cells contained in the
-#' resolved columns. We say resolved because aside from declaring column names
-#' in `c()` (with bare column names or names in quotes) we can use
-#' **tidyselect**-style expressions. This can be as basic as supplying a select
-#' helper like `starts_with()`, or, providing a more complex incantation like
-#'
-#' `where(~ is.numeric(.x) && max(.x, na.rm = TRUE) > 1E6)`
-#'
-#' which targets numeric columns that have a maximum value greater than
-#' 1,000,000 (excluding any `NA`s from consideration).
-#'
-#' By default all columns and rows are selected (with the `everything()`
-#' defaults). Cell values that are incompatible with a given formatting function
-#' will be skipped over, like `character` values and numeric `fmt_*()`
-#' functions. So it's safe to select all columns with a particular formatting
-#' function (only those values that can be formatted will be formatted), but,
-#' you may not want that. One strategy is to format the bulk of cell values with
-#' one formatting function and then constrain the columns for later passes with
-#' other types of formatting (the last formatting done to a cell is what you get
-#' in the final output).
-#'
-#' Once the columns are targeted, we may also target the `rows` within those
-#' columns. This can be done in a variety of ways. If a stub is present, then we
-#' potentially have row identifiers. Those can be used much like column names in
-#' the `columns`-targeting scenario. We can use simpler **tidyselect**-style
-#' expressions (the select helpers should work well here) and we can use quoted
-#' row identifiers in `c()`. It's also possible to use row indices (e.g.,
-#' `c(3, 5, 6)`) though these index values must correspond to the row numbers of
-#' the input data (the indices won't necessarily match those of rearranged rows
-#' if row groups are present). One more type of expression is possible, an
-#' expression that takes column values (can involve any of the available columns
-#' in the table) and returns a logical vector. This is nice if you want to base
-#' formatting on values in the column or another column, or, you'd like to use a
-#' more complex predicate expression.
-#'
-#' @section Compatibility of arguments with the `from_column()` helper function:
-#'
-#' [from_column()] can be used with certain arguments of  `fmt_integer()` to
-#' obtain varying parameter values from a specified column within the table.
-#' This means that each row could be formatted a little bit differently. These
-#' arguments provide support for [from_column()]:
-#'
-#' - `use_seps`
-#' - `accounting`
-#' - `scale_by`
-#' - `suffixing`
-#' - `pattern`
-#' - `sep_mark`
-#' - `force_sign`
-#' - `system`
-#' - `locale`
-#'
-#' Please note that for all of the aforementioned arguments, a [from_column()]
-#' call needs to reference a column that has data of the correct type (this is
-#' different for each argument). Additional columns for parameter values can be
-#' generated with [cols_add()] (if not already present). Columns that contain
-#' parameter data can also be hidden from final display with [cols_hide()].
-#' Finally, there is no limitation to how many arguments the [from_column()]
-#' helper is applied so long as the arguments belong to this closed set.
-#'
-#' @section Adapting output to a specific `locale`:
-#'
-#' This formatting function can adapt outputs according to a provided `locale`
-#' value. Examples include `"en"` for English (United States) and `"fr"` for
-#' French (France). The use of a valid locale ID here means separator marks will
-#' be correct for the given locale. Should any value be provided in `sep_mark`,
-#' it will be overridden by the locale's preferred value.
-#'
-#' Note that a `locale` value provided here will override any global locale
-#' setting performed in [gt()]'s own `locale` argument (it is settable there as
-#' a value received by all other functions that have a `locale` argument). As a
-#' useful reference on which locales are supported, we can call [info_locales()]
-#' to view an info table.
-#'
-#' @section Examples:
-#'
-#' For this example, we'll use two columns from the [`exibble`] dataset and
-#' create a simple **gt** table. With `fmt_integer()`, we'll format the `num`
-#' column as integer values having no digit separators (with the
-#' `use_seps = FALSE` option).
-#'
-#' ```r
-#' exibble |>
-#'   dplyr::select(num, char) |>
-#'   gt() |>
-#'   fmt_integer(use_seps = FALSE)
-#' ```
-#'
-#' \if{html}{\out{
-#' `r man_get_image_tag(file = "man_fmt_integer_1.png")`
-#' }}
-#'
-#' Let's use a modified version of the [`countrypops`] dataset to create a
-#' **gt** table with row labels. We will format all numeric columns with
-#' `fmt_integer()` and scale all values by `1 / 1E6`, giving us integer values
-#' representing millions of people. We can make clear what the values represent
-#' with an informative spanner label via [tab_spanner()].
-#'
-#' ```r
-#' countrypops |>
-#'   dplyr::select(country_code_3, year, population) |>
-#'   dplyr::filter(country_code_3 %in% c("CHN", "IND", "USA", "PAK", "IDN")) |>
-#'   dplyr::filter(year > 1975 & year %% 5 == 0) |>
-#'   tidyr::spread(year, population) |>
-#'   dplyr::arrange(desc(`2015`)) |>
-#'   gt(rowname_col = "country_code_3") |>
-#'   fmt_integer(scale_by = 1 / 1E6) |>
-#'   tab_spanner(label = "Millions of People", columns = everything())
-#' ```
-#'
-#' \if{html}{\out{
-#' `r man_get_image_tag(file = "man_fmt_integer_2.png")`
-#' }}
-#'
-#' Using a subset of the [`towny`] dataset, we can do interesting things with
-#' integer values. Through [cols_add()] we'll add the `difference` column (which
-#' calculates the difference between 2021 and 2001 populations). All numeric
-#' values will be formatted with a first pass of `fmt_integer()`; a second pass
-#' of `fmt_integer()` focuses on the `difference` column and here we use the
-#' `force_sign = TRUE` option to draw attention to positive and negative
-#' difference values.
-#'
-#' ```r
-#' towny |>
-#'   dplyr::select(name, population_2001, population_2021) |>
-#'   dplyr::slice_tail(n = 10) |>
-#'   gt() |>
-#'   cols_add(difference = population_2021 - population_2001) |>
-#'   fmt_integer() |>
-#'   fmt_integer(columns = difference, force_sign = TRUE) |>
-#'   cols_label_with(fn = function(x) gsub("population_", "", x)) |>
-#'   tab_style(
-#'     style = cell_fill(color = "gray90"),
-#'     locations = cells_body(columns = difference)
-#'   )
-#' ```
-#'
-#' \if{html}{\out{
-#' `r man_get_image_tag(file = "man_fmt_integer_3.png")`
-#' }}
-#'
-#' @family data formatting functions
-#' @section Function ID:
-#' 3-2
-#'
-#' @section Function Introduced:
-#' `v0.3.1` (August 9, 2021)
-#'
-#' @seealso
-#' Format number with decimal values: [fmt_number()]
-#'
-#' The vector-formatting version of this function: [vec_fmt_integer()]
-#'
-#' @export
-fmt_integer <- function(
-    data,
-    columns = everything(),
-    rows = everything(),
-    use_seps = TRUE,
-    accounting = FALSE,
-    scale_by = 1.0,
-    suffixing = FALSE,
-    pattern = "{x}",
-    sep_mark = ",",
-    force_sign = FALSE,
-    system = c("intl", "ind"),
-    locale = NULL
-) {
-
-  # Perform input object validation
-  stop_if_not_gt_tbl(data = data)
-
-  #
-  # Begin support for `from_column()` objects passed to compatible arguments
-  #
-
-  # Supports parameters:
-  #
-  # - use_seps
-  # - accounting
-  # - scale_by
-  # - suffixing
-  # - pattern
-  # - sep_mark
-  # - force_sign
-  # - system
-  # - locale
-
-  arg_vals <-
-    mget(
-      get_arg_names(
-        function_name = "fmt_integer",
-        all_args_except = c("data", "columns", "rows")
-      )
-    )
-
-  if (args_have_gt_column_obj(arg_vals = arg_vals)) {
-
-    # Resolve the row numbers using `resolve_vars()`
-    resolved_rows_idx <-
-      resolve_rows_i(
-        expr = {{ rows }},
-        data = data
-      )
-
-    param_tbl <-
-      generate_param_tbl(
-        data = data,
-        arg_vals = arg_vals,
-        resolved_rows_idx = resolved_rows_idx
-      )
-
-    for (i in seq_len(nrow(param_tbl))) {
-
-      p_i <- as.list(param_tbl[i, ])
-
-      data <-
-        fmt_integer(
-          data = data,
-          columns = {{ columns }},
-          rows = resolved_rows_idx[i],
-          use_seps = p_i$use_seps %||% use_seps,
-          accounting = p_i$accounting %||% accounting,
-          scale_by = p_i$scale_by %||% scale_by,
-          suffixing = p_i$suffixing %||% suffixing,
-          pattern = p_i$pattern %||% pattern,
-          sep_mark = p_i$sep_mark %||% sep_mark,
-          force_sign = p_i$force_sign %||% force_sign,
-          system = p_i$system %||% system,
-          locale = p_i$locale %||% locale
-        )
-    }
-
-    return(data)
-  }
-
-  #
-  # End support for `from_column()` objects passed to compatible arguments
-  #
-
-  fmt_number(
-    data = data,
-    columns = {{ columns }},
-    rows = {{ rows }},
-    decimals = 0,
-    n_sigfig = NULL,
-    drop_trailing_zeros = FALSE,
-    drop_trailing_dec_mark = TRUE,
-    use_seps = use_seps,
-    accounting = accounting,
-    scale_by = scale_by,
-    suffixing = suffixing,
-    pattern = pattern,
-    sep_mark = sep_mark,
-    dec_mark = "not used",
-    force_sign = force_sign,
-    system = system,
-    locale = locale
-  )
-}
-
 #' Format values to scientific notation
 #'
 #' @description

From 90883dbdf83f0864710e9eb4a5c14c9ed54d4b4f Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Fri, 12 Jul 2024 09:03:47 -0400
Subject: [PATCH 26/28] Reduce pipe usage [ci skip]

---
 ...attr_expectations.R => helper-gt_object.R} | 62 +++++--------------
 1 file changed, 16 insertions(+), 46 deletions(-)
 rename tests/testthat/{helper-gt_attr_expectations.R => helper-gt_object.R} (76%)

diff --git a/tests/testthat/helper-gt_attr_expectations.R b/tests/testthat/helper-gt_object.R
similarity index 76%
rename from tests/testthat/helper-gt_attr_expectations.R
rename to tests/testthat/helper-gt_object.R
index 7988803298..9e4a43c59e 100644
--- a/tests/testthat/helper-gt_attr_expectations.R
+++ b/tests/testthat/helper-gt_object.R
@@ -49,7 +49,7 @@ expect_tab <- function(tab, df) {
   # Expect certain named attributes
   expect_gt_attr_names(object = tab)
 
-  # Expect that the attribute obejcts are of certain classes
+  # Validate attributes classes
   expect_s3_class(dt_boxhead_get(data = tab), "data.frame")
   expect_type(dt_stub_df_get(data = tab), "list")
   expect_type(dt_row_groups_get(data = tab), "character")
@@ -65,47 +65,20 @@ expect_tab <- function(tab, df) {
   expect_s3_class(dt_options_get(data = tab), "data.frame")
   expect_type(dt_transforms_get(data = tab), "list")
 
-  (dt_boxhead_get(data = tab) %>%
-    dim())[2] %>%
-    expect_equal(8)
-
-  dt_stub_df_get(data = tab) %>%
-    dim() %>%
-    expect_equal(c(nrow(df), 6))
-
-  dt_heading_get(data = tab) %>%
-    expect_length(3)
-
-  dt_spanners_get(data = tab) %>%
-    dim() %>%
-    expect_equal(c(0, 8))
-
-  dt_stubhead_get(data = tab) %>%
-    expect_length(1)
-
-  dt_footnotes_get(data = tab) %>%
-    dim() %>%
-    expect_equal(c(0, 8))
-
-  dt_source_notes_get(data = tab) %>%
-    expect_length(0)
-
-  dt_formats_get(data = tab) %>%
-    expect_length(0)
-
-  dt_substitutions_get(data = tab) %>%
-    expect_length(0)
-
-  dt_styles_get(data = tab) %>%
-    dim() %>%
-    expect_equal(c(0, 7))
-
-  dt_options_get(data = tab) %>%
-    dim() %>%
-    expect_equal(c(191, 5))
-
-  dt_transforms_get(data = tab) %>%
-    expect_length(0)
+  # Validate attributes dimensions
+  expect_equal(ncol(dt_boxhead_get(data = tab)), 8)
+  expect_equal(dim(dt_stub_df_get(data = tab)), c(nrow(df), 6))
+  expect_length(dt_heading_get(data = tab), 3)
+  expect_equal(dim(dt_spanners_get(data = tab)), c(0, 8))
+  expect_length(dt_stubhead_get(data = tab), 1)
+  expect_equal(dim(dt_footnotes_get(data = tab)), c(0, 8))
+  expect_length(dt_source_notes_get(data = tab), 0)
+  expect_length(dt_formats_get(data = tab), 0)
+  expect_length(dt_substitutions_get(data = tab), 0)
+  expect_equal(dim(dt_styles_get(data = tab)), c(0, 7))
+  # If adding a new option to tab_options(), update here
+  expect_equal(dim(dt_options_get(data = tab)), c(191, 5))
+  expect_length(dt_transforms_get(data = tab), 0)
 
   # Expect that extracted df has the same column
   # names as the original dataset (or a difference of 1)
@@ -135,10 +108,7 @@ expect_attr_equal <- function(data, attr_val, y) {
 
   obj <- dt__get(data = data, key = attr_val)
 
-  obj %>%
-    unlist() %>%
-    unname() %>%
-    expect_equal(y)
+  expect_equal(unlist(obj), y, ignore_attr = "names")
 }
 
 gt_attr_names <- function() {

From 8bd3f9c79c6bee4392f4d720a17f88e12ec1548b Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Fri, 12 Jul 2024 11:27:55 -0400
Subject: [PATCH 27/28] Update man

---
 man/fmt.Rd         | 2 +-
 man/fmt_integer.Rd | 2 +-
 man/fmt_number.Rd  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/man/fmt.Rd b/man/fmt.Rd
index 3837b5ee72..5de021ebd5 100644
--- a/man/fmt.Rd
+++ b/man/fmt.Rd
@@ -1,5 +1,5 @@
 % Generated by roxygen2: do not edit by hand
-% Please edit documentation in R/format_data.R
+% Please edit documentation in R/fmt.R
 \name{fmt}
 \alias{fmt}
 \title{Set a column format with a formatter function}
diff --git a/man/fmt_integer.Rd b/man/fmt_integer.Rd
index a9581bcf3f..e6af49dc68 100644
--- a/man/fmt_integer.Rd
+++ b/man/fmt_integer.Rd
@@ -1,5 +1,5 @@
 % Generated by roxygen2: do not edit by hand
-% Please edit documentation in R/format_data.R
+% Please edit documentation in R/fmt_number.R
 \name{fmt_integer}
 \alias{fmt_integer}
 \title{Format values as integers}
diff --git a/man/fmt_number.Rd b/man/fmt_number.Rd
index 9f8ac477c8..23c57620bd 100644
--- a/man/fmt_number.Rd
+++ b/man/fmt_number.Rd
@@ -1,5 +1,5 @@
 % Generated by roxygen2: do not edit by hand
-% Please edit documentation in R/format_data.R
+% Please edit documentation in R/fmt_number.R
 \name{fmt_number}
 \alias{fmt_number}
 \title{Format numeric values}

From d9dadcffbd0cba95ce410569433323ec8ec9b0d5 Mon Sep 17 00:00:00 2001
From: olivroy <olivierroy71@hotmail.com>
Date: Fri, 12 Jul 2024 15:51:15 -0400
Subject: [PATCH 28/28] Use double quotes

---
 tests/testthat/test-as_latex.R | 190 ++++++++++++++++-----------------
 1 file changed, 95 insertions(+), 95 deletions(-)

diff --git a/tests/testthat/test-as_latex.R b/tests/testthat/test-as_latex.R
index 74e5aa999a..d527195199 100644
--- a/tests/testthat/test-as_latex.R
+++ b/tests/testthat/test-as_latex.R
@@ -23,7 +23,7 @@ test_that("Table width correctly output in LaTeX using longtable", {
   # Test specification of a table width in pixels
   gt_latex_width_2 <-
     gt(exibble) %>%
-    tab_options(table.width = '600px', latex.use.longtable = TRUE) %>%
+    tab_options(table.width = "600px", latex.use.longtable = TRUE) %>%
     as_latex()
 
   expect_match(gt_latex_width_2, "\\\\setlength\\\\LTleft\\{\\\\dimexpr\\(0.5\\\\linewidth - 225pt\\)\\}")
@@ -66,83 +66,83 @@ test_that("Table styles correctly applied for longtable", {
 
   gt_latex_styled <-
     gt(exibble[1:5, c(1:3, 5:9)],
-     rowname_col = 'row',
-     groupname_col = 'group') %>%
-    tab_stubhead(label = 'stubhead') %>%
+     rowname_col = "row",
+     groupname_col = "group") %>%
+    tab_stubhead(label = "stubhead") %>%
     tab_stub_indent(rows = everything(),
-                    indent = 'increase') %>%
-    tab_spanner(label = 'heading',
-                id = 'a1',
+                    indent = "increase") %>%
+    tab_spanner(label = "heading",
+                id = "a1",
                 columns = 1:3) %>%
-    tab_spanner(label = 'heading',
-                id = 'b2',
+    tab_spanner(label = "heading",
+                id = "b2",
                 columns = 5:6) %>%
-    summary_rows(fns = list(list(label = 'Total', fn = 'sum'),
-                            list(label = 'Avg', fn = 'mean')),
-                 columns = c('num', 'currency'),
-                 groups = 'grp_a',
+    summary_rows(fns = list(list(label = "Total", fn = "sum"),
+                            list(label = "Avg", fn = "mean")),
+                 columns = c("num", "currency"),
+                 groups = "grp_a",
                  fmt = ~ fmt_number(., use_seps = TRUE)) %>%
-    grand_summary_rows(fns =list(list(label = 'grand total', fn = 'sum')),
-                       columns = c('num', 'currency'),
+    grand_summary_rows(fns =list(list(label = "grand total", fn = "sum")),
+                       columns = c("num", "currency"),
                        fmt = ~ fmt_number(., use_seps = TRUE)) %>%
     tab_footnote(footnote = "This is a footnote. With a second line.",
-                 locations = cells_body(columns = 'time', rows = 3L)) %>%
+                 locations = cells_body(columns = "time", rows = 3L)) %>%
     tab_footnote(footnote = "This is a footnote in the column labels.",
-                 locations = cells_column_labels(columns = 'fctr')) %>%
-    tab_source_note(source_note = 'NOTES:  A mtcars example.') %>%
+                 locations = cells_column_labels(columns = "fctr")) %>%
+    tab_source_note(source_note = "NOTES:  A mtcars example.") %>%
     # Table formatting with tab_style
-    tab_style(style = cell_text(decorate = 'overline'),
+    tab_style(style = cell_text(decorate = "overline"),
               locations = cells_stubhead()) %>%
-    tab_style(style = cell_text(transform = 'uppercase'),
-              locations = cells_column_labels(columns = c('num', 'fctr', 'datetime'))) %>%
-    tab_style(style = gt::cell_text(style = 'italic'),
-              locations = cells_column_spanners(spanners = 'a1')) %>%
+    tab_style(style = cell_text(transform = "uppercase"),
+              locations = cells_column_labels(columns = c("num", "fctr", "datetime"))) %>%
+    tab_style(style = gt::cell_text(style = "italic"),
+              locations = cells_column_spanners(spanners = "a1")) %>%
 
     # Body styles
     tab_style(style = cell_text(size = 20,
-                                decorate = 'underline',
-                                color = 'red'),
-              locations = cells_body(columns = 'time',
+                                decorate = "underline",
+                                color = "red"),
+              locations = cells_body(columns = "time",
                                      rows = c(3:4))) %>%
     tab_style(style = cell_text(indent = px(20),
-                                weight = 'bold'),
-              locations = cells_body(columns = 'char',
+                                weight = "bold"),
+              locations = cells_body(columns = "char",
                                      rows = c(2L, 4L, 5L))) %>%
     tab_style(style = cell_text(indent = px(15),
-                                style = 'oblique'),
+                                style = "oblique"),
               locations = cells_stub(rows = c(2L, 4L, 5L))) %>%
     tab_style(style = cell_text(size = 20L,
-                                color = '#0000FF'),
-              locations = cells_body(columns = 'fctr')) %>%
-    tab_style(style = list(cell_text(weight = 'bold'),
-                           cell_fill(color = '#CCCCFF')),
-              locations = cells_row_groups(groups = 'grp_b')) %>%
-    tab_style(style = cell_text(size = 'x-small'),
-              locations = cells_body(columns = 'datetime')) %>%
-    tab_style(style = list(cell_text(color = '#FFFFFF'),
-                           cell_fill(color = '#AA0000')),
+                                color = "#0000FF"),
+              locations = cells_body(columns = "fctr")) %>%
+    tab_style(style = list(cell_text(weight = "bold"),
+                           cell_fill(color = "#CCCCFF")),
+              locations = cells_row_groups(groups = "grp_b")) %>%
+    tab_style(style = cell_text(size = "x-small"),
+              locations = cells_body(columns = "datetime")) %>%
+    tab_style(style = list(cell_text(color = "#FFFFFF"),
+                           cell_fill(color = "#AA0000")),
               locations = cells_stub()) %>%
     # Footnoe and source note styles
     tab_style(style = cell_text(size = 8,
-                                style = 'italic'),
+                                style = "italic"),
               locations = cells_source_notes()) %>%
-    tab_style(style = cell_text(weight = 'bold'),
+    tab_style(style = cell_text(weight = "bold"),
               locations = cells_footnotes()) %>%
 
     # Summary styles
-    tab_style(style = cell_fill(color = '#00FF00'),
-              locations = cells_summary(groups = 'grp_a',
-                                        columns = c('num', 'currency'),
+    tab_style(style = cell_fill(color = "#00FF00"),
+              locations = cells_summary(groups = "grp_a",
+                                        columns = c("num", "currency"),
                                         rows = 2L)) %>%
-    tab_style(style = cell_text(color = '#00FF00'),
-              locations = cells_stub_summary(groups = 'grp_a',
+    tab_style(style = cell_text(color = "#00FF00"),
+              locations = cells_stub_summary(groups = "grp_a",
                                              rows = 1L)) %>%
 
     # Grand summary styles
-    tab_style(style = cell_text(transform = 'capitalize',
-                                weight = 'bold'),
+    tab_style(style = cell_text(transform = "capitalize",
+                                weight = "bold"),
               locations = cells_stub_grand_summary()) %>%
-    tab_style(style = cell_fill(color = '#AAAAAA'),
+    tab_style(style = cell_fill(color = "#AAAAAA"),
               locations = cells_grand_summary()) %>%
     tab_options(latex.use.longtable = TRUE) %>%
     as_latex() %>%
@@ -154,83 +154,83 @@ test_that("Table styles correctly applied for tabular*", {
 
   gt_latex_styled <-
     gt(exibble[1:5, c(1:3, 5:9)],
-       rowname_col = 'row',
-       groupname_col = 'group') %>%
-    tab_stubhead(label = 'stubhead') %>%
+       rowname_col = "row",
+       groupname_col = "group") %>%
+    tab_stubhead(label = "stubhead") %>%
     tab_stub_indent(rows = everything(),
-                    indent = 'increase') %>%
-    tab_spanner(label = 'heading',
-                id = 'a1',
+                    indent = "increase") %>%
+    tab_spanner(label = "heading",
+                id = "a1",
                 columns = 1:3) %>%
-    tab_spanner(label = 'heading',
-                id = 'b2',
+    tab_spanner(label = "heading",
+                id = "b2",
                 columns = 5:6) %>%
-    summary_rows(fns = list(list(label = 'Total', fn = 'sum'),
-                            list(label = 'Avg', fn = 'mean')),
-                 columns = c('num', 'currency'),
-                 groups = 'grp_a',
+    summary_rows(fns = list(list(label = "Total", fn = "sum"),
+                            list(label = "Avg", fn = "mean")),
+                 columns = c("num", "currency"),
+                 groups = "grp_a",
                  fmt = ~ fmt_number(., use_seps = TRUE)) %>%
-    grand_summary_rows(fns =list(list(label = 'grand total', fn = 'sum')),
-                       columns = c('num', 'currency'),
+    grand_summary_rows(fns =list(list(label = "grand total", fn = "sum")),
+                       columns = c("num", "currency"),
                        fmt = ~ fmt_number(., use_seps = TRUE)) %>%
     tab_footnote(footnote = "This is a footnote. With a second line.",
-                 locations = cells_body(columns = 'time', rows = 3L)) %>%
+                 locations = cells_body(columns = "time", rows = 3L)) %>%
     tab_footnote(footnote = "This is a footnote in the column labels.",
-                 locations = cells_column_labels(columns = 'fctr')) %>%
-    tab_source_note(source_note = 'NOTES:  A mtcars example.') %>%
+                 locations = cells_column_labels(columns = "fctr")) %>%
+    tab_source_note(source_note = "NOTES:  A mtcars example.") %>%
     # Table formatting with tab_style
-    tab_style(style = cell_text(decorate = 'overline'),
+    tab_style(style = cell_text(decorate = "overline"),
               locations = cells_stubhead()) %>%
-    tab_style(style = cell_text(transform = 'uppercase'),
-              locations = cells_column_labels(columns = c('num', 'fctr', 'datetime'))) %>%
-    tab_style(style = gt::cell_text(style = 'italic'),
-              locations = cells_column_spanners(spanner = 'a1')) %>%
+    tab_style(style = cell_text(transform = "uppercase"),
+              locations = cells_column_labels(columns = c("num", "fctr", "datetime"))) %>%
+    tab_style(style = gt::cell_text(style = "italic"),
+              locations = cells_column_spanners(spanner = "a1")) %>%
 
     # Body styles
     tab_style(style = cell_text(size = 20,
-                                decorate = 'underline',
-                                color = 'red'),
-              locations = cells_body(columns = 'time',
+                                decorate = "underline",
+                                color = "red"),
+              locations = cells_body(columns = "time",
                                      rows = c(3:4))) %>%
     tab_style(style = cell_text(indent = px(20),
-                                weight = 'bold'),
-              locations = cells_body(columns = 'char',
+                                weight = "bold"),
+              locations = cells_body(columns = "char",
                                      rows = c(2L, 4L, 5L))) %>%
     tab_style(style = cell_text(indent = px(15),
-                                style = 'oblique'),
+                                style = "oblique"),
               locations = cells_stub(rows = c(2L, 4L, 5L))) %>%
     tab_style(style = cell_text(size = 20L,
-                                color = '#0000FF'),
-              locations = cells_body(columns = 'fctr')) %>%
-    tab_style(style = list(cell_text(weight = 'bold'),
-                           cell_fill(color = '#CCCCFF')),
-              locations = cells_row_groups(groups = 'grp_b')) %>%
-    tab_style(style = cell_text(size = 'x-small'),
-              locations = cells_body(columns = 'datetime')) %>%
-    tab_style(style = list(cell_text(color = '#FFFFFF'),
-                           cell_fill(color = '#AA0000')),
+                                color = "#0000FF"),
+              locations = cells_body(columns = "fctr")) %>%
+    tab_style(style = list(cell_text(weight = "bold"),
+                           cell_fill(color = "#CCCCFF")),
+              locations = cells_row_groups(groups = "grp_b")) %>%
+    tab_style(style = cell_text(size = "x-small"),
+              locations = cells_body(columns = "datetime")) %>%
+    tab_style(style = list(cell_text(color = "#FFFFFF"),
+                           cell_fill(color = "#AA0000")),
               locations = cells_stub()) %>%
     # Footnoe and source note styles
     tab_style(style = cell_text(size = 8,
-                                style = 'italic'),
+                                style = "italic"),
               locations = cells_source_notes()) %>%
-    tab_style(style = cell_text(weight = 'bold'),
+    tab_style(style = cell_text(weight = "bold"),
               locations = cells_footnotes()) %>%
 
     # Summary styles
-    tab_style(style = cell_fill(color = '#00FF00'),
-              locations = cells_summary(groups = 'grp_a',
-                                        columns = c('num', 'currency'),
+    tab_style(style = cell_fill(color = "#00FF00"),
+              locations = cells_summary(groups = "grp_a",
+                                        columns = c("num", "currency"),
                                         rows = 2L)) %>%
-    tab_style(style = cell_text(color = '#00FF00'),
-              locations = cells_stub_summary(groups = 'grp_a',
+    tab_style(style = cell_text(color = "#00FF00"),
+              locations = cells_stub_summary(groups = "grp_a",
                                              rows = 1L)) %>%
 
     # Grand summary styles
-    tab_style(style = cell_text(transform = 'capitalize',
-                                weight = 'bold'),
+    tab_style(style = cell_text(transform = "capitalize",
+                                weight = "bold"),
               locations = cells_stub_grand_summary()) %>%
-    tab_style(style = cell_fill(color = '#AAAAAA'),
+    tab_style(style = cell_fill(color = "#AAAAAA"),
               locations = cells_grand_summary()) %>%
     tab_options(latex.use.longtable = FALSE) %>%
     as_latex() %>%