Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of the fenced code blocks #58

Closed
2 tasks
oniboni opened this issue May 16, 2024 · 0 comments · Fixed by #65
Closed
2 tasks

Improve handling of the fenced code blocks #58

oniboni opened this issue May 16, 2024 · 0 comments · Fixed by #65

Comments

@oniboni
Copy link
Collaborator

oniboni commented May 16, 2024

Description

The plugin does not cover the current spec of Fenced code blocks1

Background

This issue was initially raised and solved by @nolange 23

Supports whitespace after the fence. ex:

stuff

Support more than 3 ticks or tildes for code blocks, this is still only a part of the variations in the wilds [1]

Finds the correct matching ending fence by using identation, this required adding some more groups to the regexp and the option MULTILINE. ex.

```` plantuml
    stuff containing ```
````

[1] - https://pandoc.org/MANUAL.html#fenced-code-blocks

[..]

Definition of Done

Footnotes

  1. https://spec.commonmark.org/0.31.2/#fenced-code-blocks 2

  2. support whitespace after fenced block #34

  3. Improve handling of the fenced code blocks #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant