Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMS Karras introduces noise when done #1973

Closed
guzuligo opened this issue Oct 8, 2022 · 10 comments
Closed

LMS Karras introduces noise when done #1973

guzuligo opened this issue Oct 8, 2022 · 10 comments
Labels
bug-report Report of a bug, yet to be confirmed upstream Issue or feature that must be resolved upstream

Comments

@guzuligo
Copy link

guzuligo commented Oct 8, 2022

Describe the bug
When using LMS Karras with high sampling number, it produces noise on the image right when it is done, ruining the image it produced.

To Reproduce
Try using the following prompt.

banana AND car
Steps: 70, Sampler: LMS Karras, CFG scale: 7, Seed: 1745286955, Size: 576x320

@guzuligo guzuligo added the bug-report Report of a bug, yet to be confirmed label Oct 8, 2022
@HanJammer
Copy link

HanJammer commented Oct 8, 2022

Yes, I noticed it yesterday too when testing different samplers (with 50 steps).

@dfaker
Copy link
Collaborator

dfaker commented Oct 8, 2022

The extended sampler settings using Karras in the UI are best approximations of good default parameters.
If you'd like to experiment with https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Custom-Scripts#alternate-noise-schedules you may find better parameters.

@dfaker dfaker added enhancement New feature or request question Further information is requested and removed bug-report Report of a bug, yet to be confirmed labels Oct 8, 2022
@Adil3tr
Copy link

Adil3tr commented Oct 12, 2022

I've had the same issue. I was making images with LMS at 20 CFG and 50 steps and having no issues for weeks, but today I make ones at 12 CFG and 60 steps and I'm still getting artifacts. There is definitely something wrong.

@Adil3tr
Copy link

Adil3tr commented Oct 12, 2022

The extended sampler settings using Karras in the UI are best approximations of good default parameters. If you'd like to experiment with https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Custom-Scripts#alternate-noise-schedules you may find better parameters.

This is a real issue, LMS should not be doing this and didn't until very recently.

@dfaker dfaker added the bug-report Report of a bug, yet to be confirmed label Oct 12, 2022
@dfaker
Copy link
Collaborator

dfaker commented Oct 12, 2022

This is a real issue, LMS should not be doing this and didn't until very recently.

That's an important distinction, I'll try to hunt down some old reference generations.

@aeloi
Copy link

aeloi commented Oct 16, 2022

I've also had this issue as of late...

@quasiblob
Copy link

This seems to be happing still, and I have pulled the latest version.

@Adil3tr
Copy link

Adil3tr commented Dec 7, 2022

If it's not fixable, they should maybe remove LMS from Automatic, because it has really serious artifacting most of the time right now.

@TheOnlyHolyMoly
Copy link

TheOnlyHolyMoly commented Jun 25, 2023

Does the issue persist in the current version? Can anyone provide a commit-hash from a version where this worked (plus image generation parameter)? The commit should be recorded in the image's meta data

#2856 looks like there are multiple filed issues around that topic anyhow. #2856 also proposes the solution that Invoke has used for the matter.

@catboxanon catboxanon removed enhancement New feature or request question Further information is requested labels Aug 3, 2023
@catboxanon catboxanon added the upstream Issue or feature that must be resolved upstream label Aug 5, 2023
@catboxanon
Copy link
Collaborator

This is related to k-diffusion specifically. The root issue is the k-diffusion implementation, as ComfyUI has the same issue, so this is not webui related.

Read the comment I have posted there for further info. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug-report Report of a bug, yet to be confirmed upstream Issue or feature that must be resolved upstream
Projects
None yet
Development

No branches or pull requests

8 participants