Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Calling webui-user.bat hangs because python commands are not called with 'call' statement #16205

Open
6 tasks done
stevenengland opened this issue Jul 13, 2024 · 2 comments
Labels
bug-report Report of a bug, yet to be confirmed

Comments

@stevenengland
Copy link

Checklist

  • The issue exists after disabling all extensions
  • The issue exists on a clean installation of webui
  • The issue is caused by an extension, but I believe it is caused by a bug in the webui
  • The issue exists in the current version of the webui
  • The issue has not been reported before recently
  • The issue has been reported before but has not been fixed yet

What happened?

Calling webui-user.bat in a fresh installations hangs forever.

This is due to how python behaves on Windows if python calls are not called with 'call'. The solution is to change all lines where a python command is invoked in webui.bat.

call %PYTHON% -c "" >tmp/stdout.txt 2>tmp/stderr.txt
call %PYTHON% -mpip --help >tmp/stdout.txt 2>tmp/stderr.txt
call %PYTHON% "%PIP_INSTALLER_LOCATION%" >tmp/stdout.txt 2>tmp/stderr.txt
call %PYTHON_FULLNAME% -m venv "%VENV_DIR%" >tmp/stdout.txt 2>tmp/stderr.txt

Steps to reproduce the problem

  1. webui-user.bat

What should have happened?

Webui launch script should make progress and start somewhen

What browsers do you use to access the UI ?

Mozilla Firefox

Sysinfo

Since WebUI doesn't start without help this is not appropriate ;)

I am using python 3.10.5 via pyenv-win on Windows 11 latest.

Console logs

No logs generated in tmp/*, stderr and stdout are empty.

Additional information

nothing to add here.

@stevenengland stevenengland added the bug-report Report of a bug, yet to be confirmed label Jul 13, 2024
@viking1304
Copy link
Contributor

set PYTHON=call python in webui-user.bat is enough. I just tested before I updated my #16261 (comment)

@w-e-w w-e-w mentioned this issue Jul 26, 2024
4 tasks
@yamfun
Copy link

yamfun commented Jul 28, 2024

latest dev branch will stuck on startup after the line "Commit hash", pressing ctrl z after a while show call stacks with bottom lines with "... _wait_for_tstate_lock
if lock.acquire(block, timeout): ...."

switching back to master will not stuck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Report of a bug, yet to be confirmed
Projects
None yet
Development

No branches or pull requests

3 participants