Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Out of memory while using Upscaler #16181

Open
2 of 6 tasks
RoyalXXX opened this issue Jul 9, 2024 · 6 comments
Open
2 of 6 tasks

[Bug]: Out of memory while using Upscaler #16181

RoyalXXX opened this issue Jul 9, 2024 · 6 comments
Labels
bug-report Report of a bug, yet to be confirmed

Comments

@RoyalXXX
Copy link

RoyalXXX commented Jul 9, 2024

Checklist

  • The issue exists after disabling all extensions
  • The issue exists on a clean installation of webui
  • The issue is caused by an extension, but I believe it is caused by a bug in the webui
  • The issue exists in the current version of the webui
  • The issue has not been reported before recently
  • The issue has been reported before but has not been fixed yet

What happened?

Upscaling the image with R-ESRGAN 4x+ (512x512 to 2048x2048) in Hires.fix tab consumes more than 32 GB of memory.
Just don't give me the nonsense that this operation needs that much memory.
Looks like there's some kind of memory leak in the webui.
So much memory is not consumed when upscaling an image in Extras tab.

Steps to reproduce the problem

What should have happened?

What browsers do you use to access the UI ?

Microsoft Edge

Sysinfo

Console logs

-

Additional information

No response

@RoyalXXX RoyalXXX added the bug-report Report of a bug, yet to be confirmed label Jul 9, 2024
@w-e-w
Copy link
Collaborator

w-e-w commented Jul 10, 2024

from what you have written here I don't even know what version of webui you are using
if you want us to have a chance to fixing stuff like this you need to at least provide the basic information that we asked for

@RoyalXXX
Copy link
Author

"Platform": "Windows-10-10.0.22631-SP0",
"Python": "3.10.6",
"Version": "v1.9.4",
"Commit": "feee37d75f1b168768014e4634dcb156ee649c05",
"Commandline": [
"launch.py",
"--use-cpu",
"all",
"--precision",
"full",
"--no-half",
"--skip-torch-cuda-test"
],

@RoyalXXX
Copy link
Author

RoyalXXX commented Jul 10, 2024

It seems to me that the Hires.fix isn't just an Upscaler. I mean that this bug could be explained only by assuming that other complex calculations besides image upscaling take place when Hires.fix is running. Even if this is the case, you need to change the description of this operation on the Hires.fix tab. Because, right now from the description, it seems that this tab just starts the Upscaler after the image is generated.
I'm making this assumption based on the fact that upscaling an image in Extras tab with the same settings requires almost no RAM.
Regarding providing information, I believe the information you are requesting is excessive and not reasonable given my particular situation. The file you are requesting contains a lot of personal data that can't help you in any way to solve the problem. I've already pointed out that:

  • The issue exists on a clean installation of webui
  • The issue exists in the current version of the webui

@highnrgappalachian
Copy link

Massive PEBKAC.

@RoyalXXX
Copy link
Author

Massive PEBKAC.

If this is even the case, the problem is that the UI is misleading.
Capture d'écran 2024-07-13 143044
From the description as well as the controls of this tab, the user gets the feeling that this feature only activates the Upscaler.

@highnrgappalachian
Copy link

highnrgappalachian commented Jul 14, 2024

The only problem here is that you downloaded a software that has been out for a long time and decided to report something as a software issue when you obviously haven't read a single letter from the documentation, alerting the devs to a potential issue.

https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Features#hires-fix

Don't bloat the software's Issues page with your personal problems of reading comprehension, this is used to track legitimate problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Report of a bug, yet to be confirmed
Projects
None yet
Development

No branches or pull requests

3 participants