-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Add-to-prompt in Hires Fix #14055
Comments
I know about this feature. But this is something slightly different that I am suggesting. Basically, right now, if you set "x" in the normal prompt and "y" in the hires fix prompt, the hires fix pass will use "y". What I am suggesting is to add a checkbox or some token like "{prompt}" that would be parsed when using the hires fix prompt, such that: |
I think I get what you mean this should be relatively easy to implement as an extension |
This might be suited to be an extension of the prompt parsing syntax, because it seems like you're immediately going to run into "Wait no I don't want it appended, the attention is stronger at the front. Oh but I do want", and then "Wait but no I wanted this part at the end, because it's a refinement quality and that's okay at the end." and you're basically back to needing to rewrite the prompt in the boxes as pointed out above anyway. But something like the prompt editing syntax where you specify But extending the prompting syntax is going to be a real headache, understandable, maybe there's some inspiration to be found in sd-dynamic-prompts |
I actually do have an extension planned
|
Doesn't the change implemented in #12457 (and described on the wiki page) already allow for this? Something like this would only use
You can of course do the inverse of this if you switch where
|
as I understand it I believe it's more "for convenience" |
Totally forgot about the new behavior for prompt editing. It's probably the best way to do it. No need to introduce more complexity into an already complex project for this. |
Is there an existing issue for this?
What would your feature do ?
Right now we can specify particular prompts for hires fix that replace the prompts used in the first pass.
It would be very nice to be able to add new tokens to the prompt used in the first pass instead (when checking a checkbox, for example).
Why ?
Basically, tokens like "low quality" and other tokens that mostly serve to increase the quality of the picture also have a limitating effect on the variability of the composition of the image.
A typical example is "fantasy landscape, realistic, photorealistic, etc..." add any more prompts to make the picture as realistic as possible. And you end up with a picture that looks like a real photo from our world, and not a realistic photo of a fantasy landscape: instead of having weird mountain ranges for example, you get regular ones.
If you remove these quality tokens, then your picture will get more creative but will also look more fake.
Proposed workflow
or
in settings, next to the settings that enable hires fix prompt/checkpoint also add the checkbox here.
Then, when you can use hires fix prompts like you would with styles, for example: "{prompt}, realistic, photorealistic, ..."
{prompt} referring to the prompt used in the first pass.
Additional information
No response
The text was updated successfully, but these errors were encountered: