Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move sprite transformations from spritesheet class to animation class #11

Open
ASong5 opened this issue Mar 6, 2024 · 0 comments
Open
Labels
refactor Something that needs refactoring (for readability, modularity, efficiency, etc)

Comments

@ASong5
Copy link
Owner

ASong5 commented Mar 6, 2024

i think moving the responsibility of performing sprite transformations to the animation class will allow for more consistently structured set of frames across all spritesheets (i.e., all set of frames would be a 2d list, rather than some having a third component to account for the transformed sprites; instead those would ideally be handled at runtime whenever necessary), thereby lessening the coupling that is currently present between various assets and their respective animations.

@ASong5 ASong5 added the refactor Something that needs refactoring (for readability, modularity, efficiency, etc) label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Something that needs refactoring (for readability, modularity, efficiency, etc)
Projects
None yet
Development

No branches or pull requests

1 participant