diff --git a/agrolib/climate/crit3dElabList.cpp b/agrolib/climate/crit3dElabList.cpp index 54de4d493..c7e9235cd 100644 --- a/agrolib/climate/crit3dElabList.cpp +++ b/agrolib/climate/crit3dElabList.cpp @@ -1,9 +1,9 @@ #include #include #include + #include "crit3dElabList.h" #include "commonConstants.h" -#include "climate.h" Crit3DElabList::Crit3DElabList() diff --git a/agrolib/crit3dDate/crit3dDate.h b/agrolib/crit3dDate/crit3dDate.h index 8d18266cd..10bf8b88e 100644 --- a/agrolib/crit3dDate/crit3dDate.h +++ b/agrolib/crit3dDate/crit3dDate.h @@ -1,9 +1,7 @@ #ifndef CRIT3DDATE_H #define CRIT3DDATE_H - #ifndef _STRING_ - #include - #endif + #include #ifndef HOUR_SECONDS #define HOUR_SECONDS 3600 diff --git a/agrolib/gis/color.cpp b/agrolib/gis/color.cpp index 2ed7ab2f1..ede36c6d2 100644 --- a/agrolib/gis/color.cpp +++ b/agrolib/gis/color.cpp @@ -23,13 +23,13 @@ gantolini@arpae.it */ -#include -#include - #include "commonConstants.h" #include "basicMath.h" #include "color.h" +#include +#include + Crit3DColor::Crit3DColor() { diff --git a/agrolib/gis/geoMap.cpp b/agrolib/gis/geoMap.cpp index dbea8472c..bfeb8bf53 100644 --- a/agrolib/gis/geoMap.cpp +++ b/agrolib/gis/geoMap.cpp @@ -24,9 +24,8 @@ */ -#include "commonConstants.h" #include "geoMap.h" -#include "math.h" +#include namespace gis { diff --git a/agrolib/gis/gis.cpp b/agrolib/gis/gis.cpp index ab307ada0..227ff8edd 100644 --- a/agrolib/gis/gis.cpp +++ b/agrolib/gis/gis.cpp @@ -598,10 +598,10 @@ namespace gis { // è possibile sapere in quale cella (row,col) si trova la stazione? std::vector distance(stations.size()); - for (int i=0;i distance(stations.size()); - for (int i=0; i - #endif - #ifndef _STRING_ - #include - #endif + #include + #include + #ifndef CRIT3DCOLOR_H #include "color.h" #endif diff --git a/agrolib/interpolation/interpolation.cpp b/agrolib/interpolation/interpolation.cpp index 1ed4a9552..93369edb5 100644 --- a/agrolib/interpolation/interpolation.cpp +++ b/agrolib/interpolation/interpolation.cpp @@ -27,6 +27,7 @@ #include #include #include +#include #include "commonConstants.h" #include "basicMath.h" @@ -41,8 +42,6 @@ #include "interpolationSettings.h" #include "meteo.h" -#include -#include using namespace std; @@ -1583,7 +1582,7 @@ void calculateFirstGuessCombinations(Crit3DProxy* myProxy) else paramIndex = {0,2}; - for (int k = 0; k < paramIndex.size(); k++) + for (int k = 0; k < int(paramIndex.size()); k++) { for (int m = 1; m < numSteps+1; m++) { @@ -1685,7 +1684,7 @@ bool setFittingParameters_otherProxies(int elevationPos, Crit3DInterpolationSett for (unsigned i=0; i < myCombination.getProxySize(); i++) { - if (i != elevationPos && myCombination.isProxyActive(i) && myCombination.isProxySignificant(i)) + if (i != unsigned(elevationPos) && myCombination.isProxyActive(i) && myCombination.isProxySignificant(i)) { mySettings->addFittingFunction(functionLinear_intercept); myFunc.push_back(functionLinear_intercept); @@ -1869,7 +1868,7 @@ void detrendingElevation(int elevationPos, std::vector parameters = mySettings->getFittingParameters().front(); float proxyValue, detrendValue; - for (int i = 0; i < myPoints.size(); i++) + for (unsigned int i = 0; i < myPoints.size(); i++) { proxyValue = myPoints[i].getProxyValue(elevationPos); @@ -2035,7 +2034,7 @@ bool multipleDetrendingOtherProxiesFitting(int elevationPos, std::vector getUseLocalDetrending() && othersPoints.size() < mySettings->getMinPointsLocalDetrending()) + if (mySettings->getUseLocalDetrending() && int(othersPoints.size()) < mySettings->getMinPointsLocalDetrending()) { for (int pos = 0; pos < proxyNr; pos++) { @@ -2093,18 +2092,19 @@ void detrendingOtherProxies(int elevationPos, std::vectorgetProxyNr(); pos++) + for (int pos=0; pos < int(mySettings->getProxyNr()); pos++) { if (pos != elevationPos && mySettings->getCurrentCombination().isProxyActive(pos) && mySettings->getCurrentCombination().isProxySignificant(pos)) { proxyValue = myPoints[i].getProxyValue(pos); - if (!isEqual(proxyValue, NODATA)) + if (! isEqual(proxyValue, NODATA)) proxyValues.push_back(double(proxyValue)); - else { + else + { parameters.erase(parameters.begin()+proxyValues.size()); myFunc.erase(myFunc.begin()+proxyValues.size()); } @@ -2141,10 +2141,10 @@ bool glocalDetrendingFitting(std::vector &myPoint if (! temp.empty()) { std::vector subsetPoints; - for (int l = 0; l < temp.size(); l++) + for (unsigned int l = 0; l < temp.size(); l++) { - for (int k = 0; k < myPoints.size(); k++) + for (unsigned int k = 0; k < myPoints.size(); k++) if (myPoints[k].index == temp[l]) { subsetPoints.push_back(myPoints[k]); @@ -2326,7 +2326,6 @@ bool preInterpolation(std::vector &myPoints, Crit Crit3DClimateParameters* myClimate, Crit3DMeteoPoint* myMeteoPoints, int nrMeteoPoints, meteoVariable myVar, Crit3DTime myTime, std::string &errorStr) { - if (myVar == precipitation || myVar == dailyPrecipitation) { int nrPrecNotNull; @@ -2459,7 +2458,7 @@ bool getMultipleDetrendingValues(Crit3DInterpolationSettings mySettings, const s } for (unsigned int i=0; i < myCombination.getProxySize(); i++) - if (i != elevationPos && myCombination.isProxyActive(i) && myCombination.isProxySignificant(i)) + if (i != unsigned(elevationPos) && myCombination.isProxyActive(i) && myCombination.isProxySignificant(i)) { if (allProxyValues[i] == NODATA) { @@ -2473,6 +2472,7 @@ bool getMultipleDetrendingValues(Crit3DInterpolationSettings mySettings, const s return (activeProxyValues.size() > 0); } + bool getProxyValuesXY(float x, float y, Crit3DInterpolationSettings* mySettings, std::vector &myValues) { float myValue; @@ -2502,6 +2502,7 @@ bool getProxyValuesXY(float x, float y, Crit3DInterpolationSettings* mySettings, return proxyComplete; } + float getFirstIntervalHeightValue(std::vector &myPoints, bool useLapseRateCode) { float maxPointsZ = getMaxHeight(myPoints, useLapseRateCode); @@ -2518,5 +2519,3 @@ float getFirstIntervalHeightValue(std::vector &my return getFirstIntervalHeightValue; } - - diff --git a/agrolib/interpolation/interpolationPoint.cpp b/agrolib/interpolation/interpolationPoint.cpp index c456f72fd..edae00e69 100644 --- a/agrolib/interpolation/interpolationPoint.cpp +++ b/agrolib/interpolation/interpolationPoint.cpp @@ -28,6 +28,7 @@ #include "gis.h" #include "commonConstants.h" + Crit3DInterpolationDataPoint::Crit3DInterpolationDataPoint() { index = NODATA; diff --git a/agrolib/interpolation/interpolationSettings.cpp b/agrolib/interpolation/interpolationSettings.cpp index 93ced5383..f0e176d48 100644 --- a/agrolib/interpolation/interpolationSettings.cpp +++ b/agrolib/interpolation/interpolationSettings.cpp @@ -29,6 +29,7 @@ #include "basicMath.h" #include "commonConstants.h" + bool Crit3DInterpolationSettings::getPrecipitationAllZero() const { return precipitationAllZero; @@ -279,7 +280,7 @@ std::vector > Crit3DInterpolationSettings::getFittingParamet std::vector Crit3DInterpolationSettings::getProxyFittingParameters(int tempIndex) { - if (tempIndex < fittingParameters.size()) + if (tempIndex < int(fittingParameters.size())) return fittingParameters[tempIndex]; else { fittingParameters.resize(tempIndex + 1); @@ -317,7 +318,7 @@ void Crit3DInterpolationSettings::addFittingFunction(const std::functiongetName()) == proxyHeight) elPos = i; @@ -341,7 +342,7 @@ void Crit3DInterpolationSettings::setChosenElevationFunction(TFittingFunction ch if (getUseMultipleDetrending()) clearFitting(); int elPos = NODATA; - for (int i = 0; i < getProxyNr(); i++) + for (int i = 0; i < int(getProxyNr()); i++) { if (getProxyPragaName(getProxy(i)->getName()) == proxyHeight) elPos = i; @@ -607,7 +608,7 @@ Crit3DProxy* Crit3DInterpolationSettings::getProxy(unsigned pos) int Crit3DInterpolationSettings::getProxyPosFromName(TProxyVar name) { - for (int i = 0; i < getProxyNr(); i++) + for (int i = 0; i < int(getProxyNr()); i++) { if (getProxyPragaName(getProxyName(i)) == name) return i; @@ -620,7 +621,7 @@ bool Crit3DInterpolationSettings::isGlocalReady(bool isGrid) { if (getMacroAreasMap() != nullptr && getMacroAreas().size() > 0) { - for (int i = 0; i < getMacroAreas().size(); i++) + for (int i = 0; i < int(getMacroAreas().size()); i++) { if ((isGrid && getMacroAreas()[i].getAreaCellsGrid().size() > 0) || (!isGrid && getMacroAreas()[i].getAreaCellsDEM().size() > 0)) diff --git a/agrolib/interpolation/kriging.cpp b/agrolib/interpolation/kriging.cpp index ac33e3373..8a4ffeedb 100644 --- a/agrolib/interpolation/kriging.cpp +++ b/agrolib/interpolation/kriging.cpp @@ -12,6 +12,7 @@ #include "kriging.h" + /*! global variables */ static short mode; static int dim; diff --git a/agrolib/interpolation/spatialControl.cpp b/agrolib/interpolation/spatialControl.cpp index 9a27e56f0..de0c7961d 100644 --- a/agrolib/interpolation/spatialControl.cpp +++ b/agrolib/interpolation/spatialControl.cpp @@ -1,6 +1,6 @@ #include #include -#include +#include #include "commonConstants.h" #include "basicMath.h" diff --git a/agrolib/mathFunctions/furtherMathFunctions.cpp b/agrolib/mathFunctions/furtherMathFunctions.cpp index 80330e280..298619f69 100644 --- a/agrolib/mathFunctions/furtherMathFunctions.cpp +++ b/agrolib/mathFunctions/furtherMathFunctions.cpp @@ -1565,11 +1565,10 @@ namespace interpolation break; } - return counter; - } + int bestFittingMarquardt_nDimension_clean(double (*func)(std::vector&)>>&, std::vector& , std::vector >&), std::vector&)>>& myFunc, std::vector >& parametersMin, std::vector >& parametersMax, @@ -1578,21 +1577,21 @@ namespace interpolation std::vector >& x ,std::vector& y, std::vector& weights) { - int i,j; int nrData = int(y.size()); std::vector nrParameters(parameters.size()); int nrParametersTotal = 0; - for (i=0; i> bestParameters(parameters.size()); std::vector > correspondenceTag(2,std::vector(nrParametersTotal)); int counterTag = 0; - for (i=0; i ySim(nrData); fittingMarquardt_nDimension_noSquares(func,myFunc,parametersMin, parametersMax, parameters, parametersDelta,correspondenceTag, maxIterationsNr, myEpsilon, x, y, weights); - for (i=0;i&)>>&, std::vector& , std::vector >&), std::vector&)>>& myFunc, std::vector >& parametersMin, std::vector >& parametersMax, @@ -2567,7 +2565,7 @@ namespace interpolation std::vector ySim(nrData); //grigliato - for (int k = 0; k < firstGuessCombinations.size(); k++) + for (int k = 0; k < int(firstGuessCombinations.size()); k++) { parameters = firstGuessCombinations[k]; fittingMarquardt_nDimension_noSquares_singleFunction(func,parametersMin, diff --git a/agrolib/project/dialogInterpolation.cpp b/agrolib/project/dialogInterpolation.cpp index ec803fd19..3d39ad5d4 100644 --- a/agrolib/project/dialogInterpolation.cpp +++ b/agrolib/project/dialogInterpolation.cpp @@ -246,25 +246,36 @@ void DialogInterpolation::multipleDetrendingChanged(int active) if (active == Qt::Checked) optimalDetrendingEdit->setChecked(Qt::Unchecked); } + void DialogInterpolation::localDetrendingChanged(int active) { minPointsLocalDetrendingEdit.setEnabled(active == Qt::Checked); - if (active == Qt::Checked) optimalDetrendingEdit->setChecked(Qt::Unchecked); + + if (active == Qt::Checked) + optimalDetrendingEdit->setChecked(Qt::Unchecked); + optimalDetrendingEdit->setEnabled(active == Qt::Unchecked); - if (active == Qt::Checked) glocalDetrendingEdit->setChecked(Qt::Unchecked); + + if (active == Qt::Checked) + glocalDetrendingEdit->setChecked(Qt::Unchecked); + glocalDetrendingEdit->setEnabled(active == Qt::Unchecked); - if (active == Qt::Checked) multipleDetrendingEdit->setChecked(Qt::Checked); + + if (active == Qt::Checked) + multipleDetrendingEdit->setChecked(true); } + void DialogInterpolation::glocalDetrendingChanged(int active) { if (active == Qt::Checked) optimalDetrendingEdit->setChecked(Qt::Unchecked); optimalDetrendingEdit->setEnabled(active == Qt::Unchecked); if (active == Qt::Checked) localDetrendingEdit->setChecked(Qt::Unchecked); localDetrendingEdit->setEnabled(active == Qt::Unchecked); - if (active == Qt::Checked) multipleDetrendingEdit->setChecked(Qt::Checked); + if (active == Qt::Checked) multipleDetrendingEdit->setChecked(true); } + void DialogInterpolation::optimalDetrendingChanged(int active) { if (active == Qt::Checked) multipleDetrendingEdit->setChecked(Qt::Unchecked); diff --git a/agrolib/project/shell.cpp b/agrolib/project/shell.cpp index f8a4d927d..7cf7631fb 100644 --- a/agrolib/project/shell.cpp +++ b/agrolib/project/shell.cpp @@ -73,13 +73,17 @@ bool attachOutputToConsole() return true; } + bool isConsoleForeground() { #ifdef _WIN32 return (GetConsoleWindow() == GetForegroundWindow()); #endif + + return true; } + void sendEnterKey(void) { #ifdef _WIN32 diff --git a/agrolib/solarRadiation/sunPosition.h b/agrolib/solarRadiation/sunPosition.h index e8474a277..caf1f9cd3 100644 --- a/agrolib/solarRadiation/sunPosition.h +++ b/agrolib/solarRadiation/sunPosition.h @@ -21,6 +21,7 @@ * \param sbsky * \return */ + long RSUN_compute_solar_position ( float longitude, float latitude, int timezone, int year, int month, int day, int hour, int minute, int second, diff --git a/src/main.cpp b/src/main.cpp index 9dd5905e9..2b71d98c1 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -1,6 +1,5 @@ #include "pragaProject.h" #include "pragaShell.h" -#include "shell.h" #include "mainGUI.h" #include "commonConstants.h" #include