Unable to unpilot

[PinkiBaron]

Sometimes, if you pilot a ship, or double click a pilot sign, it breaks piloting.
You become unable to unpilot, with it saying "You don't have a craft to release" BUT the blocks are still protected as if the craft is piloted. You cannot move the craft, or turn it at all, because it's not actually piloted.

To Reproduce
doubleclicked a pilot sign, then typed /release

Expected behavior
Having it continue piloting me, then release me. It should't protect the blocks as if it was piloted.

Version Movecraft 8

[TylerS1066]

Duplicate of #482.

This was fixed in #472.

We are working towards fixing a few more bugs before releasing a new alpha, but if you want you can download the latest dev build here which includes the fix.

EDIT: Wrong issue

[TylerS1066]

What does /craftreport say?

[PinkiBaron]

unfortunately cant do that on the server im on : )

[TylerS1066]

Can anyone elaborate a way to reliably cause this problem? It'd help greatly with debugging the problem.

[goodroach]

Can anyone elaborate a way to reliably cause this problem? It'd help greatly with debugging the problem.

It's really hard to replicate reliably, but this happens seemingly at random, but I can tell you a common trait among all these instances.

1. The craft becomes unresponsive.
2. You cannot repilot the same craft, even releasing the craft won't work even by command. I know this doesn't work, since you cannot break the blocks of the ship at all.
3. Only when there is a global release command the craft stops piloting.
4. Strangely enough, /craftreport does not report a ship instance.

[TylerS1066]

Can you try to grab me logs of when the double piloting occurs?

I'm curious if it shows double detection on console.

[TylerS1066]

As of 215642c, this is working on my Paper 1.14.4 test server.

[TylerS1066]

I had this issue again after some testing with another player.

I'm going to try make it put an error on the console when this happens.

[TylerS1066]

After some experimenting with a player, I believe this may be tied into sinking crafts not being handled properly yet.

This will likely take much longer than I originally planned to debug and solve, and as such I am going to pin this until we have a solution

[TylerS1066]

For those of you affected, running the release -a command temporarily fixes the problem by resetting the craft manager.

[galacticwarrior9]

Not sure if this helps, but I found the following in my logs when the bug occurred for a player on my server:

[23:24:29] [Server thread/INFO]: TopTrash issued server command: /pilot Corvette
[23:24:29] [Server thread/INFO]: [Movecraft] Player TopTrash piloted a craft of type Corvette with size 2000 at location: -29 x, 259 z
[23:24:30] [Server thread/INFO]: [Movecraft] Player TopTrash has released a craft of type Corvette with size 2 at coordinates : 0 x , 182 z
[23:24:30] [Server thread/WARN]: [Movecraft] Attempted to move craft with empty HashHitBox!
[23:24:30] [Server thread/WARN]: [Movecraft] Empty craft released

However, unlike the previous reports, the craft still appeared as piloted on /craftreport

This was on Alpha 6

[TylerS1066]

Does the craft disappear from the list after the sink period is over?

[galacticwarrior9]

EDIT: I'm not actually sure. I will need to double check. In the instance above, the craft remained piloted and listed on /craftreport until we removed it with WorldEdit. In the instance below, I forgot to check

Not sure if this helps, but here are some more logs with additional debugging

[13:29:31 INFO]: Zaify issued server command: /pilot AircraftCarrier
[13:29:35 INFO]: Zaify issued server command: /pilot Admin
[13:29:36 INFO]: [Movecraft] Player Zaify piloted a craft of type Admin with size 9989 at location: -172 x, -157 z
[13:29:59 INFO]: [Movecraft] Releasing craft AircraftCarrier because of SUNK. Event cancelled? false
[13:29:59 INFO]: [Movecraft] Player Zaify has released a craft of type AircraftCarrier with size 6 at coordinates : -84 x , -155 z
[13:29:59 WARN]: [Movecraft] Attempted to move craft with empty HashHitBox! Type was AircraftCarrier and class was net.countercraft.movecraft.craft.PlayerCraftImpl
[13:29:59 INFO]: [Movecraft] Releasing craft AircraftCarrier because of EMPTY. Event cancelled? false

[TylerS1066]

Can you try replicating this on the newest dev builds? I suspect it may have been solved with the redo of how sinking crafts are done, but I've not got a ton of hope in it...

[MegalithOfficial]

in 8.0.0 a.7 version im not having that issue

[TylerS1066]

in 8.0.0 a.7 version im not having that issue

That's good to hear, I'm going to keep this open for a while longer since I've called it solved early already, and it appears to be very inconsistent.