Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any plan to port this project to ROS2? #38

Open
xhuan28 opened this issue Sep 12, 2019 · 21 comments
Open

Is there any plan to port this project to ROS2? #38

xhuan28 opened this issue Sep 12, 2019 · 21 comments

Comments

@xhuan28
Copy link

xhuan28 commented Sep 12, 2019

Is there any plan to port this project to ROS2?

@yossioo
Copy link

yossioo commented Jan 1, 2020

@kralf
Maybe some guides where to start for those who dare to try? :)

@AmaurX
Copy link

AmaurX commented Feb 3, 2021

I would also be very interested for a ROS2 Foxy version. I'll like to try but a guide to which files are specific to ROS and which are not would be nice.
Also, one big issue will definitely be the issue of QoS compatibility between publishers and subscribers

@GuihVicentini
Copy link

Any update on this? I am also interested on running multiplot on ROS2. Did anyone found another solution or a guideline to adapt this solution?

@remod
Copy link
Member

remod commented Apr 11, 2022

Hello everyone,

we do not have plans at the moment to port this package to ROS2. If anyone wants to contribute, I am happy to create a ros2 branch!

@GuihVicentini
Copy link

Hi @remod I kind of have interest on this, but I am clueless on what are exactly the ROS1 dependencies on this project. Could you give me a starting point?

@remod
Copy link
Member

remod commented Apr 19, 2022

Hi @GuihVicentini

I am unsure whether I understood the question correctly - does the migration guide to ROS2 help?

@abrzozowski
Copy link

Hi @remod,

First overall, @kralf, @remod and others, kudos for the fantastic project!

It would be super to have this plugin in ROS2. Were there some steps taken in this direction?
If not, I can take care of it. I will be doing it in my free time, so it probably will take a while to do this porting, but I hope not longer than to end of this year :P

@remod
Copy link
Member

remod commented Oct 31, 2022

Hi @abrzozowski

That would be great, thank you! We're still using ROS1 and therefore cannot assist with the implementation, but we can help with the review! How would you like to proceed? Create a ros2 branch?

@abrzozowski
Copy link

Hi @remod,

Great! I will create a fork of this repo, and I will be porting on this fork. When everything works, I will create a PR to this main repo (https://github.com/ANYbotics/rqt_multiplot_plugin). Then we'll do the review. Is it a good plan?

I think that creating a ros2 branch in the main repo is an excellent idea because it can show others that there is someone who works on porting.

@remod
Copy link
Member

remod commented Nov 1, 2022

Yes that sounds great!

One input from my side: ROS2 brings along some code formatting tools. To ensure that potential bugfixes are compatible with both versions of rqt_multiplot_plugin, ROS1 and ROS2, I suggest that we do not reformat code on the ROS2 branch - is this fine for you?

@abrzozowski
Copy link

Ok, I thought about it. I will be changing as minimally as possible. This approach should help with future merging ros1-releases into ros2 as well

@abrzozowski
Copy link

I've taken a look at what is a work scope. There is one more package to port except this, a https://github.com/ANYbotics/variant. The rqt_multiplot_plugin is dependent on the variant

@remod
Copy link
Member

remod commented Nov 3, 2022

Yes exactly. In case you are not aware, the variant package does some ROS message definition parsing. Porting it to ROS2 might involve a bit more work than usually when porting a node.

@nlamprian
Copy link

Is there any ongoing activity on this topic?

@remod
Copy link
Member

remod commented Aug 14, 2023

Hi @nlamprian !

I personally am not aware of any activity.

@nlamprian
Copy link

OK, I'll see if I can get involved. This tool deserves to stay alive!

@remod
Copy link
Member

remod commented Aug 14, 2023

Nice to hear, thank you! :)

@nlamprian
Copy link

I'm back with rqt_multiplot_bridge. I chose the less painful option of using a ROS bridge. This will have to do for now.

I also tried to make it work with docker compose, but the window would not open. If you have any idea how to configure it, feel free to open a PR.

@abrzozowski
Copy link

Hi, guys. Unfortunately, from my side, the porting didn't really move forward. The variant also still needs to be ported. But I still hold onto the hope that I'll get it done this year.

@amburkoff
Copy link

I really liked using rqt_multiplot on ros1. Any news on porting to ros2?

@abrzozowski
Copy link

Unfortunately, I haven't found the time so far to do it. So, officially, I'm saying that I'm not currently dealing with it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants