From cbd5f07b8a0c9a4f27bc8cfc18106d20a0fd4f64 Mon Sep 17 00:00:00 2001 From: Marc Henry de Frahan Date: Tue, 19 Sep 2023 09:37:46 -0600 Subject: [PATCH 1/3] Turn on eb for clang-tidy --- .github/workflows/ci.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f6f1debb..1a56aea5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -547,6 +547,14 @@ jobs: Lint-clang-tidy: needs: Formatting runs-on: ubuntu-latest + strategy: + matrix: + enableeb: [EB-OFF, EB-ON] + include: + - enableeb: EB-OFF + useeb: OFF + - enableeb: EB-ON + useeb: ON steps: - name: Clone uses: actions/checkout@v3 @@ -559,6 +567,7 @@ jobs: -DCMAKE_BUILD_TYPE:STRING=Debug \ -DCMAKE_CXX_COMPILER:STRING=clang++ \ -DCMAKE_C_COMPILER:STRING=clang \ + -DPELELMEX_ENABLE_EB:BOOL=${{matrix.useeb}} \ -DPELELMEX_ENABLE_MPI:BOOL=OFF \ -DPELELMEX_ENABLE_FCOMPARE_FOR_TESTS:BOOL=OFF \ -DPELELMEX_ENABLE_MASA:BOOL=OFF \ From c946d37e15a4e1e3e9817970b0bd050558021bd5 Mon Sep 17 00:00:00 2001 From: Marc Henry de Frahan Date: Tue, 19 Sep 2023 09:41:59 -0600 Subject: [PATCH 2/3] Maybe this works --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1a56aea5..9918a040 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -552,9 +552,9 @@ jobs: enableeb: [EB-OFF, EB-ON] include: - enableeb: EB-OFF - useeb: OFF + useeb: "OFF" - enableeb: EB-ON - useeb: ON + useeb: "ON" steps: - name: Clone uses: actions/checkout@v3 From bf9c30532071dc71fbe5fedfbdf0893299ec7233 Mon Sep 17 00:00:00 2001 From: Jon Rood Date: Thu, 21 Sep 2023 08:35:43 -0600 Subject: [PATCH 3/3] Don't fail the EB matrix. --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ee84717e..bb04c37b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -554,6 +554,7 @@ jobs: useeb: "OFF" - enableeb: EB-ON useeb: "ON" + fail-fast: false steps: - name: Clone uses: actions/checkout@v3