Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Units #727

Closed
whit2333 opened this issue Oct 21, 2020 · 2 comments · Fixed by #749
Closed

Documentation: Units #727

whit2333 opened this issue Oct 21, 2020 · 2 comments · Fixed by #749
Assignees
@petricm
Labels
request

Comments

@whit2333
Copy link

whit2333 commented Oct 21, 2020 •
edited
Loading

Was the manual ever updated to document this units issue?
#398 (comment)

I just had my brain melt for a few hours as I tried to understand a units related bug.

Also from @gaede #398 (comment)

So I think the simple solution to the problem is keep the DD4hepUnits.h file as is and tell people (if they ask) we use TGeo units except for the angle.

I don't think this is correct because time appears is reported in G4 units (ns), right?
@petricm petricm self-assigned this Nov 5, 2020
@petricm
Copy link

petricm commented Nov 5, 2020

@whit2333 we were waiting with this as a new solution for unis was about to be deployed, but this is now delayed... will update the documentation on this.

@whit2333
Copy link
Author

Thanks for the update. The problem showed up as I was going from CLHEP/G4 -> DD4hep -> ACTS which are each slightly different. I have figured things out now so feel free to close this issue.

Cheers

@petricm petricm mentioned this issue Nov 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petricm petricm

Labels
request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add section about units to manual petricm/DD4hep
2 participants
@whit2333 @petricm