Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FinRL_MultiCrypto_Trading.py no longer working due to changes in ElegantRL and FinRL-Meta #61

Open
roboalex2 opened this issue May 5, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@roboalex2
Copy link

Hi, there is quite a lot broken in the current version of FinRL_MultiCrypto_Trading.ipynb

See: AI4Finance-Foundation/FinRL-Meta#291
Also see: #21

I am able to go around many of the problems by running old versions of the repos/dependencies but in the end i failed.
As mentioned in one of the urls. Since Jan 2023 ElegantRL is no longer compatible.

/FinRL-Meta/agents/elegantrl_models.py is also no longer compatible due to line 58 (and more) changing Arguments(agent=agent, env=env) to Arguments(agent_class=agent, env=env)

ray.rllib also seems to have had some breaking changes. Also tried version 2.0.0 since its from around date the tutorial was moved into this repo but still didn't work.

Please fix the tutorials. I realy would like to get started looking into FinRL.

@YangletLiu YangletLiu added the bug Something isn't working label Jun 6, 2023
@eervin123
Copy link

I would love this as well. I spent more time than I would like to admit trying to get the imports to work. I was hoping to be able to solve most of the problems so I could contribute but there were too many and I'm not familiar enough with the history of the repo to be able to point someone in the right direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants