From 3af4db74eec7a787fdc4ff1bdfc21c71c0c87615 Mon Sep 17 00:00:00 2001 From: Jan Melcher Date: Fri, 12 Jul 2024 14:12:36 +0200 Subject: [PATCH] docs: fix description of _empty filter fields Lists can never be null in cruddl. It also does not make sense to treat null as non-empty, and it was not the case. --- src/schema-generation/filter-input-types/filter-fields.ts | 2 +- .../flex-search-filter-input-types/filter-fields.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/schema-generation/filter-input-types/filter-fields.ts b/src/schema-generation/filter-input-types/filter-fields.ts index cde2cfa5..4e6d5999 100644 --- a/src/schema-generation/filter-input-types/filter-fields.ts +++ b/src/schema-generation/filter-input-types/filter-fields.ts @@ -247,7 +247,7 @@ export class EmptyListFilterField implements FilterField { constructor(public readonly field: Field) { this.name = this.field.name + '_empty'; - this.description = `Checks if \`${this.field.name}\` is an empty list (true) or a non-empty list or null (false).`; + this.description = `Checks if \`${this.field.name}\` is an empty list (true) or a non-empty list (false).`; } getFilterNode(sourceNode: QueryNode, filterValue: AnyValue): QueryNode { diff --git a/src/schema-generation/flex-search-filter-input-types/filter-fields.ts b/src/schema-generation/flex-search-filter-input-types/filter-fields.ts index d5b28fcc..612f29ba 100644 --- a/src/schema-generation/flex-search-filter-input-types/filter-fields.ts +++ b/src/schema-generation/flex-search-filter-input-types/filter-fields.ts @@ -319,7 +319,7 @@ export class FlexSearchEmptyListFilterField implements FlexSearchFilterField { constructor(public readonly field: Field) { this.name = this.field.name + '_empty'; - this.description = `Checks if \`${this.field.name}\` is an empty list (true) or a non-empty list or null (false).`; + this.description = `Checks if \`${this.field.name}\` is an empty list (true) or a non-empty list (false).`; } getFilterNode(