Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect output from parent_table_discontinuities function #74

Open
kilince opened this issue Jun 12, 2023 · 0 comments
Open

Incorrect output from parent_table_discontinuities function #74

kilince opened this issue Jun 12, 2023 · 0 comments
Labels

Comments

@kilince
Copy link

kilince commented Jun 12, 2023

The parent_table_discontinuities function should add -1 to the walker in a cycle if a warping event occurs for that specific walker. The current implementation returns -1 for all walkers in the cycle even if only one walker has warping event.

Here is an example:
I get the warping record for my file:
warping_record: [warping_Record(cycle_idx=419, walker_idx=32, target_idx=0, weight=8.720277913580345e-12)]
Then use parent_table_discontinuities function to build a parent table:
par_table_no_disc = parent_table_discontinuities(UnbindingBC, net_par_table, warping_record)
When I check the cycle 419 in my parent table, this is the output:
par_table_no_disc[419] = [-1, -1, -1,-1,-1,-1, -1,-1, -1,-1, -1,-1,-1, -1,-1,-1, -1,-1,-1,-1,-1,-1,-1, -1,-1,-1,-1, -1,-1, -1,-1,-1, -1,-1,-1,-1,-1,-1,-1, -1,-1,-1,-1, -1,-1,-1,-1,-1]

The output should be,
par_table_no_disc[419] = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, -1, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47]

@salotz salotz added the bug label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants