Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undocumented change - lazy string loading has side effect #643

Closed
MFlisar opened this issue Feb 18, 2018 · 1 comment
Closed

undocumented change - lazy string loading has side effect #643

MFlisar opened this issue Feb 18, 2018 · 1 comment
Labels

Comments

@MFlisar
Copy link

MFlisar commented Feb 18, 2018

Following is one change I saw by accident:

configBuilder.getPluginConfigurationBuilder(DialogConfigurationBuilder.class)
	.setEnabled(true)
	.setResIcon(appIcon)
	.setResText(R.string.crash_dialog_text)
	.setResTitle(R.string.crash_dialog_title)
	// following is necessary in v5.1.1 but was not in v5.0.2
	.setResPositiveButtonText(android.R.string.ok)
	.setResNegativeButtonText(android.R.string.cancel)
    ;

Seems like some default values are not set anymore

@F43nd1r
Copy link
Member

F43nd1r commented Feb 18, 2018

Only happens when the annotation is not present. So, as a workaround add @AcraDialog (with no configuration) to your Application class. Will be fixed in next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants