Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.9.0 breaks AppCompatDelegate usage #486

Closed
str4d opened this issue Jul 16, 2016 · 0 comments
Closed

Version 4.9.0 breaks AppCompatDelegate usage #486

str4d opened this issue Jul 16, 2016 · 0 comments

Comments

@str4d
Copy link
Contributor

str4d commented Jul 16, 2016

To properly use AppCompatDelegate it is necessary to initialize it before super.onCreate() is called:

protected void onCreate(Bundle savedInstanceState) {
    getDelegate().installViewFactory();
    getDelegate().onCreate(savedInstanceState);
    super.onCreate(savedInstanceState);

    // ...
}

With the hardening added to BaseCrashReportDialog in #413, this is no longer possible. A preInit(Bundle savedInstanceState) method in BaseCrashReportDialog would resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant