From a580e72392bf03d9f068a509c1fb85f0441033d4 Mon Sep 17 00:00:00 2001 From: F43nd1r Date: Fri, 20 May 2016 15:09:41 +0200 Subject: [PATCH] add comment, fix policy --- src/main/java/org/acra/config/DefaultRetryPolicy.java | 4 ++-- src/main/java/org/acra/config/RetryPolicy.java | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/acra/config/DefaultRetryPolicy.java b/src/main/java/org/acra/config/DefaultRetryPolicy.java index 5be679f7b..c5a1e9811 100644 --- a/src/main/java/org/acra/config/DefaultRetryPolicy.java +++ b/src/main/java/org/acra/config/DefaultRetryPolicy.java @@ -20,13 +20,13 @@ import java.util.List; /** - * Default {@link RetryPolicy}. Do not resend reports if at least one sender completed. + * Default {@link RetryPolicy}. Only resend if all senders failed. * @author F43nd1r * @since 4.9.0 */ public class DefaultRetryPolicy implements RetryPolicy { @Override public boolean shouldRetrySend(List senders, List failedSenders) { - return senders.size() > failedSenders.size(); + return senders.size() == failedSenders.size(); } } diff --git a/src/main/java/org/acra/config/RetryPolicy.java b/src/main/java/org/acra/config/RetryPolicy.java index b55b1de21..b8584fe19 100644 --- a/src/main/java/org/acra/config/RetryPolicy.java +++ b/src/main/java/org/acra/config/RetryPolicy.java @@ -27,6 +27,12 @@ * @since 4.9.0 */ public interface RetryPolicy { + + /** + * @param senders a list of all senders + * @param failedSenders a list of all failed senders with the thrown exceptions + * @return if the request should be resent later + */ boolean shouldRetrySend(List senders, List failedSenders); class FailedSender {