Remove optional InitTlv override in Peer (#766)

Also removed `PhoenixAndroidLegacyNodeId`.

This was needed for backward compat with old Android wallets.

Author: pm47

modules/core/src/commonMain/kotlin/fr/acinq/lightning/io/Peer.kt

@@ -173,7 +173,6 @@ data class AddressAssigned(val address: String) : PeerEvent()
  * @param watcher Watches events from the Electrum client and publishes transactions and events.
  * @param db Wraps the various databases persisting the channels and payments data related to the Peer.
  * @param socketBuilder Builds the TCP socket used to connect to the Peer.
- * @param initTlvStream Optional stream of TLV for the [Init] message we send to this Peer after connection. Empty by default.
  */
 @OptIn(ExperimentalStdlibApi::class)
 class Peer(
@@ -183,8 +182,7 @@ class Peer(
     val watcher: IWatcher,
     val db: Databases,
     socketBuilder: TcpSocket.Builder?,
-    scope: CoroutineScope,
-    private val initTlvStream: TlvStream<InitTlv> = TlvStream.empty()
+    scope: CoroutineScope
 ) : CoroutineScope by scope {
     companion object {
         private const val prefix: Byte = 0x00
@@ -235,7 +233,7 @@ class Peer(
 
     private val features = nodeParams.features
 
-    private val ourInit = Init(features.initFeatures(), initTlvStream)
+    private val ourInit = Init(features.initFeatures())
     private var theirInit: Init? = null
 
     val currentTipFlow = MutableStateFlow<Int?>(null)

modules/core/src/commonMain/kotlin/fr/acinq/lightning/wire/InitTlv.kt

@@ -1,8 +1,6 @@
 package fr.acinq.lightning.wire
 
 import fr.acinq.bitcoin.ByteVector32
-import fr.acinq.bitcoin.ByteVector64
-import fr.acinq.bitcoin.PublicKey
 import fr.acinq.bitcoin.io.Input
 import fr.acinq.bitcoin.io.Output
 
@@ -42,23 +40,4 @@ sealed class InitTlv : Tlv {
             override fun read(input: Input): OptionWillFund = OptionWillFund(LiquidityAds.WillFundRates.read(input))
         }
     }
-
-    data class PhoenixAndroidLegacyNodeId(val legacyNodeId: PublicKey, val signature: ByteVector64) : InitTlv() {
-        override val tag: Long get() = PhoenixAndroidLegacyNodeId.tag
-
-        override fun write(out: Output) {
-            LightningCodecs.writeBytes(legacyNodeId.value, out)
-            LightningCodecs.writeBytes(signature, out)
-        }
-
-        companion object : TlvValueReader<PhoenixAndroidLegacyNodeId> {
-            const val tag: Long = 0x47020001
-
-            override fun read(input: Input): PhoenixAndroidLegacyNodeId {
-                val legacyNodeId = PublicKey(LightningCodecs.bytes(input, 33))
-                val signature = ByteVector64(LightningCodecs.bytes(input, 64))
-                return PhoenixAndroidLegacyNodeId(legacyNodeId, signature)
-            }
-        }
-    }
 }

modules/core/src/commonMain/kotlin/fr/acinq/lightning/wire/LightningMessages.kt

@@ -223,7 +223,6 @@ data class Init(val features: Features, val tlvs: TlvStream<InitTlv> = TlvStream
         val readers = mapOf(
             InitTlv.Networks.tag to InitTlv.Networks.Companion as TlvValueReader<InitTlv>,
             InitTlv.OptionWillFund.tag to InitTlv.OptionWillFund.Companion as TlvValueReader<InitTlv>,
-            InitTlv.PhoenixAndroidLegacyNodeId.tag to InitTlv.PhoenixAndroidLegacyNodeId.Companion as TlvValueReader<InitTlv>,
         )
 
         override fun read(input: Input): Init {