Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MOM5 to include ice-ocean BGC coupling bug fix #12

Merged
merged 2 commits into from
Jun 30, 2024
Merged

Update MOM5 to include ice-ocean BGC coupling bug fix #12

merged 2 commits into from
Jun 30, 2024

Conversation

dougiesquire
Copy link
Collaborator

Closes #7. Release version updated to 2024.06.0

@github-actions GitHub Actions
Copy link

🚀 Deploying access-om2-bgc 2024.06.0 as prerelease pr12-1

Details and usage instructions

This access-om2-bgc model will be deployed as:

  • 2024.06.0 as a Release (when merged).
  • pr12-1 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules/access-models/
module load access-om2-bgc/pr12-1

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.21/spack in the access-om2-bgc-pr12-1 environment.

🛠️ Using: spack-packages `2024.04.20`, spack-config `2024.04.23`
Details

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

@dougiesquire
Copy link
Collaborator Author

Did I make a boo-boo?

@CodeGat
Copy link
Contributor

CodeGat commented Jun 27, 2024

I'll have a look now

CodeGat
CodeGat reviewed Jun 27, 2024
View reviewed changes
spack.yaml Outdated Show resolved Hide resolved
@dougiesquire @CodeGat
Update mom5 version in spack.yaml spack:models:tcl:projections
f773142 
Co-authored-by: Tommy Gatti <tommy.gatti@anu.edu.au>
@github-actions GitHub Actions
Copy link

🚀 Deploying access-om2-bgc 2024.06.0 as prerelease pr12-2

Details and usage instructions

This access-om2-bgc model will be deployed as:

  • 2024.06.0 as a Release (when merged).
  • pr12-2 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules/access-models/
module load access-om2-bgc/pr12-2

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.21/spack in the access-om2-bgc-pr12-2 environment.

🛠️ Using: spack-packages `2024.04.20`, spack-config `2024.04.23`
Details

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

@github-actions GitHub Actions
Copy link

🚀 Deploying access-om2-bgc 2024.06.0 as prerelease pr12-2

Details and usage instructions

This access-om2-bgc model will be deployed as:

  • 2024.06.0 as a Release (when merged).
  • pr12-2 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules/access-models/
module load access-om2-bgc/pr12-2

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.21/spack in the access-om2-bgc-pr12-2 environment.

🛠️ Using: spack-packages `2024.04.20`, spack-config `2024.04.23`
Details

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

aidanheerdegen
aidanheerdegen approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dougiesquire dougiesquire merged commit 2cf4904 into main Jun 30, 2024
13 checks passed
@dougiesquire dougiesquire deleted the dougiesquire/issue7 branch June 30, 2024 23:54
@CodeGat CodeGat mentioned this pull request Jul 4, 2024
Closed
CodeGat added a commit that referenced this pull request Jul 5, 2024
@CodeGat
Revert both "Merge pull request #11 from ACCESS-NRI/dougiesquire/issu…
1987f64 
…e8" and "Update MOM5 to include ice-ocean BGC coupling bug fix (#12)"

This reverts commit 1d521f0, reversing
changes made to 92ae023.
This also reverts commit 2cf4904.
CodeGat added a commit that referenced this pull request Jul 9, 2024
@CodeGat
MOM5 WOMBAT Fix without Dependency Update (#17)
dcd452b 
* Revert both "Merge pull request #11 from ACCESS-NRI/dougiesquire/issue8" and "Update MOM5 to include ice-ocean BGC coupling bug fix (#12)"

This reverts commit 1d521f0, reversing
changes made to 92ae023.
This also reverts commit 2cf4904.

* Deleted versions.schema.json, updated spack-packages 2024.07.03, spack-config 2024.07.05

* Updated mom5 2024.06.27 (wombat fix), updated model version 2024.07.0, updated formatting, made compiler version/target required

* versions.json: Added required field 'spack'

* versions.json: spack-packages 2024.07.06 (abgc runs type for dependencies)

* spack.yaml: Added comments, rebuilding using ACCESS-NRI/spack@42e3100

* versions.json: Update spack-packages 2024.07.08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeGat CodeGat CodeGat left review comments

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New release with WOMBAT coupling bug fix
3 participants
@dougiesquire @CodeGat @aidanheerdegen