-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📱 Not Mobile responsive. #3
Comments
Impossible, i try and i realise it's impossible haha. (with git) We can't get any information from user device, so we can't make an api call with generated variables like You can only render your jokes as an jpg image with markdown cause is parsed (cause you download it with So, if you wan't help we can make a render who like great on mobile and desktop. |
@NOPROD you have github-readme-stats on your profile, check those on mobile, working fine. I wanted something similar, but it should also adjust to the text that is given in the card. |
try setting proper viewbox on the SVG and don't use any units on the width, height. just give them And yes you cannot make use of responsive text sizes, just make your card maintain it's aspect ratio.. thats best you can do i think. |
@anuraghazra I tried doing that, but text was clipping if it was more than 50 characters in one line, so I made it choose the viewbox itself. Do I make a text-breaking mechanism, if it exceeds a certain word per line limit? |
Yeah you can do that we also have that in github-readme-stats https://github.com/anuraghazra/github-readme-stats/blob/master/src/common/utils.js#L145-L160 |
Great! I will fix it soon. |
Jokes' card is not mobile responsive.
The text was updated successfully, but these errors were encountered: