Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit code role for code element #463

Closed
MatanBobi opened this issue Dec 28, 2022 · 2 comments
Closed

Implicit code role for code element #463

MatanBobi opened this issue Dec 28, 2022 · 2 comments

Comments

@MatanBobi
Copy link

Hi!
As a follow up for testing-library/dom-testing-library#1100
It looks like the ARIA spec added an implicit role code for the code HTML element.
image
https://www.w3.org/TR/html-aria/

We'd be happy for a fix here so we'll also get it in testing-library :)
Thanks for your help! :)

@timdeschryver
Copy link

@MatanBobi if I'm not mistaken this will be available in the next version.
The PR #447 should've fixed it.
Because an issue from dom-testing-library is mentioned, I wanted to piggy back on this and also mention another issue testing-library/dom-testing-library#1201 which will also be fixed.

@MatanBobi
Copy link
Author

MatanBobi commented Jan 6, 2023

Yeah @timdeschryver, I missed that because I was only looking at the README of this project and it didn't mention code role so I guess this should also be updated. And yeah it looks like the other should also be resolved :) Thanks for catching this.
I'll close this one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants