Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Missing route /{ip} #13

Closed
nesc58 opened this issue Feb 22, 2021 · 2 comments · Fixed by #14
Closed

Discussion: Missing route /{ip} #13

nesc58 opened this issue Feb 22, 2021 · 2 comments · Fixed by #14

Comments

@nesc58
Copy link

nesc58 commented Feb 22, 2021

Hi again,
thanks a lot for this great project. you shall be blessed

Years ago I have created a pull request to handle the following:

The route "/{ip}" is added to lookup a single IP via GET method. 

Is it possible to readd this route?

Background:
From mine point of view it makes more sense to resolve a single IP due a GET Request instead of sending a POST request filled with a single IP.
POST feels more like "Create a resource"
GET feels more like "Find something for me"

Kind regards!

@9seconds
Copy link
Owner

Sure, I've missed that. Will do!

@nesc58
Copy link
Author

nesc58 commented Feb 24, 2021

Works like a charm. Thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants