Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up/down doesn't work in command palette? #336

Closed
max-sixty opened this issue Jun 6, 2024 · 3 comments
Closed

up/down doesn't work in command palette? #336

max-sixty opened this issue Jun 6, 2024 · 3 comments

Comments

@max-sixty
Copy link

I'm checking out Dance again as an alternative to the vim extension since #18 seems to be partly fixed.

Currently up / down doesn't work in the command palette — I hit Cmd+Shift+P, and then down doesn't navigate down.

When I add this exclusion to the keybindings config:

{
        "key": "down",
        "command": "-dance.changeInput",
        "when": "inputFocus && !textInputFocus"
    }

...then it works fine, and I get the movement I'd expect:

[KeybindingService]: \ From 27 keybinding entries, matched quickInput.next, when: inQuickInput && quickInputType == 'quickPick', source: built-in.

I'm guessing there's something I'm doing wrong given the severity of this, but any idea what might be happening? I tried on a blank profile with only this extension and still get this behavior.

@ilyagr
Copy link

ilyagr commented Jun 7, 2024

I think I managed to reproduce it. I could not reproduce this at all with VS Code 1.89 (or maybe it had to do with not sufficiently reloading the editor after downgrading the extensions. I told it to "restart extensions", but I did not reboot the editor).

With VS Code 1.90, I can reproduce it with the release version of the extension, but not the pre-release.

@max-sixty, are you on 1.90? Do you still have the problem if you upgrade to the pre-release version?

@max-sixty
Copy link
Author

It works fine on the pre-release! I'll close...

@71
Copy link
Owner

71 commented Jun 14, 2024

Argh, sorry, I encountered this in the 1.90 prerelease, released a fix in a Dance pre-release, but forgot about it in the meantime and never released a proper version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants