From d212da4097051d6cf303a6e3a44c81e48d7076d9 Mon Sep 17 00:00:00 2001 From: ghiscoding Date: Fri, 29 Dec 2023 13:02:25 -0500 Subject: [PATCH] chore: prefer single quote in ESLint --- .eslintrc | 1 + src/controls/slick.columnmenu.ts | 2 +- src/models/editorValidator.interface.ts | 4 ++-- src/models/grouping.interface.ts | 8 ++++---- src/plugins/slick.cellselectionmodel.ts | 2 +- src/plugins/slick.checkboxselectcolumn.ts | 4 ++-- src/plugins/slick.draggablegrouping.ts | 6 +++--- src/plugins/slick.rowselectionmodel.ts | 2 +- src/slick.dataview.ts | 10 +++++----- src/slick.grid.ts | 2 +- src/slick.remotemodel-yahoo.ts | 12 ++++++------ src/slick.remotemodel.ts | 8 ++++---- 12 files changed, 31 insertions(+), 30 deletions(-) diff --git a/.eslintrc b/.eslintrc index f9ee0720e..73cd4ae56 100644 --- a/.eslintrc +++ b/.eslintrc @@ -40,6 +40,7 @@ "@typescript-eslint/no-explicit-any": "off", "@typescript-eslint/no-non-null-assertion": "off", "@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "^_", "destructuredArrayIgnorePattern": "^_" }], + "@typescript-eslint/quotes": ["error", "single", { "allowTemplateLiterals": true }], "@typescript-eslint/semi": "error", "curly": "error", "cypress/no-assigning-return-values": "off", diff --git a/src/controls/slick.columnmenu.ts b/src/controls/slick.columnmenu.ts index ee320a8bb..fb95360a1 100644 --- a/src/controls/slick.columnmenu.ts +++ b/src/controls/slick.columnmenu.ts @@ -134,7 +134,7 @@ export class SlickColumnMenu { const colName: string = this.columns[i].name instanceof HTMLElement ? (this.columns[i].name as HTMLElement).innerHTML : (this.columns[i].name || '') as string; - excludeCssClass = this.columns[i].excludeFromColumnPicker ? "hidden" : ""; + excludeCssClass = this.columns[i].excludeFromColumnPicker ? 'hidden' : ''; const liElm = document.createElement('li'); liElm.className = excludeCssClass; diff --git a/src/models/editorValidator.interface.ts b/src/models/editorValidator.interface.ts index 3ee857db9..710cb068a 100644 --- a/src/models/editorValidator.interface.ts +++ b/src/models/editorValidator.interface.ts @@ -1,4 +1,4 @@ -import { EditorArguments } from "./editorArguments.interface"; -import { EditorValidationResult } from "./editorValidationResult.interface"; +import { EditorArguments } from './editorArguments.interface'; +import { EditorValidationResult } from './editorValidationResult.interface'; export type EditorValidator = (value: any, args?: EditorArguments) => EditorValidationResult; diff --git a/src/models/grouping.interface.ts b/src/models/grouping.interface.ts index 8f033ee4a..75e25a11d 100644 --- a/src/models/grouping.interface.ts +++ b/src/models/grouping.interface.ts @@ -1,7 +1,7 @@ -import { Aggregator } from "./aggregator.interface"; -import { GroupingComparerItem } from "./groupingComparerItem.interface"; -import { GroupingFormatterItem } from "./groupingFormatterItem.interface"; -import { SortDirectionNumber } from "./sortDirectionNumber.enum"; +import { Aggregator } from './aggregator.interface'; +import { GroupingComparerItem } from './groupingComparerItem.interface'; +import { GroupingFormatterItem } from './groupingFormatterItem.interface'; +import { SortDirectionNumber } from './sortDirectionNumber.enum'; export type GroupingGetterFunction = (value: T) => string; diff --git a/src/plugins/slick.cellselectionmodel.ts b/src/plugins/slick.cellselectionmodel.ts index aff2e6936..58168d420 100644 --- a/src/plugins/slick.cellselectionmodel.ts +++ b/src/plugins/slick.cellselectionmodel.ts @@ -113,7 +113,7 @@ export class SlickCellSelectionModel { if (rangeHasChanged) { // provide extra "caller" argument through SlickEventData to avoid breaking pubsub event that only accepts an array of selected range const eventData = new SlickEventData(null, this._ranges); - Object.defineProperty(eventData, 'detail', { writable: true, configurable: true, value: { caller: caller || "SlickCellSelectionModel.setSelectedRanges" } }); + Object.defineProperty(eventData, 'detail', { writable: true, configurable: true, value: { caller: caller || 'SlickCellSelectionModel.setSelectedRanges' } }); this.onSelectedRangesChanged.notify(this._ranges, eventData); } } diff --git a/src/plugins/slick.checkboxselectcolumn.ts b/src/plugins/slick.checkboxselectcolumn.ts index e513d4dab..c4cb99c09 100644 --- a/src/plugins/slick.checkboxselectcolumn.ts +++ b/src/plugins/slick.checkboxselectcolumn.ts @@ -344,7 +344,7 @@ export class SlickCheckboxSelectColumn implements SlickPlugin { id: this._options.columnId, name: (this._options.hideSelectAllCheckbox || this._options.hideInColumnTitleRow) ? '' : ``, toolTip: (this._options.hideSelectAllCheckbox || this._options.hideInColumnTitleRow) ? '' : this._options.toolTip, - field: "sel", + field: 'sel', width: this._options.width, resizable: false, sortable: false, @@ -360,7 +360,7 @@ export class SlickCheckboxSelectColumn implements SlickPlugin { protected addCheckboxToFilterHeaderRow(grid: SlickGrid) { this._handler.subscribe(grid.onHeaderRowCellRendered, (_e: any, args: any) => { - if (args.column.field === "sel") { + if (args.column.field === 'sel') { Utils.emptyElement(args.node); const spanElm = document.createElement('span'); spanElm.id = 'filter-checkbox-selectall-container'; diff --git a/src/plugins/slick.draggablegrouping.ts b/src/plugins/slick.draggablegrouping.ts index 317e339d7..755181342 100644 --- a/src/plugins/slick.draggablegrouping.ts +++ b/src/plugins/slick.draggablegrouping.ts @@ -312,7 +312,7 @@ export class SlickDraggableGrouping { } } this._columnsGroupBy = newGroupingOrder; - this.updateGroupBy("sort-group"); + this.updateGroupBy('sort-group'); }, }); @@ -393,7 +393,7 @@ export class SlickDraggableGrouping { protected addColumnGroupBy(column: Column) { this._columnsGroupBy.push(column); - this.updateGroupBy("add-group"); + this.updateGroupBy('add-group'); } protected addGroupByRemoveClickHandler(id: string | number, groupRemoveIconElm: HTMLDivElement, headerColumnElm: HTMLDivElement, entry: any) { @@ -454,7 +454,7 @@ export class SlickDraggableGrouping { this._groupToggler.style.display = 'none'; } } - this.updateGroupBy("remove-group"); + this.updateGroupBy('remove-group'); } protected toggleGroupToggler(targetElm: Element | null, collapsing = true, shouldExecuteDataViewCommand = true) { diff --git a/src/plugins/slick.rowselectionmodel.ts b/src/plugins/slick.rowselectionmodel.ts index 026913cf4..5611ae8d5 100644 --- a/src/plugins/slick.rowselectionmodel.ts +++ b/src/plugins/slick.rowselectionmodel.ts @@ -143,7 +143,7 @@ export class SlickRowSelectionModel { // provide extra "caller" argument through SlickEventData to avoid breaking pubsub event that only accepts an array of selected range const eventData = new SlickEventData(null, this._ranges); - Object.defineProperty(eventData, 'detail', { writable: true, configurable: true, value: { caller: caller || "SlickRowSelectionModel.setSelectedRanges" } }); + Object.defineProperty(eventData, 'detail', { writable: true, configurable: true, value: { caller: caller || 'SlickRowSelectionModel.setSelectedRanges' } }); this.onSelectedRangesChanged.notify(this._ranges, eventData); } diff --git a/src/slick.dataview.ts b/src/slick.dataview.ts index a97d84d4b..dc54dbba3 100644 --- a/src/slick.dataview.ts +++ b/src/slick.dataview.ts @@ -217,7 +217,7 @@ export class SlickDataView implements CustomD item = this.items[i]; id = item[this.idProperty as keyof TData] as DataIdType; if (id === undefined) { - throw new Error("[SlickGrid DataView] Each data element must implement a unique 'id' property"); + throw new Error(`[SlickGrid DataView] Each data element must implement a unique 'id' property`); } // if items have been marked as deleted we skip them for the new final items array @@ -249,7 +249,7 @@ export class SlickDataView implements CustomD for (let i = startingIndex, l = this.items.length; i < l; i++) { id = this.items[i][this.idProperty as keyof TData] as DataIdType; if (id === undefined) { - throw new Error("[SlickGrid DataView] Each data element must implement a unique 'id' property"); + throw new Error(`[SlickGrid DataView] Each data element must implement a unique 'id' property`); } this.idxById.set(id, i); } @@ -263,7 +263,7 @@ export class SlickDataView implements CustomD for (let i = 0, l = this.items.length; i < l; i++) { id = this.items[i][this.idProperty as keyof TData] as DataIdType; if (id === undefined || this.idxById.get(id) !== i) { - throw new Error("[SlickGrid DataView] Each data element must implement a unique 'id' property"); + throw new Error(`[SlickGrid DataView] Each data element must implement a unique 'id' property`); } } } @@ -576,7 +576,7 @@ export class SlickDataView implements CustomD */ updateItems(ids: DataIdType[], newItems: T[]) { if (ids.length !== newItems.length) { - throw new Error("[SlickGrid DataView] Mismatch on the length of ids and items provided to update"); + throw new Error('[SlickGrid DataView] Mismatch on the length of ids and items provided to update'); } for (let i = 0, l = newItems.length; i < l; i++) { this.updateSingleItem(ids[i], newItems[i]); @@ -705,7 +705,7 @@ export class SlickDataView implements CustomD throw new Error('[SlickGrid DataView] Invalid or non-matching id ' + this.idxById.get(id)); } if (!this.sortComparer) { - throw new Error("[SlickGrid DataView] sortedUpdateItem() requires a sort comparer, use sort()"); + throw new Error('[SlickGrid DataView] sortedUpdateItem() requires a sort comparer, use sort()'); } const oldItem = this.getItemById(id); if (this.sortComparer(oldItem, item) !== 0) { diff --git a/src/slick.grid.ts b/src/slick.grid.ts index 1a4553607..49aa8d91a 100644 --- a/src/slick.grid.ts +++ b/src/slick.grid.ts @@ -2441,7 +2441,7 @@ export class SlickGrid = Column, O e if (!this.stylesheet) { const sheets: any = (this._options.shadowRoot || document).styleSheets; - if (this._options.devMode && typeof this._options.devMode?.ownerNodeIndex === "number" && this._options.devMode.ownerNodeIndex >= 0) { + if (this._options.devMode && typeof this._options.devMode?.ownerNodeIndex === 'number' && this._options.devMode.ownerNodeIndex >= 0) { sheets[this._options.devMode.ownerNodeIndex].ownerNode = this._style; } diff --git a/src/slick.remotemodel-yahoo.ts b/src/slick.remotemodel-yahoo.ts index 14ee35f07..5f0079f62 100644 --- a/src/slick.remotemodel-yahoo.ts +++ b/src/slick.remotemodel-yahoo.ts @@ -74,10 +74,10 @@ export class SlickRemoteModelYahoo { const recStart = (fromPage * this.PAGESIZE); const recCount = (((toPage - fromPage) * this.PAGESIZE) + this.PAGESIZE); - const url = "https://query.yahooapis.com/v1/public/yql?q=select%20*%20from%20rss" - + "(" + recStart + "%2C" + recCount + ")" - + "%20where%20url%3D%22http%3A%2F%2Frss.news.yahoo.com%2Frss%2Ftopstories%22" - + "&format=json"; + const url = 'https://query.yahooapis.com/v1/public/yql?q=select%20*%20from%20rss' + + '(' + recStart + '%2C' + recCount + ')' + + '%20where%20url%3D%22http%3A%2F%2Frss.news.yahoo.com%2Frss%2Ftopstories%22' + + '&format=json'; if (this.h_request !== null) { clearTimeout(this.h_request); @@ -91,7 +91,7 @@ export class SlickRemoteModelYahoo { this.req = window.$.jsonp({ url, - callbackParameter: "callback", + callbackParameter: 'callback', cache: true, success: (json: any) => { this.onSuccess(json, recStart); @@ -108,7 +108,7 @@ export class SlickRemoteModelYahoo { onError(fromPage: number, toPage: number) { - alert("error loading pages " + fromPage + " to " + toPage); + alert('error loading pages ' + fromPage + ' to ' + toPage); } // SAMPLE DATA diff --git a/src/slick.remotemodel.ts b/src/slick.remotemodel.ts index bdfd853d4..bb764223e 100644 --- a/src/slick.remotemodel.ts +++ b/src/slick.remotemodel.ts @@ -78,10 +78,10 @@ export class SlickRemoteModel { return; } - let url = "http://octopart.com/api/v3/parts/search?apikey=68b25f31&include[]=short_description&show[]=uid&show[]=manufacturer&show[]=mpn&show[]=brand&show[]=octopart_url&show[]=short_description&q=" + this.searchstr + "&start=" + (fromPage * this.PAGESIZE) + "&limit=" + (((toPage - fromPage) * this.PAGESIZE) + this.PAGESIZE); + let url = 'http://octopart.com/api/v3/parts/search?apikey=68b25f31&include[]=short_description&show[]=uid&show[]=manufacturer&show[]=mpn&show[]=brand&show[]=octopart_url&show[]=short_description&q=' + this.searchstr + '&start=' + (fromPage * this.PAGESIZE) + '&limit=' + (((toPage - fromPage) * this.PAGESIZE) + this.PAGESIZE); if (this.sortcol !== null) { - url += ("&sortby=" + this.sortcol + ((this.sortdir > 0) ? "+asc" : "+desc")); + url += ('&sortby=' + this.sortcol + ((this.sortdir > 0) ? '+asc' : '+desc')); } if (this.h_request !== null) { @@ -96,7 +96,7 @@ export class SlickRemoteModel { this.req = window.$.jsonp({ url, - callbackParameter: "callback", + callbackParameter: 'callback', cache: true, success: this.onSuccess, error: () => this.onError(fromPage, toPage) @@ -107,7 +107,7 @@ export class SlickRemoteModel { } protected onError(fromPage: number | string, toPage: number | string) { - alert("error loading pages " + fromPage + " to " + toPage); + alert('error loading pages ' + fromPage + ' to ' + toPage); } protected onSuccess(resp: any) {