Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add rowHighlightCssClass & highlightRow() to SlickGrid #950

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Dec 20, 2023

  • this new approach is much simpler than using ItemMetadata and calling multiple updateItem() and render() and is a lot more performant
  • also fix potential mem leaks found on some setTimeout not having any clearTimeout assigned which could cause potential mem leaks
  • note that is only a temporary highlight and will also disappear as soon as soon as we call any of: scroll, render, invalidate

brave_9niv1NRv93
brave_RUWpJ4EsE4

- this new approach is much simpler than using ItemMetadata and calling multiple `updateItem()` and `render()` and is a lot more performant
- also fix potential mem leaks found on some `setTimeout` not having any `clearTimeout` assigned which could cause potential mem leaks
@ghiscoding ghiscoding merged commit 33e9f2e into master Dec 20, 2023
2 checks passed
@ghiscoding ghiscoding deleted the feat/grid-highlight-row branch December 20, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant