feat: show a shadow element of the row being moved/dragged #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ghiscoding
commented
Oct 21, 2021
•
ghiscoding
commented
- add option to create a simple clone of the row being moved and show it as a shadow (cloned element) of the row being moved so that we know exactly which row is being dragged (it follow the mouse cursor and once we stop moving it gets destroyed)
- also add options to change this shadow element opacity & scale size
- it's a simple feature but is very helpful to not lose track of exactly which row we're dragging
- add option to create a simple clone of the row being moved and show it as a shadow of the row being moved so that we know exactly which row is being dragged
ghiscoding
changed the title
ghiscoding
changed the title
|
Looks good to me. Nice little feature ... |
|
@6pac thanks, I'm done with it, so feel free to merge EDIT |
ghiscoding
changed the title
ghiscoding
changed the title
|
@6pac |
- when starting the row drag at first it always starts at 0px and then jumps at the position the user started the drag so it looks like it jumps from 0px to let 50px if you move 2nd row and it's a bit annoying (it's like a flicker for half a second). We can simply create the proxy/guide/shadow as hidden and only show it after we move so we won't see the first flicker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.