Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken UI when loading grid from hidden div/tab #618

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Jun 24, 2021

  • this bug is visible to the user when we try to build/load a grid from an hidden div (or a tab that is not active like below), what happens is that the Header Titles (header column) is shown behind the filter bar (header row) and to the user this seems broken. What happens is that the header height will be 0 and when that happens we can simply calculate it ourselves to avoid ever showing header without a height

see below, we load the page with active tab being the 1st tab, then if we go to 2nd tab (without the fix) we won't see the header titles... on the other end, with the fix, the header title bar will show up correctly

without the fix (header bar is height 0 and ends up in behind the filter bar)

image

after the fix

image

@ghiscoding ghiscoding requested a review from 6pac June 24, 2021 21:26
@ghiscoding
Copy link
Collaborator Author

@6pac
Could you do a new version after merging, there's this and other changes I'd like to use... thanks mate 😄

@6pac 6pac merged commit 2ba2007 into master Jun 24, 2021
@ghiscoding ghiscoding deleted the bugfix/resize-ui-header-row branch August 12, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants