fix: setOptions should call setOverflow when changing frozenColumns
#608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if we change from a regular grid to a frozen grid dynamically by calling `setOptions({ frozenColumn: 2 })` then it should call `setOverflow` to redo the associated css overflow. This PR does just that and prior to this PR the overflow was just reset and sometime the scrolling was showing up on the left section when it shouldn't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setOptions({ frozenColumn: 2 })then it should callsetOverflowto redo the associated css overflow. This PR does just that and prior to this PR the overflow was just reset and sometime the scrolling was showing up on the left section when it shouldn't@6pac after merging this PR, could you please do another version release since this bug has been affecting our users and I wish to close it once and for all. Thanks a lot 🍻