Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataView): add getAllSelectedItems function #544

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Oct 15, 2020

  • also renamed getAllSelectedRows to getAllSelectedIds
  • this PR is to address this comment

Let's wait feedback by @arashdalir before merging

- also renamed `getAllSelectedRows` to `getAllSelectedIds`
@ghiscoding ghiscoding changed the title feat(dataView): add getAllSelectedItems function WIP - feat(dataView): add getAllSelectedItems function Oct 16, 2020
@ghiscoding ghiscoding changed the title WIP - feat(dataView): add getAllSelectedItems function feat(dataView): add getAllSelectedItems function Oct 16, 2020
@ghiscoding
Copy link
Collaborator Author

Here's the feedback from @arashdalir

@ghiscoding oh I see my problem now! in my dataset the idx was the same as id; confused me...
please go for the function name change :) you are right, again!

@6pac
Since I got the feedback and we both tested, you can merge now

@6pac 6pac merged commit 39707b8 into master Oct 16, 2020
@ghiscoding ghiscoding deleted the feat/dataview-get-selected-items branch October 16, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants